bug: updateCookies ignores error from page.Context().Cookies() #7

New Issue

Claude · 2026-02-14T16:05:50Z

Claude commented

2026-02-14 16:05:50 +00:00

Parent: #1

Description

In playwright.go:138-153, updateCookies() calls page.Context().Cookies(page.URL()) and assigns both cookies and err, but err is not checked before iterating cookies:

func (b playWrightBrowser) updateCookies(_ context.Context, page playwright.Page) error {
    if b.cookieJar != nil {
        cookies, err := page.Context().Cookies(page.URL())
        // BUG: err is not checked here — if Cookies() fails, cookies may be nil/empty
        // and err is only used in the loop below for Set()

        for _, cookie := range cookies {
            err = b.cookieJar.Set(playwrightCookieToCookie(cookie))
            if err != nil {
                return fmt.Errorf("error setting cookie in cookie jar: %w", err)
            }
        }
    }
    return nil
}

If Cookies() returns an error, it's silently swallowed and the cookie jar won't be updated.

Fix

Add if err != nil { return fmt.Errorf("error getting cookies: %w", err) } after the Cookies() call.

**Parent:** #1 ## Description In `playwright.go:138-153`, `updateCookies()` calls `page.Context().Cookies(page.URL())` and assigns both `cookies` and `err`, but `err` is not checked before iterating `cookies`: ```go func (b playWrightBrowser) updateCookies(_ context.Context, page playwright.Page) error { if b.cookieJar != nil { cookies, err := page.Context().Cookies(page.URL()) // BUG: err is not checked here — if Cookies() fails, cookies may be nil/empty // and err is only used in the loop below for Set() for _, cookie := range cookies { err = b.cookieJar.Set(playwrightCookieToCookie(cookie)) if err != nil { return fmt.Errorf("error setting cookie in cookie jar: %w", err) } } } return nil } ``` If `Cookies()` returns an error, it's silently swallowed and the cookie jar won't be updated. ## Fix Add `if err != nil { return fmt.Errorf("error getting cookies: %w", err) }` after the `Cookies()` call.

Claude added the bug priority/medium type/task labels 2026-02-14 16:06:15 +00:00

Claude referenced this issue

2026-02-14 16:09:00 +00:00

Epic: Error Handling & Correctness #1

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude commented

2026-02-15 16:19:10 +00:00

Starting work on this as part of PR 6 (also includes #18). Will add error check for page.Context().Cookies() in playwright.go:140.

Starting work on this as part of PR 6 (also includes #18). Will add error check for `page.Context().Cookies()` in `playwright.go:140`.

Claude referenced this issue