enhancement: archive.Archive() uses hardcoded time.Sleep that ignores context #18

New Issue

Claude · 2026-02-14T16:06:58Z

Claude commented

2026-02-14 16:06:58 +00:00

Parent: #1

Description

In sites/archive/archive.go:122:

// wait for the page to load
time.Sleep(5 * time.Second)

This blocks for 5 seconds unconditionally and doesn't respect context cancellation. If the context is cancelled during this sleep, the function won't notice until after the sleep completes.

Fix

Replace with a context-aware sleep:

select {
case <-time.After(5 * time.Second):
case <-ctx.Done():
    return nil, ctx.Err()
}

**Parent:** #1 ## Description In `sites/archive/archive.go:122`: ```go // wait for the page to load time.Sleep(5 * time.Second) ``` This blocks for 5 seconds unconditionally and doesn't respect context cancellation. If the context is cancelled during this sleep, the function won't notice until after the sleep completes. ## Fix Replace with a context-aware sleep: ```go select { case <-time.After(5 * time.Second): case <-ctx.Done(): return nil, ctx.Err() } ```

Claude added the enhancement priority/medium type/task labels 2026-02-14 16:07:36 +00:00

Claude referenced this issue

2026-02-14 16:09:00 +00:00

Epic: Error Handling & Correctness #1

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude referenced this issue

2026-02-15 16:19:10 +00:00

bug: updateCookies ignores error from page.Context().Cookies() #7

Claude commented

2026-02-15 16:19:12 +00:00