steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix updateCookies error + context-aware sleep (#7, #18) #37

Merged
Claude merged 1 commits from fix/cookies-error-and-context-sleep into main 2026-02-15 16:20:06 +00:00
Conversation 0 Commits 1 Files Changed 2 +7 -6
Claude commented 2026-02-15 16:20:02 +00:00
Collaborator
Copy Link

Summary

  • Check error from page.Context().Cookies() in playwright.go:updateCookies() before iterating, preventing silent failures when cookie retrieval fails
  • Replace time.Sleep(5s) with context-aware select using time.After in archive.go:Archive(), allowing the wait to be cancelled promptly when the context is done

Test plan

  • go build ./... passes
  • go test ./... passes
  • go vet ./... passes
  • Verify archive cancellation is responsive during the initial 5s wait

Closes #7, #18
Parent: #31 (Phase 2, PR 6)

🤖 Generated with Claude Code

## Summary - Check error from `page.Context().Cookies()` in `playwright.go:updateCookies()` before iterating, preventing silent failures when cookie retrieval fails - Replace `time.Sleep(5s)` with context-aware `select` using `time.After` in `archive.go:Archive()`, allowing the wait to be cancelled promptly when the context is done ## Test plan - [x] `go build ./...` passes - [x] `go test ./...` passes - [x] `go vet ./...` passes - [ ] Verify archive cancellation is responsive during the initial 5s wait Closes #7, #18 **Parent:** #31 (Phase 2, PR 6) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Claude added 1 commit 2026-02-15 16:20:02 +00:00
fix: check Cookies() error and use context-aware sleep
All checks were successful
CI / build (pull_request) Successful in 46s
Details
CI / vet (pull_request) Successful in 47s
Details
CI / test (pull_request) Successful in 1m22s
Details
769b870a17 
- playwright.go: check error from page.Context().Cookies() before
  iterating over results, preventing silent failures
- archive.go: replace time.Sleep(5s) with context-aware select using
  time.After, allowing the operation to be cancelled promptly

Closes #7, #18

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude merged commit 85e4632ea9 into main 2026-02-15 16:20:06 +00:00
Claude deleted branch fix/cookies-error-and-context-sleep 2026-02-15 16:20:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#37
Delete Branch "fix/cookies-error-and-context-sleep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?