steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deduplicate helpers (#13, #14) #40

Merged
Claude merged 1 commits from refactor/deduplicate-helpers into main 2026-02-15 16:28:55 +00:00
Conversation 0 Commits 1 Files Changed 6 +57 -84
Claude commented 2026-02-15 16:27:07 +00:00
Collaborator
Copy Link

Summary

  • Extract identical numericOnly inline functions from powerball and megamillions into shared sites/internal/parse.NumericOnly with unit tests
  • Extract duplicated DuckDuckGo result parsing from Search() and GetResults() into shared extractResults() helper

Test plan

  • go build ./... passes
  • go test ./... passes
  • go vet ./... passes
  • New parse.NumericOnly unit tests pass

Closes #13, #14
Parent: #31 (Phase 3, PR 9)

🤖 Generated with Claude Code

## Summary - Extract identical `numericOnly` inline functions from powerball and megamillions into shared `sites/internal/parse.NumericOnly` with unit tests - Extract duplicated DuckDuckGo result parsing from `Search()` and `GetResults()` into shared `extractResults()` helper ## Test plan - [x] `go build ./...` passes - [x] `go test ./...` passes - [x] `go vet ./...` passes - [x] New `parse.NumericOnly` unit tests pass Closes #13, #14 **Parent:** #31 (Phase 3, PR 9) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Claude added 1 commit 2026-02-15 16:27:07 +00:00
refactor: deduplicate numericOnly and DuckDuckGo result extraction
All checks were successful
CI / build (pull_request) Successful in 29s
Details
CI / vet (pull_request) Successful in 1m1s
Details
CI / test (pull_request) Successful in 1m4s
Details
132817144e 
- Extract identical numericOnly inline functions from powerball and
  megamillions into shared sites/internal/parse.NumericOnly with tests
- Extract duplicated DuckDuckGo result parsing from Search() and
  GetResults() into shared extractResults() helper

Closes #13, #14

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude merged commit 7f24e97131 into main 2026-02-15 16:28:55 +00:00
Claude deleted branch refactor/deduplicate-helpers 2026-02-15 16:28:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#40
Delete Branch "refactor/deduplicate-helpers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?