refactor: Deduplicate numericOnly helper in powerball and megamillions #13

New Issue

Claude · 2026-02-14T16:06:33Z

Claude commented

2026-02-14 16:06:33 +00:00

Parent: #3

Description

Both sites/powerball/powerball.go:149-168 and sites/megamillions/megamillions.go:171-190 define identical numericOnly inline functions for parsing jackpot amounts:

numericOnly := func(in string) float64 {
    var out string
    for _, r := range in {
        if r >= '0' && r <= '9' {
            out += string(r)
        }
        if r == '.' {
            out += string(r)
        }
    }
    val, err := strconv.ParseFloat(out, 64)
    if err != nil {
        return 0
    }
    return val
}

Both also have identical jackpot multiplier logic for "Billion" and "Million" suffixes.

Fix

Extract a shared utility function, either in a sites/lottery package or as an exported function in the extractor package.

**Parent:** #3 ## Description Both `sites/powerball/powerball.go:149-168` and `sites/megamillions/megamillions.go:171-190` define identical `numericOnly` inline functions for parsing jackpot amounts: ```go numericOnly := func(in string) float64 { var out string for _, r := range in { if r >= '0' && r <= '9' { out += string(r) } if r == '.' { out += string(r) } } val, err := strconv.ParseFloat(out, 64) if err != nil { return 0 } return val } ``` Both also have identical jackpot multiplier logic for "Billion" and "Million" suffixes. ## Fix Extract a shared utility function, either in a `sites/lottery` package or as an exported function in the extractor package.

Claude added the priority/low type/refactor labels 2026-02-14 16:07:32 +00:00

Claude referenced this issue

2026-02-14 16:09:05 +00:00

Epic: Code Quality & Duplication #3

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude commented

2026-02-15 16:25:33 +00:00

Starting work on this as part of PR 9 (also includes #14). Will extract numericOnly to sites/internal/parse/parse.go.

Starting work on this as part of PR 9 (also includes #14). Will extract `numericOnly` to `sites/internal/parse/parse.go`.

Claude referenced this issue

2026-02-15 16:25:34 +00:00

refactor: Deduplicate DuckDuckGo result extraction logic #14

Claude referenced this issue from a commit

2026-02-15 16:27:00 +00:00

refactor: deduplicate numericOnly and DuckDuckGo result extraction

Claude referenced a pull request that will close this issue

2026-02-15 16:27:07 +00:00

Deduplicate helpers (#13, #14) #40

Claude closed this issue

2026-02-15 16:28:55 +00:00

Claude referenced this issue from a commit

2026-02-15 16:28:57 +00:00

Merge pull request 'Deduplicate helpers (#13, #14)' (#40) from refactor/deduplicate-helpers into main

Claude commented

2026-02-15 16:29:00 +00:00

Work finished — extracted identical numericOnly functions from powerball and megamillions into shared sites/internal/parse.NumericOnly with unit tests. Merged in PR #40.

Work finished — extracted identical `numericOnly` functions from powerball and megamillions into shared `sites/internal/parse.NumericOnly` with unit tests. Merged in PR #40.

Claude referenced this issue

2026-02-15 16:29:14 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude referenced this issue

2026-02-15 20:57:40 +00:00

Epic: Code Quality & Duplication #3

Claude referenced this issue

2026-02-15 20:58:09 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Sign in to join this conversation.