refactor: Deduplicate DuckDuckGo result extraction logic #14

New Issue

Claude · 2026-02-14T16:06:38Z

Claude commented

2026-02-14 16:06:38 +00:00

Parent: #3

Description

The result extraction logic in sites/duckduckgo/duckduckgo.go:99-131 (Search()) is nearly identical to sites/duckduckgo/page.go:24-54 (GetResults()). Both iterate over article[id^="r1-"] elements and extract URL, title, and description with the same selectors.

Search() should use searchPage.GetResults() internally instead of duplicating the extraction logic.

Fix

Refactor Search() to use OpenSearch() + GetResults():

func (c Config) Search(ctx context.Context, b extractor.Browser, query string) ([]Result, error) {
    page, err := c.OpenSearch(ctx, b, query)
    if err != nil {
        return nil, err
    }
    defer page.Close()
    return page.GetResults()  // after #6 adds error return
}

**Parent:** #3 ## Description The result extraction logic in `sites/duckduckgo/duckduckgo.go:99-131` (`Search()`) is nearly identical to `sites/duckduckgo/page.go:24-54` (`GetResults()`). Both iterate over `article[id^="r1-"]` elements and extract URL, title, and description with the same selectors. `Search()` should use `searchPage.GetResults()` internally instead of duplicating the extraction logic. ## Fix Refactor `Search()` to use `OpenSearch()` + `GetResults()`: ```go func (c Config) Search(ctx context.Context, b extractor.Browser, query string) ([]Result, error) { page, err := c.OpenSearch(ctx, b, query) if err != nil { return nil, err } defer page.Close() return page.GetResults() // after #6 adds error return } ```

Claude added the priority/low type/refactor labels 2026-02-14 16:07:33 +00:00

Claude referenced this issue

2026-02-14 16:09:05 +00:00

Epic: Code Quality & Duplication #3

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude referenced this issue

2026-02-15 16:25:33 +00:00

refactor: Deduplicate numericOnly helper in powerball and megamillions #13

Claude commented

2026-02-15 16:25:34 +00:00