fix: check Cookies() error and use context-aware sleep
All checks were successful
CI / build (pull_request) Successful in 46s
CI / vet (pull_request) Successful in 47s
CI / test (pull_request) Successful in 1m22s

- playwright.go: check error from page.Context().Cookies() before
  iterating over results, preventing silent failures
- archive.go: replace time.Sleep(5s) with context-aware select using
  time.After, allowing the operation to be cancelled promptly

Closes #7, #18

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-15 16:19:49 +00:00
parent 8b136b9dda
commit 769b870a17
2 changed files with 7 additions and 6 deletions

View File

@@ -138,6 +138,9 @@ func NewBrowser(ctx context.Context, opts ...BrowserOptions) (Browser, error) {
func (b playWrightBrowser) updateCookies(_ context.Context, page playwright.Page) error {
if b.cookieJar != nil {
cookies, err := page.Context().Cookies(page.URL())
if err != nil {
return fmt.Errorf("error getting cookies from browser: %w", err)
}
for _, cookie := range cookies {
// TODO: add support for deleting cookies from the jar which are deleted in the browser

View File

@@ -128,15 +128,13 @@ func (c Config) Archive(ctx context.Context, b extractor.Browser, target string)
return nil, fmt.Errorf("failed to click submit: %w", err)
}
// wait for the page to load
time.Sleep(5 * time.Second)
// wait for the page to load, but respect context cancellation
select {
case <-ctx.Done():
slog.Debug("context already done before entering the loop", "err", ctx.Err())
slog.Debug("context done during initial wait", "err", ctx.Err())
_ = doc.Close()
return nil, ctx.Err()
default:
// Proceed with the loop
case <-time.After(5 * time.Second):
}
// now we are waiting for archive.ph to archive the page and redirect us to the archived page
// the way we can tell this is happening is by checking the url of the page periodically