Make request deadline extensions reach the socket behind the logging middleware #126

Merged

steve merged 2 commits from fix/sse-deadlines-behind-middleware into main 2026-08-23 03:10:37 +00:00

Conversation 3 Commits 2 Files Changed 6

+142 -15

2 Commits

Author	SHA1	Message	Date
steveandClaude Fable 5	68cb686d60	Address #126 review: one home for the middleware rationale ... The why-a-controller-can't-reach-the-socket story was told in full in deadlines.go, agent.go, the test, and CLAUDE.md. It lives in deadlines.go now; the others say what they need to and point there. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-22 23:09:36 -04:00
steveandClaude Fable 5	2a903f6428	Make request deadline extensions reach the socket behind the logging middleware ... Long agent turns were cut at exactly 30s on the live instance with "The connection dropped partway through." — the #78 failure, which its tests said was fixed. The tests host openEventStream on a bare gin.New(); in production, slog-gin replaces c.Writer with a wrapper that embeds the gin.ResponseWriter interface, which has no Unwrap, so the ResponseController built from the handler's writer can't reach the connection and every SetWriteDeadline returns ErrNotSupported. The stream fell back to the server's absolute WriteTimeout; the first write past it failed, cancelled the request context, and closed the socket under the client mid-frame. The scan upload's read/write extensions failed the same way, with the errors discarded. captureController now runs first on the engine and stashes a controller built before anything wraps the writer; openEventStream and scanSeedPacket take it from responseController(c). The regression tests run the stream through New() — the real stack, in the real order — and check from the client side; the scan path logs once instead of swallowing the error. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-22 22:56:21 -04:00