fix(agent): recover the front-loaded answer over a summary closer #25

Merged

steve merged 3 commits from fix/finalize-summary-closer into main 2026-08-06 00:39:39 +00:00

Conversation 4 Commits 3 Files Changed 2

+324 -26

3 Commits

Author	SHA1	Message	Date
steveandClaude Fable 5	1bbbdaa1e5	refactor(agent): gadfly round 2 — shared leadingMarkers, explicit mode, comment altitude ... All tidiness, no behavior change: the leading-marker class is one shared constant for citationLabelRe and summaryCloserRe (hand-copying it is how '+' went missing the first time); the deliberate 'all' duplication across summaryCopulas/summaryArticle is now stated at both sites; the weak-final switch case assigns modeBackRef explicitly; test comments state the constraint they guard instead of which reviewer asked for them. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-05 20:29:19 -04:00
steveandClaude Fable 5	21b4775d16	fix(agent): gadfly round 1 — user-boundary scan, back-ref precedence, regex legibility ... Two behavioral fixes from the review: - modeSummary's backward scan now stops at the most recent user message. With the dwarf ratio rejecting the current turn's 1x-3x answer, the old unbounded scan could walk into WithHistory content and resurrect a stale answer to a DIFFERENT question — strictly worse than keeping the closer (opus, correctness). Other modes keep their historical unbounded scan. - A terminal matching BOTH the ack shape and a back-reference is now classified back-ref: it carries no answer content, so the looser bar is the right one (opus, error-handling). Plus the nits: summaryCloserRe assembled from named fragments, the leading marker class gains '+' (parity with citationLabelRe), verb-first form takes 'all the', dwarf ratio hoisted into one named local, and the 151-vs-153 char/byte comment inaccuracy corrected. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-05 20:17:56 -04:00
steveandClaude Fable 5	127966bb3a	fix(agent): recover the front-loaded answer over a summary closer ... A third degenerate terminal shape from the glm-5.2 cite pattern: the model front-loads its full answer into the cite-call turn, then closes with a bookkeeping ack plus a one-line compression ("Citations are logged. Short version: ..."). mort run b3cb9ee9 delivered 151 chars of a 2,089-char answer this way — the closer was neither a back-reference (over the 120 cap, no back-ref phrase) nor a citations addendum (no label-colon, no links), so finalOutput let it stand. isSummaryCloser keys on the ack sentence alone (the verb must end the sentence, so prose about citations never matches; a compression marker without the ack is deliberately out of scope), and the new modeSummary recovery bar makes the 3x dwarf ratio mandatory at every length: unlike a back-reference this closer carries real answer content, so it is only displaced by the clearly-fuller original it compressed. The citations/back-ref bool becomes a three-way recoveryMode; existing behavior for both old modes is unchanged. Co-Authored-By: Claude Fable 5 <[email protected]>	2026-08-05 08:47:40 -04:00