Compare commits
6 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 70b7aebd86 | |||
| 52bb910f4d | |||
| d71aca4c3a | |||
| aa25b2c334 | |||
| 2b35f1741c | |||
| de2b2f0f28 |
@@ -79,12 +79,13 @@ alias := bare token (no slash), expands INLINE, recursively, cycle-checked
|
||||
`LLM_<NAME>=scheme://[token@]host[/path]` — e.g.
|
||||
`LLM_M5=foreman://token@foreman-m5.example` defines provider `m5`; then
|
||||
`m5/qwen3:30b` works in Parse, chains, and aliases. Scheme ∈ {foreman,
|
||||
ollama, ollama-cloud, openai, anthropic, google, gemini, llama-swap} ∪
|
||||
RegisterScheme. Token = credential; base URL = `https://host` always —
|
||||
**except `llama-swap`, which builds `http://host` (local-first; ADR-0015).**
|
||||
`New()` scans the process env eagerly; unknown names also resolve lazily at
|
||||
Parse time (`my-prov` → `LLM_MY_PROV`). Malformed entries fail on use, not at
|
||||
startup.
|
||||
ollama, ollama-cloud, openai, anthropic, google, gemini, llama-swap,
|
||||
llama-swaps} ∪ RegisterScheme. Token = credential; base URL = `https://host`
|
||||
always — **except `llama-swap`, which builds `http://host` (local-first);
|
||||
`llama-swaps` is its TLS twin (`https://host`), mirroring redis/rediss
|
||||
(ADR-0015).** `New()` scans the process env eagerly; unknown names also resolve
|
||||
lazily at Parse time (`my-prov` → `LLM_MY_PROV`). Malformed entries fail on use,
|
||||
not at startup.
|
||||
|
||||
## Health & failover (ADR-0006, ADR-0008)
|
||||
|
||||
|
||||
@@ -159,15 +159,17 @@ m, _ := reg.Parse("m5/qwen3:30b,m1/qwen3:30b,thinking")
|
||||
```
|
||||
|
||||
DSN format: `scheme://[token@]host[/path]`, scheme ∈ `foreman`, `ollama`,
|
||||
`ollama-cloud`, `openai`, `anthropic`, `google`/`gemini`, `llama-swap`, or any
|
||||
scheme you add with `RegisterScheme`. The token is the credential (bearer token
|
||||
/ API key); the base URL is always `https://host[/path]` — except `llama-swap`,
|
||||
which builds `http://host[:port]` since it's local-first. `New()` loads `LLM_*`
|
||||
vars eagerly; unknown provider names also resolve lazily at Parse time
|
||||
(`my-prov/x` → `LLM_MY_PROV`).
|
||||
`ollama-cloud`, `openai`, `anthropic`, `google`/`gemini`, `llama-swap`,
|
||||
`llama-swaps`, or any scheme you add with `RegisterScheme`. The token is the
|
||||
credential (bearer token / API key); the base URL is always `https://host[/path]`
|
||||
— except `llama-swap`, which builds `http://host[:port]` since it's local-first
|
||||
(`llama-swaps` is the TLS twin → `https://host`, mirroring redis/rediss). `New()`
|
||||
loads `LLM_*` vars eagerly; unknown provider names also resolve lazily at Parse
|
||||
time (`my-prov/x` → `LLM_MY_PROV`).
|
||||
|
||||
```
|
||||
LLM_LS=llama-swap://token@box.local:8080 # then "ls/qwen3:14b" parses
|
||||
LLM_LS=llama-swap://token@box.local:8080 # http → "ls/qwen3:14b" parses
|
||||
LLM_LS=llama-swaps://token@swap.example.com # https → TLS-fronted instance
|
||||
```
|
||||
|
||||
[llama-swap](https://github.com/mostlygeek/llama-swap) is a model-swapping proxy
|
||||
|
||||
+21
-11
@@ -20,6 +20,12 @@ const (
|
||||
ProviderOllamaCloud = "ollama-cloud"
|
||||
ProviderForeman = "foreman"
|
||||
ProviderLlamaSwap = "llama-swap"
|
||||
// ProviderLlamaSwapTLS is the DSN scheme for a TLS-fronted llama-swap
|
||||
// (https base URL). It is a scheme only, not a default built-in provider
|
||||
// name. Why a separate scheme rather than auto-detecting: a DSN carries no
|
||||
// reliable signal for http vs https, so the choice is explicit
|
||||
// (llama-swap = http local-first, llama-swaps = https), mirroring rediss.
|
||||
ProviderLlamaSwapTLS = "llama-swaps"
|
||||
)
|
||||
|
||||
// registerBuiltins installs the built-in providers and env-DSN scheme
|
||||
@@ -70,24 +76,28 @@ func registerBuiltins(r *Registry, httpClient *http.Client) {
|
||||
|
||||
// llama-swap: OpenAI-compatible chat + image generation + management
|
||||
// endpoints over a model-swapping proxy. Chat reuses the openai client
|
||||
// (provider/llamaswap delegates); the DSN builds an http:// base URL
|
||||
// because llama-swap is local-first (TLS-fronted instances can use the
|
||||
// openai:// scheme for chat). The no-DSN built-in errors on use with a
|
||||
// clear message, mirroring foreman.
|
||||
// (provider/llamaswap delegates). Two schemes: "llama-swap" builds an
|
||||
// http:// base URL (local-first default), "llama-swaps" builds https://
|
||||
// for a TLS-fronted instance (mirrors redis/rediss). The no-DSN built-in
|
||||
// errors on use with a clear message, mirroring foreman.
|
||||
llamaSwapOpts := func(extra ...llamaswap.Option) []llamaswap.Option {
|
||||
if httpClient != nil {
|
||||
extra = append(extra, llamaswap.WithHTTPClient(httpClient))
|
||||
}
|
||||
return extra
|
||||
}
|
||||
r.providers[ProviderLlamaSwap] = llamaswap.New(llamaSwapOpts(llamaswap.WithName(ProviderLlamaSwap))...)
|
||||
r.schemes[ProviderLlamaSwap] = func(name string, dsn DSN) (llm.Provider, error) {
|
||||
return llamaswap.New(llamaSwapOpts(
|
||||
llamaswap.WithName(name),
|
||||
llamaswap.WithBaseURL("http://"+dsn.Host),
|
||||
llamaswap.WithToken(dsn.Token),
|
||||
)...), nil
|
||||
llamaSwapScheme := func(urlScheme string) SchemeFactory {
|
||||
return func(name string, dsn DSN) (llm.Provider, error) {
|
||||
return llamaswap.New(llamaSwapOpts(
|
||||
llamaswap.WithName(name),
|
||||
llamaswap.WithBaseURL(urlScheme+"://"+dsn.Host),
|
||||
llamaswap.WithToken(dsn.Token),
|
||||
)...), nil
|
||||
}
|
||||
}
|
||||
r.providers[ProviderLlamaSwap] = llamaswap.New(llamaSwapOpts(llamaswap.WithName(ProviderLlamaSwap))...)
|
||||
r.schemes[ProviderLlamaSwap] = llamaSwapScheme("http")
|
||||
r.schemes[ProviderLlamaSwapTLS] = llamaSwapScheme("https")
|
||||
|
||||
// Anthropic and Anthropic-compatible endpoints.
|
||||
anthropicOpts := func(extra ...anthropic.Option) []anthropic.Option {
|
||||
|
||||
@@ -51,6 +51,28 @@ func TestLlamaSwapScheme(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestLlamaSwapsScheme: the "llama-swaps" scheme builds an https base URL for a
|
||||
// TLS-fronted instance (vs "llama-swap" which is http local-first).
|
||||
func TestLlamaSwapsScheme(t *testing.T) {
|
||||
r := newTestRegistry(t)
|
||||
if err := r.LoadEnv(map[string]string{
|
||||
"LLM_LST": "llama-swaps://tok@swap.example.com",
|
||||
}); err != nil {
|
||||
t.Fatalf("LoadEnv: %v", err)
|
||||
}
|
||||
p, ok := r.Provider("lst")
|
||||
if !ok {
|
||||
t.Fatal("provider \"lst\" not registered")
|
||||
}
|
||||
lp, ok := p.(*llamaswap.Provider)
|
||||
if !ok {
|
||||
t.Fatalf("provider is %T, want *llamaswap.Provider", p)
|
||||
}
|
||||
if want := "https://swap.example.com"; lp.BaseURL() != want {
|
||||
t.Errorf("baseURL = %q, want %q", lp.BaseURL(), want)
|
||||
}
|
||||
}
|
||||
|
||||
// TestLlamaSwapBuiltinNoURL: the no-DSN built-in resolves but errors clearly on
|
||||
// use (mirrors foreman), rather than silently hitting a wrong host.
|
||||
func TestLlamaSwapBuiltinNoURL(t *testing.T) {
|
||||
|
||||
@@ -38,11 +38,13 @@ features leak into the canonical API).
|
||||
`Unload` (POST `/api/models/unload[/:model]`). A small `doJSON` helper shares
|
||||
bearer auth + error mapping; non-2xx → `*llm.APIError` (so `llm.Classify`
|
||||
applies), transport errors wrapped raw.
|
||||
- DSN: the `llama-swap` scheme builds an **http://** base URL from the host
|
||||
(llama-swap is local-first), deliberately *not* the DSN's https-always
|
||||
`BaseURL()`. A TLS-fronted instance can use the `openai://` scheme for chat.
|
||||
A no-DSN built-in `llama-swap` provider registers but errors on use (mirrors
|
||||
foreman).
|
||||
- DSN: two schemes share one factory. `llama-swap` builds an **http://** base
|
||||
URL from the host (llama-swap is local-first), deliberately *not* the DSN's
|
||||
https-always `BaseURL()`; `llama-swaps` builds **https://** for a TLS-fronted
|
||||
instance (mirrors redis/rediss). Why a second scheme rather than auto-detect:
|
||||
a DSN carries no reliable http-vs-https signal, so the choice stays explicit.
|
||||
Only `llama-swap` registers a no-DSN built-in provider (errors on use, mirrors
|
||||
foreman); `llama-swaps` is a scheme only.
|
||||
- Image generation is implemented here too, against the new `imagegen`
|
||||
interface (see ADR-0016).
|
||||
|
||||
|
||||
+41
-15
@@ -5,10 +5,16 @@
|
||||
// already satisfies the target's llm.Capabilities. Images that do not fit
|
||||
// are decoded, downscaled (never upscaled), and re-encoded into an allowed
|
||||
// format and byte budget. Anything that cannot honestly be made to fit —
|
||||
// undecodable formats, impossible byte budgets, too many images, images for
|
||||
// a text-only target — fails with an error wrapping llm.ErrUnsupported so a
|
||||
// failover chain can advance to a more capable target without a health
|
||||
// penalty.
|
||||
// undecodable formats, impossible byte budgets, images for a text-only
|
||||
// target — fails with an error wrapping llm.ErrUnsupported so a failover
|
||||
// chain can advance to a more capable target without a health penalty.
|
||||
//
|
||||
// Over-count is the exception: a request carrying more images than
|
||||
// MaxImagesPerReq does NOT fail — the oldest images are replaced with a short
|
||||
// text placeholder and the most-recent MaxImagesPerReq are kept, because a hard
|
||||
// refuse exhausts a chain whose targets share the same cap (e.g. an agent loop
|
||||
// accumulating a preview image per iteration). MaxImagesPerReq remains the
|
||||
// per-model knob (0 = no image support).
|
||||
//
|
||||
// Why a separate package: every provider would otherwise duplicate the same
|
||||
// decode/scale/encode pipeline. Providers keep only a cheap capability
|
||||
@@ -52,15 +58,21 @@ func Normalize(req llm.Request, caps llm.Capabilities) (llm.Request, error) {
|
||||
if !caps.SupportsImages() {
|
||||
return llm.Request{}, fmt.Errorf("media: %w: target does not accept image input (request carries %d image(s))", llm.ErrUnsupported, total)
|
||||
}
|
||||
// Why error instead of dropping the overflow: silently removing an image
|
||||
// changes the question the caller asked; the honest move is to refuse and
|
||||
// let a chain try a roomier target.
|
||||
// Over-cap images are elided in the same copy-on-write pass below: the
|
||||
// OLDEST excess are replaced with a placeholder and the most-recent
|
||||
// MaxImagesPerReq kept (see the package doc for why we elide rather than
|
||||
// refuse). toElide is how many of the first images, front-to-back, to drop.
|
||||
toElide := 0
|
||||
if total > caps.MaxImagesPerReq {
|
||||
return llm.Request{}, fmt.Errorf("media: %w: request carries %d images, target allows at most %d per request", llm.ErrUnsupported, total, caps.MaxImagesPerReq)
|
||||
toElide = total - caps.MaxImagesPerReq
|
||||
}
|
||||
|
||||
// Single copy-on-write pass: for each image, the first toElide become a text
|
||||
// placeholder; the rest are size-normalized against caps. The Messages slice
|
||||
// and an affected message's Parts slice are copied at most once.
|
||||
out := req
|
||||
copiedMessages := false
|
||||
seen := 0
|
||||
for mi := range req.Messages {
|
||||
copiedParts := false
|
||||
for pi, part := range req.Messages[mi].Parts {
|
||||
@@ -68,13 +80,22 @@ func Normalize(req llm.Request, caps llm.Capabilities) (llm.Request, error) {
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
norm, changed, err := normalizeImage(ip, caps)
|
||||
if err != nil {
|
||||
return llm.Request{}, fmt.Errorf("media: message %d, part %d: %w", mi, pi, err)
|
||||
}
|
||||
if !changed {
|
||||
continue
|
||||
seen++
|
||||
|
||||
var replacement llm.Part
|
||||
if seen <= toElide {
|
||||
replacement = llm.Text(imageOverflowPlaceholder)
|
||||
} else {
|
||||
norm, changed, err := normalizeImage(ip, caps)
|
||||
if err != nil {
|
||||
return llm.Request{}, fmt.Errorf("media: message %d, part %d: %w", mi, pi, err)
|
||||
}
|
||||
if !changed {
|
||||
continue
|
||||
}
|
||||
replacement = norm
|
||||
}
|
||||
|
||||
if !copiedMessages {
|
||||
out.Messages = make([]llm.Message, len(req.Messages))
|
||||
copy(out.Messages, req.Messages)
|
||||
@@ -86,12 +107,17 @@ func Normalize(req llm.Request, caps llm.Capabilities) (llm.Request, error) {
|
||||
out.Messages[mi].Parts = parts
|
||||
copiedParts = true
|
||||
}
|
||||
out.Messages[mi].Parts[pi] = norm
|
||||
out.Messages[mi].Parts[pi] = replacement
|
||||
}
|
||||
}
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// imageOverflowPlaceholder replaces an image elided to fit a target's
|
||||
// per-request image cap. It keeps the message turn intact and tells the model
|
||||
// an earlier image was omitted rather than silently changing the conversation.
|
||||
const imageOverflowPlaceholder = "[earlier image omitted to fit this model's per-request image limit]"
|
||||
|
||||
// Info reports an image part's sniffed format ("jpeg", "png", "gif", or
|
||||
// "webp") and pixel dimensions. It is a cheap metadata read — the pixels are
|
||||
// never decoded. webp is recognized by signature but not decodable with the
|
||||
|
||||
+39
-9
@@ -149,18 +149,48 @@ func TestNormalizeImagesUnsupported(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestNormalizeTooManyImages(t *testing.T) {
|
||||
img := llm.Image("image/png", encPNG(t, gradient(4, 4)))
|
||||
func TestNormalizeOverCount(t *testing.T) {
|
||||
// 3 distinguishable images across 2 messages; cap = 2. Over-count no longer
|
||||
// errors — the OLDEST image is replaced with a placeholder and the most-recent
|
||||
// two (the relevant ones in an iterative run) are kept, in order.
|
||||
a := llm.Image("image/png", encPNG(t, gradient(2, 2))).(llm.ImagePart)
|
||||
b := llm.Image("image/png", encPNG(t, gradient(4, 4))).(llm.ImagePart)
|
||||
c := llm.Image("image/png", encPNG(t, gradient(8, 8))).(llm.ImagePart)
|
||||
req := llm.Request{Messages: []llm.Message{
|
||||
llm.UserParts(img, img),
|
||||
llm.UserParts(img),
|
||||
llm.UserParts(a, b),
|
||||
llm.UserParts(c),
|
||||
}}
|
||||
_, err := Normalize(req, llm.Capabilities{MaxImagesPerReq: 2})
|
||||
if !errors.Is(err, llm.ErrUnsupported) {
|
||||
t.Fatalf("err = %v, want ErrUnsupported", err)
|
||||
caps := llm.Capabilities{MaxImagesPerReq: 2, MaxImageDimension: 64, MaxImageBytes: 1 << 20, AllowedImageMIME: []string{"image/png"}}
|
||||
out, err := Normalize(req, caps)
|
||||
if err != nil {
|
||||
t.Fatalf("over-count should not error: %v", err)
|
||||
}
|
||||
if !strings.Contains(err.Error(), "3 images") || !strings.Contains(err.Error(), "at most 2") {
|
||||
t.Errorf("err message %q lacks the counts", err)
|
||||
var imgs []llm.ImagePart
|
||||
placeholders := 0
|
||||
for _, m := range out.Messages {
|
||||
for _, p := range m.Parts {
|
||||
switch v := p.(type) {
|
||||
case llm.ImagePart:
|
||||
imgs = append(imgs, v)
|
||||
case llm.TextPart:
|
||||
if v.Text == imageOverflowPlaceholder {
|
||||
placeholders++
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
// The exact survivors are the most-recent two, in order: b then c (a elided).
|
||||
if len(imgs) != 2 || !bytes.Equal(imgs[0].Data, b.Data) || !bytes.Equal(imgs[1].Data, c.Data) {
|
||||
t.Fatalf("kept %d images; want exactly [b, c] (the most-recent two)", len(imgs))
|
||||
}
|
||||
if placeholders != 1 {
|
||||
t.Errorf("placeholders = %d, want 1 for the elided oldest image", placeholders)
|
||||
}
|
||||
// Input request untouched (copy-on-write): the first part is still image a,
|
||||
// not a placeholder — a len check alone wouldn't catch in-place substitution.
|
||||
first, ok := req.Messages[0].Parts[0].(llm.ImagePart)
|
||||
if !ok || !bytes.Equal(first.Data, a.Data) {
|
||||
t.Errorf("input request was mutated; first part = %+v", req.Messages[0].Parts[0])
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1,5 +1,12 @@
|
||||
# progress
|
||||
|
||||
## 2026-06-27 — llama-swaps (TLS) DSN scheme
|
||||
|
||||
Follow-up to the llama-swap provider: added the `llama-swaps` DSN scheme (https
|
||||
base URL) alongside `llama-swap` (http, local-first), mirroring redis/rediss, so
|
||||
a TLS-fronted instance is first-class instead of being pushed to the `openai://`
|
||||
scheme. Scheme-only (no default built-in); shares one factory in builtin.go.
|
||||
|
||||
## 2026-06-27 — llama-swap provider + canonical image-gen interface
|
||||
|
||||
**Landed (ADR-0015, ADR-0016).** New `provider/llamaswap`: chat **delegates to
|
||||
|
||||
Reference in New Issue
Block a user