bug: archive cmd uses wrong flags variable — browser flags not available #8

New Issue

Claude · 2026-02-14T16:05:55Z

Claude commented

2026-02-14 16:05:55 +00:00

Parent: #1

Description

In sites/archive/cmd/archive/main.go:49-59, a merged flags variable is constructed but never used:

func main() {
    var flags []cli.Flag
    flags = append(flags, browser.Flags...)  // merged browser + archive flags
    flags = append(flags, Flags...)

    cli := &cli.Command{
        Name:  "archive",
        Usage: "Archive a website",
        Flags: Flags,  // BUG: uses only archive Flags, not the merged `flags`
        // ...
    }
}

This means browser flags (--user-agent, --timeout, --browser, --cookies-file, --visible) are not available to the archive command, even though browser.FromCommand() is called in the action handler.

Fix

Change Flags: Flags to Flags: flags on line 59.

**Parent:** #1 ## Description In `sites/archive/cmd/archive/main.go:49-59`, a merged `flags` variable is constructed but never used: ```go func main() { var flags []cli.Flag flags = append(flags, browser.Flags...) // merged browser + archive flags flags = append(flags, Flags...) cli := &cli.Command{ Name: "archive", Usage: "Archive a website", Flags: Flags, // BUG: uses only archive Flags, not the merged `flags` // ... } } ``` This means browser flags (`--user-agent`, `--timeout`, `--browser`, `--cookies-file`, `--visible`) are not available to the archive command, even though `browser.FromCommand()` is called in the action handler. ## Fix Change `Flags: Flags` to `Flags: flags` on line 59.

Claude added the bug priority/high type/task labels 2026-02-14 16:06:16 +00:00

Claude referenced this issue

2026-02-14 16:09:00 +00:00

Epic: Error Handling & Correctness #1

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude commented

2026-02-15 16:16:48 +00:00

Starting work on this as part of PR 5 (also includes #19). Will fix Flags: Flags to use the merged flags variable.

Starting work on this as part of PR 5 (also includes #19). Will fix `Flags: Flags` to use the merged `flags` variable.

Claude referenced this issue