Fix cmd flags and defer-before-error-check (#8, #19) #36

Claude · 2026-02-15T16:17:53Z

Claude commented

2026-02-15 16:17:53 +00:00

Summary

Fix archive cmd using Flags (archive-only) instead of the merged flags variable that includes browser flags — browser flags were never registered
Move defer DeferClose() after error checks in 6 locations across the codebase, preventing potential nil dereference when Close is called on a nil value

Affected files:

sites/archive/cmd/archive/main.go (flags fix)
sites/duckduckgo/cmd/duckduckgo/main.go (defer fix)
sites/duckduckgo/duckduckgo.go (defer fix)
sites/google/cmd/google/main.go (defer fix)
sites/wegmans/cmd/wegmans/main.go (defer fix)
sites/wegmans/wegmans.go (defer fix)
sites/aislegopher/aislegopher.go (defer fix)

Test plan

go build ./... passes
go test ./... passes
Verify archive cmd now accepts browser flags (e.g., --show-browser)

Closes #8, #19
Parent: #31 (Phase 2, PR 5)

🤖 Generated with Claude Code

## Summary - Fix archive cmd using `Flags` (archive-only) instead of the merged `flags` variable that includes browser flags — browser flags were never registered - Move `defer DeferClose()` after error checks in 6 locations across the codebase, preventing potential nil dereference when Close is called on a nil value **Affected files:** - `sites/archive/cmd/archive/main.go` (flags fix) - `sites/duckduckgo/cmd/duckduckgo/main.go` (defer fix) - `sites/duckduckgo/duckduckgo.go` (defer fix) - `sites/google/cmd/google/main.go` (defer fix) - `sites/wegmans/cmd/wegmans/main.go` (defer fix) - `sites/wegmans/wegmans.go` (defer fix) - `sites/aislegopher/aislegopher.go` (defer fix) ## Test plan - [x] `go build ./...` passes - [x] `go test ./...` passes - [ ] Verify archive cmd now accepts browser flags (e.g., `--show-browser`) Closes #8, #19 **Parent:** #31 (Phase 2, PR 5) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Claude added 1 commit 2026-02-15 16:17:53 +00:00

fix: use merged flags in archive cmd and move defer after error checks

CI / vet (pull_request) Successful in 29s

Details

CI / build (pull_request) Successful in 32s

Details

CI / test (pull_request) Successful in 57s

Details

e5e0db85e8

- Fix archive cmd passing only archive-specific Flags instead of the
  merged flags variable that includes browser flags (#8)
- Move defer DeferClose() after error checks in 6 locations to prevent
  calling Close on nil values (#19):
  - sites/duckduckgo/cmd/duckduckgo/main.go
  - sites/duckduckgo/duckduckgo.go
  - sites/google/cmd/google/main.go
  - sites/wegmans/cmd/wegmans/main.go
  - sites/wegmans/wegmans.go
  - sites/aislegopher/aislegopher.go

Closes #8, #19

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>