steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Consolidate user-agent strings (#17) #39

Merged
Claude merged 1 commits from fix/user-agent-consistency into main 2026-02-15 16:25:03 +00:00
Conversation 0 Commits 1 Files Changed 3 +7 -4
Claude commented 2026-02-15 16:24:58 +00:00
Collaborator
Copy Link

Summary

  • Define DefaultUserAgent constant (Firefox/147.0) in playwright.go
  • Replace all three inline UA strings with the constant
  • Previously: two at Firefox/142.0, one outdated at Firefox/133.0

Test plan

  • go build ./... passes
  • go test ./... passes
  • go vet ./... passes

Closes #17
Parent: #31 (Phase 3, PR 8)

🤖 Generated with Claude Code

## Summary - Define `DefaultUserAgent` constant (Firefox/147.0) in `playwright.go` - Replace all three inline UA strings with the constant - Previously: two at Firefox/142.0, one outdated at Firefox/133.0 ## Test plan - [x] `go build ./...` passes - [x] `go test ./...` passes - [x] `go vet ./...` passes Closes #17 **Parent:** #31 (Phase 3, PR 8) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Claude added 1 commit 2026-02-15 16:24:58 +00:00
fix: consolidate user-agent strings into DefaultUserAgent constant
All checks were successful
CI / build (pull_request) Successful in 44s
Details
CI / test (pull_request) Successful in 46s
Details
CI / vet (pull_request) Successful in 1m28s
Details
097b2e12c7 
Define DefaultUserAgent (Firefox/147.0) in playwright.go and reference
it from NewBrowser, NewInteractiveBrowser, and CLI flags. Previously
three different UA strings existed (two at 142.0, one outdated at 133.0).

Closes #17

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude merged commit 384566e016 into main 2026-02-15 16:25:03 +00:00
Claude deleted branch fix/user-agent-consistency 2026-02-15 16:25:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#39
Delete Branch "fix/user-agent-consistency"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?