steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug: Hardcoded user-agent strings are inconsistent and will become outdated #17

New Issue
Closed
opened 2026-02-14 16:06:55 +00:00 by Claude · 2 comments
Claude commented 2026-02-14 16:06:55 +00:00
Collaborator
Copy Link

Parent: #3

Description

Multiple places hardcode user-agent strings with different Firefox versions:

  • playwright.go:94 — Firefox/142.0
  • interactive.go:62 — Firefox/142.0
  • cmd/browser/pkg/browser/flags.go:20 — Firefox/133.0 (older!)

The flags.go default text is already outdated compared to the main library. These will all become stale over time and could trigger bot detection.

Fix

Options:

  1. Define a single const DefaultUserAgent in the extractor package and reference it everywhere
  2. Use the sites/useragents package to dynamically fetch the current most common user-agent on startup (more robust but adds a network dependency)
  3. At minimum, update flags.go to match the current version and add a comment noting it needs periodic updates
**Parent:** #3 ## Description Multiple places hardcode user-agent strings with different Firefox versions: - `playwright.go:94` — `Firefox/142.0` - `interactive.go:62` — `Firefox/142.0` - `cmd/browser/pkg/browser/flags.go:20` — `Firefox/133.0` (older!) The flags.go default text is already outdated compared to the main library. These will all become stale over time and could trigger bot detection. ## Fix Options: 1. Define a single `const DefaultUserAgent` in the extractor package and reference it everywhere 2. Use the `sites/useragents` package to dynamically fetch the current most common user-agent on startup (more robust but adds a network dependency) 3. At minimum, update flags.go to match the current version and add a comment noting it needs periodic updates
Claude added the bugpriority/mediumtype/task labels 2026-02-14 16:07:35 +00:00
Claude commented 2026-02-15 16:23:18 +00:00
Author
Collaborator
Copy Link

Starting work on this. Will define const DefaultUserAgent in a central location and reference it from all three locations.

Starting work on this. Will define `const DefaultUserAgent` in a central location and reference it from all three locations.
Claude commented 2026-02-15 16:25:04 +00:00
Author
Collaborator
Copy Link

Work finished. PR: #39 (merged)

Defined DefaultUserAgent constant (Firefox/147.0) and replaced all three inline UA strings.

Work finished. PR: #39 (merged) Defined `DefaultUserAgent` constant (Firefox/147.0) and replaced all three inline UA strings.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label bug priority/medium type/task
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?