steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix ShowBrowser merge + consistent browser defaults (#15, #16) #38

Merged
Claude merged 1 commits from fix/merge-options-and-browser-defaults into main 2026-02-15 16:23:08 +00:00
Conversation 0 Commits 1 Files Changed 5 +14 -6
Claude commented 2026-02-15 16:23:03 +00:00
Collaborator
Copy Link

Summary

  • Change ShowBrowser from bool to *bool in BrowserOptions so nil means "don't override" in mergeOptions(), fixing the bug where it always overwrote the base value
  • Add extractor.Bool() helper for convenient *bool construction
  • Align NewInteractiveBrowser default browser from Chromium to Firefox, matching NewBrowser
  • Update README example and CLI flags for the *bool change

Test plan

  • go build ./... passes
  • go test ./... passes
  • go vet ./... passes
  • Verify mergeOptions no longer resets ShowBrowser to false when not explicitly set

Closes #15, #16
Parent: #31 (Phase 3, PR 7)

🤖 Generated with Claude Code

## Summary - Change `ShowBrowser` from `bool` to `*bool` in `BrowserOptions` so `nil` means "don't override" in `mergeOptions()`, fixing the bug where it always overwrote the base value - Add `extractor.Bool()` helper for convenient `*bool` construction - Align `NewInteractiveBrowser` default browser from Chromium to Firefox, matching `NewBrowser` - Update README example and CLI flags for the `*bool` change ## Test plan - [x] `go build ./...` passes - [x] `go test ./...` passes - [x] `go vet ./...` passes - [ ] Verify `mergeOptions` no longer resets `ShowBrowser` to false when not explicitly set Closes #15, #16 **Parent:** #31 (Phase 3, PR 7) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Claude added 1 commit 2026-02-15 16:23:03 +00:00
fix: ShowBrowser merge behavior and consistent browser defaults
All checks were successful
CI / vet (pull_request) Successful in 1m49s
Details
CI / build (pull_request) Successful in 1m51s
Details
CI / test (pull_request) Successful in 1m52s
Details
328455de32 
- Change ShowBrowser from bool to *bool so nil means "don't override"
  in mergeOptions(), fixing the bug where it always overwrote the base
- Add Bool() helper for convenient *bool construction
- Align NewInteractiveBrowser default from Chromium to Firefox to match
  NewBrowser
- Update README example and CLI flags for the *bool change

Closes #15, #16

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude merged commit 0df639abea into main 2026-02-15 16:23:08 +00:00
Claude deleted branch fix/merge-options-and-browser-defaults 2026-02-15 16:23:08 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#38
Delete Branch "fix/merge-options-and-browser-defaults"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?