steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Inconsistent default browser types (Chromium vs Firefox) #15

New Issue
Closed
opened 2026-02-14 16:06:43 +00:00 by Claude · 2 comments
Claude commented 2026-02-14 16:06:43 +00:00
Collaborator
Copy Link

Parent: #3

Description

NewBrowser() in playwright.go:91-97 defaults to Firefox:

opt := mergeOptions(BrowserOptions{
    Browser: BrowserFirefox,
    // ...
}, opts)

But NewInteractiveBrowser() in interactive.go:59-69 defaults to Chromium:

opt := mergeOptions(BrowserOptions{
    Browser: BrowserChromium,
    // ...
}, opts)

This inconsistency is confusing and could cause different behavior between scraping and interactive modes.

Discussion

The Chromium choice for interactive makes sense (better DevTools compatibility), but it should be documented. Consider adding a comment explaining the rationale, or unify to a single default.

**Parent:** #3 ## Description `NewBrowser()` in `playwright.go:91-97` defaults to **Firefox**: ```go opt := mergeOptions(BrowserOptions{ Browser: BrowserFirefox, // ... }, opts) ``` But `NewInteractiveBrowser()` in `interactive.go:59-69` defaults to **Chromium**: ```go opt := mergeOptions(BrowserOptions{ Browser: BrowserChromium, // ... }, opts) ``` This inconsistency is confusing and could cause different behavior between scraping and interactive modes. ## Discussion The Chromium choice for interactive makes sense (better DevTools compatibility), but it should be documented. Consider adding a comment explaining the rationale, or unify to a single default.
Claude added the priority/lowtype/refactor labels 2026-02-14 16:07:33 +00:00
Claude commented 2026-02-15 16:20:44 +00:00
Author
Collaborator
Copy Link

Starting work on this as part of PR 7 (also includes #16). Will align NewInteractiveBrowser default from Chromium to Firefox to match NewBrowser.

Starting work on this as part of PR 7 (also includes #16). Will align `NewInteractiveBrowser` default from Chromium to Firefox to match `NewBrowser`.
Claude commented 2026-02-15 16:23:09 +00:00
Author
Collaborator
Copy Link

Work finished. PR: #38 (merged)

Aligned NewInteractiveBrowser default from Chromium to Firefox.

Work finished. PR: #38 (merged) Aligned `NewInteractiveBrowser` default from Chromium to Firefox.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label priority/low type/refactor
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#15
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?