steve/gadfly

Fork 0

Files

T

steveandClaude Opus 4.8 5ab4074e9c

Gadfly review (reusable) / review (pull_request) Successful in 5s

Details

Adversarial Review (Gadfly) / review (pull_request) Successful in 5s

Details

Build & push image / build-and-push (pull_request) Successful in 2m43s

Details

feat(engine): add opencode CLI review engine

Add a third review harness alongside the in-process majordomo loop and the
claude-code CLI shell-out: the OpenCode CLI (opencode.ai) driving an ollama-cloud
model, selected by an "opencode/<model>" spec. The goal is to benchmark gadfly's
boutique executus harness against a freely-available agentic harness on the SAME
model (e.g. "ollama-cloud/glm-5.2" vs "opencode/glm-5.2").

OpenCode has no --append-system-prompt flag, so the lens system prompt and the
read-only discipline are delivered through a generated config injected via
OPENCODE_CONFIG_CONTENT: a "gadfly" agent whose prompt is the system prompt with
edit/bash denied at both the global and agent level, plus a "gadfly" ollama-cloud
provider. That env var is the highest-precedence config source in the container,
so a reviewed repo's own opencode.json can't re-enable edits on the reviewer.

Spec forms: "opencode/<model>" (wrapped in the generated provider), the
"open-code/" alias, "opencode/<provider>/<model>" pass-through to OpenCode's own
registry, and bare "opencode". Model ids are taken verbatim so colon-bearing
ollama ids (qwen3-coder:480b-cloud) survive. Auth reuses OLLAMA_CLOUD_API_KEY
(mapped to OLLAMA_API_KEY, referenced as {env:OLLAMA_API_KEY} in config, never a
literal secret). Knobs mirror GADFLY_CLAUDE_*: GADFLY_OPENCODE_BIN/MODEL/BASE_URL/
EXTRA_ARGS. openCodeEnv() forwards OLLAMA_API_KEY (the inverse of claudeEnv) but
still withholds the Gitea/findings/Anthropic secrets.

main.go engine selection is now a switch (claude-code / opencode / majordomo), and
the auto-select path uses a type-check instead of a boolean so a shell-out engine
can never hit the *majordomoEngine assertion. auto-select and delegate_investigation
stay majordomo-only and are skipped for opencode (the CLI does its own legwork).

Dockerfile bundles opencode-ai (npm auto-selects its musl build on alpine) with a
best-effort version check + provider pre-warm that never fails the shared image
build. README/examples/CLAUDE.md/scripts updated per the maintenance rules.

Tests: new opencode_test.go mirrors engine_test.go (spec/model/args/config/env-
filter + stub-CLI runtime tests). Verified end-to-end with a fake opencode CLI:
correct argv, injected config, and consolidated markdown output.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

2026-07-18 01:00:54 -04:00

2.5 KiB

Raw Permalink Blame History

Example consumer workflows

Each file here is a complete, copy-paste stub workflow. Pick the one that matches your setup, copy it to .gitea/workflows/adversarial-review.yml in the repo you want reviewed, and set the secrets/vars it references. Gadfly is advisory only — it never blocks a merge.

File	Backend	Needs
`reusable.yml`	slimmest stub — calls Gadfly's reusable workflow and inherits its default swarm (3 cloud + Claude Code, 5-lens suite), forwarding only the secrets it needs (least privilege, not `secrets: inherit`); the stub keeps a cloud-only `models:` override so it runs with just the Ollama key (drop it + add the Claude token to get the full default)	secret `OLLAMA_CLOUD_API_KEY`
`adversarial-review.yml`	Ollama Cloud (default) + inline notes for every provider; full self-contained stub	secret `OLLAMA_CLOUD_API_KEY`
`local-ollama.yml`	a local/LAN Ollama daemon	nothing (or `GADFLY_BASE_URL` for a remote host)
`openai-compatible.yml`	any OpenAI-compatible endpoint (local Ollama `/v1`, gateway, vLLM, OpenRouter…)	`GADFLY_BASE_URL` (+ a key for most gateways)
`endpoint-aliases.yml`	several named backends at once (one comment each)	repo vars `GADFLY_ENDPOINT_<NAME>`
`claude-code.yml`	the bundled Claude Code CLI engine (`claude-code/<model>`)	secret `CLAUDE_CODE_OAUTH_TOKEN` (or `ANTHROPIC_API_KEY`)
`opencode.yml`	the bundled OpenCode CLI engine (`opencode/<model>`) driving an ollama-cloud model — benchmark it against the majordomo loop on the same model	secret `OLLAMA_CLOUD_API_KEY`
`.gadfly.yml`	per-repo specialist config (not a workflow — goes at your repo root)	—

Common to all:

Triggers: new/reopened/ready non-draft PR (auto), @gadfly review comment (allowed users), or manual workflow_dispatch with a pr_number.
GITEA_TOKEN is provided automatically; comments post as gitea-actions.
Tested backends are the Ollama ones; OpenAI/Anthropic/Google are wired via majordomo but untested. See the repo README for the full config reference and the honest tested/untested status.

Gitea note: repo vars/secrets are not auto-exposed as env — anything you reference via ${{ vars.X }} / ${{ secrets.X }} must appear in the step's env: block (already wired in these examples).

2.5 KiB Raw Permalink Blame History

Example consumer workflows

2.5 KiB

Raw Permalink Blame History