fix: clean-lens findings + trim the dogfood swarm to strong reviewers #4

Merged
steve merged 2 commits from fix/clean-lens-no-findings into main 2026-06-27 22:14:08 +00:00

2 Commits

Author SHA1 Message Date
steve c87f97b7b2 ci: trim the dogfood swarm to the strong reviewers
Build & push image / build-and-push (pull_request) Successful in 7s
Drop the low-signal reviewers from gadfly's own swarm per the scoreboard:
- m5/qwen3.6:35b-mlx (slow local Mac; removes the last foreman/local lane,
  so GADFLY_ENDPOINT_M5 + the m5 concurrency lane are gone)
- gemma4:cloud, gpt-oss:120b-cloud, kimi-k2.7-code:cloud (weak cloud models)

Remaining: minimax-m3, glm-5.2, glm-5.1, deepseek-v4-pro, nemotron-3-super,
qwen3-coder:480b + claude-code/sonnet — 6 cloud + the Claude Code engine,
all fast cloud lanes. Takes effect once this merges to main.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-27 18:07:47 -04:00
steve 85f3b2546b fix: don't emit findings from clean "No material issues" lenses
Build & push image / build-and-push (pull_request) Successful in 7s
Adversarial Review (Gadfly) / review (pull_request) Successful in 8m33s
A lens whose verdict is "No material issues found" still tends to write
path:line references — but as verification notes ("verified X at
file:line is safe"), not problems. The telemetry was extracting those as
findings, which (a) pollutes the gadfly-reports store with false
positives and (b) unfairly penalizes thorough reviewers that do clean
passes — the FP penalty hit clean security passes from claude-code/sonnet,
deepseek, and minimax even though they correctly found nothing.

emit() now skips findings extraction for a clean-verdict lens (the run is
still recorded). Surfaced by grading the dogfood reviews: a large share
of "false positives" were exactly these clean-verification bullets.

Added TestEmit_SkipsCleanVerdictLens; README telemetry section updated.
gofmt clean, go vet quiet, go test -race green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-27 17:59:42 -04:00