feat(engine): add opencode CLI review engine #26

Merged

steve merged 4 commits from feat/opencode-engine into main 2026-07-18 05:51:51 +00:00

Conversation 4 Commits 4 Files Changed 13

+807 -36

4 Commits

Author	SHA1	Message	Date
steveandClaude Opus 4.8	2477e50230	fix(opencode): address gadfly's dogfood review ... Gadfly's own swarm reviewed PR #26 and reached consensus (3/3 models) on a real bug, plus flagged security/maintainability items. Fixes: - Pass-through auth (BLOCKING, 3/3 agreement): openCodeEnv() stripped every provider key except OLLAMA_API_KEY, so the documented opencode/<provider>/<model> escape hatch (e.g. opencode/anthropic/...) had no way to authenticate — the reusable workflow forwards ANTHROPIC_API_KEY/OPENAI_API_KEY into the container and the allowlist discarded them. Now forward ANTHROPIC_*/OPENAI_*/GOOGLE_*/ GEMINI_* so OpenCode's built-in providers can authenticate, while still withholding gadfly's own secrets (Gitea/findings tokens, claude-code OAuth). - Read-only hardening (security lens): the generated config denied only edit/bash. Using OpenCode's documented permission schema, also deny webfetch/websearch/ external_directory — the network + out-of-sandbox tools — closing the exfiltration surface a prompt-injected review could otherwise reach. Permission is now a map so the deny set is extensible. - Dedup (maintainability lens, 3/3): extract shared filterEnv() and killGroupOnCancel() helpers in engine.go, used by both shell-out engines' runPass/env builders instead of the copy-pasted blocks. - Cosmetic: split the const block so defaultOpenCodeBaseURL's doc comment no longer visually misattaches to the agent-name const. README updated: the read-only note and the reduced-env note now reflect the broader deny set and the forwarded provider keys. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>	2026-07-18 01:29:29 -04:00
steveandClaude Opus 4.8	463aa01ddb	fix(dogfood): bump reusable image pin past the Gitea 1.27 reclassification ... The self-review kept skipping every PR with "event 'workflow_call' not handled": review-reusable.yml pinned the reviewer image at sha-3095ebf, which predates the entrypoint.sh reclassification (added in 9d74cb9) that maps a called workflow's github.event_name = 'workflow_call' back to pull_request/issue_comment. Under Gitea >= 1.27 the container therefore saw an unhandled event and self-skipped in ~1s, even though PR was populated. Bump the pin to sha-f468fe6 (current main HEAD, which contains the fix) so the dogfood path actually reviews. The pr_number threading in the prior commit fixes the manual-dispatch input propagation; this fixes the pull_request path. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>	2026-07-18 01:14:27 -04:00
steveandClaude Opus 4.8	3973e469a8	fix(dogfood): thread dispatch pr_number into gadfly's own review caller ... gadfly's self-review adversarial-review.yml calls review-reusable.yml but was never updated for the Gitea >= 1.27 breaking change (go-gitea#37478): a called workflow no longer receives the caller's workflow_dispatch inputs in github.event, so a manual "review PR #N" dispatch reached the reusable with an empty PR. Commit 64d34bd added the pr_number workflow_call input and mort's caller threads it; this brings gadfly's own caller in line so the dogfood path works on the same Gitea version. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>	2026-07-18 01:07:56 -04:00
steveandClaude Opus 4.8	5ab4074e9c	feat(engine): add opencode CLI review engine ... Add a third review harness alongside the in-process majordomo loop and the claude-code CLI shell-out: the OpenCode CLI (opencode.ai) driving an ollama-cloud model, selected by an "opencode/<model>" spec. The goal is to benchmark gadfly's boutique executus harness against a freely-available agentic harness on the SAME model (e.g. "ollama-cloud/glm-5.2" vs "opencode/glm-5.2"). OpenCode has no --append-system-prompt flag, so the lens system prompt and the read-only discipline are delivered through a generated config injected via OPENCODE_CONFIG_CONTENT: a "gadfly" agent whose prompt is the system prompt with edit/bash denied at both the global and agent level, plus a "gadfly" ollama-cloud provider. That env var is the highest-precedence config source in the container, so a reviewed repo's own opencode.json can't re-enable edits on the reviewer. Spec forms: "opencode/<model>" (wrapped in the generated provider), the "open-code/" alias, "opencode/<provider>/<model>" pass-through to OpenCode's own registry, and bare "opencode". Model ids are taken verbatim so colon-bearing ollama ids (qwen3-coder:480b-cloud) survive. Auth reuses OLLAMA_CLOUD_API_KEY (mapped to OLLAMA_API_KEY, referenced as {env:OLLAMA_API_KEY} in config, never a literal secret). Knobs mirror GADFLY_CLAUDE_*: GADFLY_OPENCODE_BIN/MODEL/BASE_URL/ EXTRA_ARGS. openCodeEnv() forwards OLLAMA_API_KEY (the inverse of claudeEnv) but still withholds the Gitea/findings/Anthropic secrets. main.go engine selection is now a switch (claude-code / opencode / majordomo), and the auto-select path uses a type-check instead of a boolean so a shell-out engine can never hit the *majordomoEngine assertion. auto-select and delegate_investigation stay majordomo-only and are skipped for opencode (the CLI does its own legwork). Dockerfile bundles opencode-ai (npm auto-selects its musl build on alpine) with a best-effort version check + provider pre-warm that never fails the shared image build. README/examples/CLAUDE.md/scripts updated per the maintenance rules. Tests: new opencode_test.go mirrors engine_test.go (spec/model/args/config/env- filter + stub-CLI runtime tests). Verified end-to-end with a fake opencode CLI: correct argv, injected config, and consolidated markdown output. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>	2026-07-18 01:00:54 -04:00