Steve Dudenhoeffer
1a2a2364ec
Address the swarm's findings on this rollout: - Replace `secrets: inherit` (which forwarded ALL repo secrets — registry/ Komodo/Discord/DB creds the reviewer never uses) with explicit forwarding of only OLLAMA_CLOUD_API_KEY / CLAUDE_CODE_OAUTH_TOKEN / findings tokens. GITEA_TOKEN is the automatic job token (github.token in the reusable). - Pin uses: ...@main -> @20a5c43 (immutable) so a push to gadfly can't change the code that runs with our forwarded secrets. Requires gadfly's review-reusable.yml secrets contract (steve/gadfly#9, merged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
57 lines
2.3 KiB
YAML
57 lines
2.3 KiB
YAML
# Gadfly adversarial review — subscribes to steve/gadfly's reusable workflow.
|
|
# Mirrors gadfly's own dogfood config: 6 cloud models + the Claude Code engine
|
|
# (sonnet, opus, and opus with max extended thinking). No local Macs. Advisory
|
|
# only — never blocks a merge.
|
|
|
|
name: Adversarial Review (Gadfly)
|
|
|
|
on:
|
|
pull_request:
|
|
types: [opened, reopened, ready_for_review]
|
|
issue_comment:
|
|
types: [created]
|
|
workflow_dispatch:
|
|
inputs:
|
|
pr_number:
|
|
description: "PR number to review"
|
|
required: true
|
|
|
|
permissions:
|
|
contents: read
|
|
issues: write
|
|
pull-requests: write
|
|
|
|
concurrency:
|
|
group: gadfly-${{ github.event.issue.number || github.event.pull_request.number || github.event.inputs.pr_number }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
review:
|
|
# Security: only trusted users may trigger a secret-bearing run via a PR
|
|
# comment (pull_request + workflow_dispatch are already trusted). Mirrors
|
|
# the allowed_users input below (the in-container belt-and-suspenders check).
|
|
if: >-
|
|
github.event_name != 'issue_comment'
|
|
|| (github.event.issue.pull_request
|
|
&& (github.actor == 'steve'
|
|
|| github.actor == 'fizi'
|
|
|| github.actor == 'dazed'))
|
|
# Pinned to an immutable gadfly commit (not @main): a push to gadfly can't
|
|
# silently change the code that runs with our forwarded secrets.
|
|
uses: steve/gadfly/.gitea/workflows/review-reusable.yml@20a5c431f22d43bab0f711c14ce74de3a735c110
|
|
# Least privilege: forward ONLY the secrets this swarm uses (GITEA_TOKEN is auto).
|
|
secrets:
|
|
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
|
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
|
GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }}
|
|
GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }}
|
|
with:
|
|
models: "minimax-m3:cloud,glm-5.2:cloud,glm-5.1:cloud,deepseek-v4-pro:cloud,nemotron-3-super:cloud,qwen3-coder:480b-cloud,claude-code/sonnet,claude-code/opus,claude-code/opus:max"
|
|
specialists: "security,correctness,error-handling"
|
|
provider_concurrency: "ollama-cloud=3,claude-code=2"
|
|
provider_lens_concurrency: "ollama-cloud=3"
|
|
timeout_secs: "600"
|
|
max_steps: "14"
|
|
allowed_users: "steve,fizi,dazed"
|
|
timeout_minutes: 90
|