Files
pansy/internal/config/config.go
T
steveandClaude Opus 4.8 0f3dedab73 Address Gadfly review findings on Phase 0
Applied the fixes warranted by the adversarial review of PR #21 (all
findings graded in the gadfly store):

Store (highest impact):
- buildDSN always merges busy_timeout/journal_mode/foreign_keys pragmas
  into the DSN, even for file: URIs or paths with a query string — the
  prior passthrough silently disabled FK enforcement for those PANSY_DB
  values. Also escape '#' in the path and tighten in-memory detection to
  an exact ':memory:' token or mode=memory param (no substring misfire).
- migrate.go: detect duplicate migration versions with a clear error;
  wrap appliedVersions' rows.Err() with the store: prefix.

API:
- SetTrustedProxies failure now falls back to trust-none instead of
  leaving gin's trust-everyone default (X-Forwarded-For spoofing).
- SPA: 404 embedded directories (was a directory listing), 404 bare /api,
  add X-Content-Type-Options: nosniff, cache index.html bytes once at
  startup, single fs.Stat existence check, shared writeAPIError helper.
- Move gin.SetMode out of package init() into New().

Config: validate PANSY_PORT range (fall back to 8080 with a warning).

Web:
- api.ts: serialize the request body before the fetch try so a
  JSON.stringify failure isn't misreported as a network error.
- AppShell: move state-specific/conflicting utilities into
  active/inactiveProps so concatenated Tailwind classes don't collide.

Tests: added store DSN-pragma/memory-detection cases and SPA
directory-404 case. go build/vet/test clean (CGO off); web tsc + build
clean; re-verified in a browser (SPA, deep links, /assets 404, nav).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01JdQpdYYsTgtkJBxbcpAszi
2026-07-18 15:19:30 -04:00

142 lines
4.3 KiB
Go

// Package config loads pansy's runtime configuration from the environment.
//
// Every value has a sensible default so `pansy` runs with zero configuration
// for local use; production deployments override via PANSY_* env vars. Auth
// values (local + OIDC) are plumbed here now and consumed by the auth issues
// (#4 local, #5 OIDC).
package config
import (
"log/slog"
"os"
"strconv"
"strings"
)
// Registration gates local self-service signup.
const (
RegistrationOpen = "open"
RegistrationClosed = "closed"
)
// Config is the fully-resolved runtime configuration.
type Config struct {
// Port is the TCP port the HTTP server listens on (PANSY_PORT, default 8080).
Port int
// DBPath is the SQLite database file path (PANSY_DB, default ./pansy.db).
DBPath string
// BaseURL is the externally-visible base URL, used to derive the OIDC
// redirect URI and absolute links (PANSY_BASE_URL). Empty in bare local dev.
BaseURL string
// Registration is "open" or "closed"; gates POST /auth/register for local
// accounts (PANSY_REGISTRATION, default open). OIDC JIT provisioning ignores
// this — the IdP gates access.
Registration string
// LocalAuth enables argon2id username/password auth (PANSY_LOCAL_AUTH,
// default true). Set false for pure-Authentik deployments.
LocalAuth bool
// OIDC holds the optional OpenID Connect provider settings.
OIDC OIDCConfig
// TrustedProxies is the set of proxy CIDRs/IPs gin trusts for client IP
// resolution (PANSY_TRUSTED_PROXIES, comma-separated). Empty trusts none.
TrustedProxies []string
}
// OIDCConfig holds the OpenID Connect provider settings (Authentik is the
// primary IdP). Consumed by #5.
type OIDCConfig struct {
Issuer string // PANSY_OIDC_ISSUER — discovery base URL
ClientID string // PANSY_OIDC_CLIENT_ID
ClientSecret string // PANSY_OIDC_CLIENT_SECRET
ButtonLabel string // PANSY_OIDC_BUTTON_LABEL — login-page button text
}
// Enabled reports whether enough OIDC config is present to attempt discovery.
func (o OIDCConfig) Enabled() bool {
return o.Issuer != "" && o.ClientID != ""
}
// RegistrationOpen reports whether local self-service signup is allowed.
func (c *Config) RegistrationOpen() bool {
return c.Registration == RegistrationOpen
}
// Load reads configuration from the environment, applying defaults. It never
// fails: invalid numeric/boolean values fall back to the default and are logged.
func Load() *Config {
cfg := &Config{
Port: envInt("PANSY_PORT", 8080),
DBPath: envStr("PANSY_DB", "./pansy.db"),
BaseURL: strings.TrimRight(envStr("PANSY_BASE_URL", ""), "/"),
Registration: envStr("PANSY_REGISTRATION", RegistrationOpen),
LocalAuth: envBool("PANSY_LOCAL_AUTH", true),
OIDC: OIDCConfig{
Issuer: envStr("PANSY_OIDC_ISSUER", ""),
ClientID: envStr("PANSY_OIDC_CLIENT_ID", ""),
ClientSecret: envStr("PANSY_OIDC_CLIENT_SECRET", ""),
ButtonLabel: envStr("PANSY_OIDC_BUTTON_LABEL", "Sign in with SSO"),
},
TrustedProxies: envList("PANSY_TRUSTED_PROXIES"),
}
if cfg.Registration != RegistrationOpen && cfg.Registration != RegistrationClosed {
slog.Warn("config: invalid PANSY_REGISTRATION, defaulting to open", "value", cfg.Registration)
cfg.Registration = RegistrationOpen
}
if cfg.Port < 1 || cfg.Port > 65535 {
slog.Warn("config: PANSY_PORT out of range, using default", "value", cfg.Port, "default", 8080)
cfg.Port = 8080
}
return cfg
}
func envStr(key, def string) string {
if v, ok := os.LookupEnv(key); ok && v != "" {
return v
}
return def
}
func envInt(key string, def int) int {
v, ok := os.LookupEnv(key)
if !ok || v == "" {
return def
}
n, err := strconv.Atoi(v)
if err != nil {
slog.Warn("config: invalid int env, using default", "key", key, "value", v, "default", def)
return def
}
return n
}
func envBool(key string, def bool) bool {
v, ok := os.LookupEnv(key)
if !ok || v == "" {
return def
}
b, err := strconv.ParseBool(v)
if err != nil {
slog.Warn("config: invalid bool env, using default", "key", key, "value", v, "default", def)
return def
}
return b
}
func envList(key string) []string {
v, ok := os.LookupEnv(key)
if !ok || v == "" {
return nil
}
parts := strings.Split(v, ",")
out := make([]string, 0, len(parts))
for _, p := range parts {
if p = strings.TrimSpace(p); p != "" {
out = append(out, p)
}
}
return out
}