CI: build and push the container image for Komodo deploys #22
@@ -0,0 +1,34 @@
|
||||
# VCS / editor / docs — not needed in the image build context.
|
||||
|
|
||||
.git
|
||||
.gitea
|
||||
.idea
|
||||
.vscode
|
||||
*.md
|
||||
LICENSE
|
||||
|
||||
# Secrets and env files must never be baked into an image layer.
|
||||
.env
|
||||
.env.*
|
||||
|
||||
# Local build outputs and databases.
|
||||
/pansy
|
||||
*.db
|
||||
*.db-wal
|
||||
*.db-shm
|
||||
|
||||
# Go workspace files (pansy builds standalone; GOWORK=off).
|
||||
go.work
|
||||
go.work.sum
|
||||
|
||||
# Frontend deps/output are rebuilt inside the image's web stage.
|
||||
web/node_modules
|
||||
web/dist
|
||||
web/.vite
|
||||
|
||||
# The embedded web build is produced fresh in the image (web stage → embed
|
||||
# directory), so never ship stale local contents. dist.go itself is kept.
|
||||
internal/webdist/dist
|
||||
|
||||
# Assorted local scratch.
|
||||
.playwright-mcp
|
||||
.claude
|
||||
@@ -0,0 +1,87 @@
|
||||
name: Build image
|
||||
|
||||
# Build the single-binary image and push it to the Gitea container registry so
|
||||
# it can be deployed with Komodo. Tagging (see README for the canonical table):
|
||||
# * main -> :latest
|
||||
# * any other branch -> :<branch-name> (sanitized to valid Docker tag chars)
|
||||
# * every build also -> :sha-<short> (immutable, handy for pinning)
|
||||
#
|
||||
# Runs on every branch push (so branch images are always available) and can be
|
||||
# triggered manually. A push to a PR branch covers the PR too, so there is no
|
||||
# separate pull_request trigger (avoids double builds).
|
||||
|
||||
on:
|
||||
push:
|
||||
branches: ['**']
|
||||
workflow_dispatch:
|
||||
|
||||
concurrency:
|
||||
group: build-image-${{ github.ref }}
|
||||
cancel-in-progress: true
|
||||
|
||||
env:
|
||||
IMAGE_NAME: gitea.stevedudenhoeffer.com/steve/pansy
|
||||
|
||||
jobs:
|
||||
build-and-push:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Checkout
|
||||
|
gitea-actions
commented
🔴 Untrusted github.ref_name interpolated into run: script enables script injection correctness, error-handling, security · flagged by 5 models
🪰 Gadfly · advisory 🔴 **Untrusted github.ref_name interpolated into run: script enables script injection**
_correctness, error-handling, security · flagged by 5 models_
- `.gitea/workflows/build-image.yml:29-31` — GitHub/Gitea Actions **script injection**. `${{ github.ref_name }}` (and `${{ github.token }}`) are interpolated directly into the `run:` shell script text before it's parsed, rather than passed through an `env:` var: ``` REPO_URL="https://token:${{ github.token }}@gitea.stevedudenhoeffer.com/${{ github.repository }}.git" git clone --depth=1 --branch "${{ github.ref_name }}" "$REPO_URL" . ``` The workflow triggers on push to **any branch** (`branches:…
<sub>🪰 Gadfly · advisory</sub>
|
||||
# Untrusted values (branch name) go through env, never inline ${{ }}, so a
|
||||
# crafted branch name can't inject shell. Check out the exact triggering
|
||||
# commit so the sha-<short> tag matches the code that was built.
|
||||
env:
|
||||
REPO: ${{ github.repository }}
|
||||
REF_NAME: ${{ github.ref_name }}
|
||||
SHA: ${{ github.sha }}
|
||||
GIT_TOKEN: ${{ github.token }}
|
||||
run: |
|
||||
git init -q .
|
||||
git remote add origin "https://token:${GIT_TOKEN}@gitea.stevedudenhoeffer.com/${REPO}.git"
|
||||
git fetch -q --depth=1 origin "$SHA" || git fetch -q --depth=1 origin "$REF_NAME"
|
||||
|
gitea-actions
commented
🟠 docker login failure not isolated; build fails later with cryptic error error-handling · flagged by 1 model
🪰 Gadfly · advisory 🟠 **docker login failure not isolated; build fails later with cryptic error**
_error-handling · flagged by 1 model_
- **`.gitea/workflows/build-image.yml:41`** — `docker login` failure is not checked. If the registry is unreachable or credentials are wrong, the step exits 0 (because the pipeline only sees the last command's status if it fails, but actually `docker login` *does* exit non-zero on failure, so this is a minor concern, *except* that if `REGISTRY_PASSWORD` is empty, `echo "" | docker login …` might behave unexpectedly. However, the bigger issue is: the `docker buildx build --push` step later will f…
<sub>🪰 Gadfly · advisory</sub>
|
||||
git checkout -q FETCH_HEAD
|
||||
|
||||
- name: Set up Docker Buildx
|
||||
# Check first so a genuine create failure surfaces (rather than being
|
||||
# hidden behind a swallowed "already exists").
|
||||
run: |
|
||||
docker buildx inspect pansy-builder >/dev/null 2>&1 \
|
||||
|
gitea-actions
commented
🔴 Branch sanitization can produce empty Docker tag causing invalid build command correctness, error-handling, maintainability · flagged by 5 models
🪰 Gadfly · advisory 🔴 **Branch sanitization can produce empty Docker tag causing invalid build command**
_correctness, error-handling, maintainability · flagged by 5 models_
- **`.gitea/workflows/build-image.yml:50-52`** — Branch-name sanitization can produce an **empty string** for inputs like `---` or `/` (all characters stripped by the first `sed`, then the second `sed` doesn't help because the string is already empty). When `PRIMARY` is empty, `TAGS` becomes `,:sha-<short>`, which splits into an empty tag and a sha tag. The empty tag causes `docker buildx build --tag ` (trailing nothing) which is invalid syntax and fails the build. **Fix:** Add a fallback after…
<sub>🪰 Gadfly · advisory</sub>
|
||||
|| docker buildx create --name pansy-builder --driver docker-container
|
||||
docker buildx use pansy-builder
|
||||
|
||||
- name: Log in to Gitea registry
|
||||
env:
|
||||
REGISTRY_USER: ${{ secrets.REGISTRY_USER }}
|
||||
REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
|
||||
run: echo "${REGISTRY_PASSWORD}" | docker login gitea.stevedudenhoeffer.com -u "${REGISTRY_USER}" --password-stdin
|
||||
|
||||
- name: Build and push (linux/amd64)
|
||||
|
gitea-actions
commented
🟠 TAG_FLAGS string concatenation vulnerable to word-splitting if tags contain spaces error-handling, maintainability, performance · flagged by 3 models
🪰 Gadfly · advisory 🟠 **TAG_FLAGS string concatenation vulnerable to word-splitting if tags contain spaces**
_error-handling, maintainability, performance · flagged by 3 models_
- **`.gitea/workflows/build-image.yml:59-63`** — `TAG_FLAGS` is built by string concatenation without quotes and later expanded unquoted in the `docker buildx build` command. If `PRIMARY` somehow contains a space (e.g., if the sanitization regex is ever relaxed), `TAG_FLAGS` will inject extra arguments into the docker command, potentially causing mis-tagging or option injection. **Fix:** Build tags into a bash array and expand it safely: ```bash TAG_FLAGS=() IFS=',' read -ra TAG_ARRAY <<< "${{ s…
<sub>🪰 Gadfly · advisory</sub>
|
||||
env:
|
||||
REF_NAME: ${{ github.ref_name }}
|
||||
SHA: ${{ github.sha }}
|
||||
run: |
|
||||
SHA_SHORT=$(echo "$SHA" | cut -c1-7)
|
||||
|
||||
if [ "$REF_NAME" = "main" ]; then
|
||||
PRIMARY="latest"
|
||||
else
|
||||
# Normalize the branch name to valid Docker tag chars [a-zA-Z0-9._-].
|
||||
PRIMARY=$(echo "$REF_NAME" | sed 's/[^a-zA-Z0-9._-]/-/g; s/--*/-/g; s/^[-.]*//; s/-*$//')
|
||||
# A non-main branch must never clobber :latest, and the tag can't be empty.
|
||||
[ "$PRIMARY" = "latest" ] && PRIMARY="branch-latest"
|
||||
[ -z "$PRIMARY" ] && PRIMARY="branch-${SHA_SHORT}"
|
||||
fi
|
||||
|
||||
# Build the tag flags as an array so no word-splitting/quoting surprises.
|
||||
TAGS=(--tag "${IMAGE_NAME}:${PRIMARY}" --tag "${IMAGE_NAME}:sha-${SHA_SHORT}")
|
||||
echo "Building ${IMAGE_NAME}:${PRIMARY} and ${IMAGE_NAME}:sha-${SHA_SHORT}"
|
||||
|
||||
docker buildx build \
|
||||
--push \
|
||||
--platform linux/amd64 \
|
||||
"${TAGS[@]}" \
|
||||
--build-arg "BUILD_COMMIT=${SHA}" \
|
||||
--build-arg "BUILD_BRANCH=${REF_NAME}" \
|
||||
--build-arg "BUILD_TIME=$(date -u '+%Y-%m-%dT%H:%M:%SZ')" \
|
||||
--file ./Dockerfile \
|
||||
.
|
||||
@@ -0,0 +1,62 @@
|
||||
# syntax=docker/dockerfile:1
|
||||
#
|
||||
# pansy ships as one static binary with the web build embedded. This is a
|
||||
# three-stage build: compile the frontend, embed it into the Go binary, then
|
||||
# copy that single binary into a minimal runtime image.
|
||||
|
||||
# ---- stage 1: build the web bundle ------------------------------------------
|
||||
FROM node:22-alpine AS web
|
||||
WORKDIR /web
|
||||
COPY web/package.json web/package-lock.json ./
|
||||
RUN --mount=type=cache,target=/root/.npm npm ci
|
||||
|
gitea-actions
commented
🟠 npm ci lacks BuildKit cache mount, causing redundant package downloads on every build performance · flagged by 1 model 🪰 Gadfly · advisory 🟠 **npm ci lacks BuildKit cache mount, causing redundant package downloads on every build**
_performance · flagged by 1 model_
<sub>🪰 Gadfly · advisory</sub>
|
||||
COPY web/ ./
|
||||
RUN npm run build
|
||||
|
||||
# ---- stage 2: build the static Go binary (web bundle embedded) --------------
|
||||
FROM golang:1.26-alpine AS build
|
||||
# GOWORK=off matches the Makefile: pansy is a standalone module, built without
|
||||
|
gitea-actions
commented
🟠 Dockerfile omits GOWORK=off, diverging from Makefile pattern maintainability · flagged by 2 models 🪰 Gadfly · advisory 🟠 **Dockerfile omits GOWORK=off, diverging from Makefile pattern**
_maintainability · flagged by 2 models_
<sub>🪰 Gadfly · advisory</sub>
|
||||
# any parent workspace even if one leaks into the build context.
|
||||
ENV CGO_ENABLED=0 GOTOOLCHAIN=auto GOWORK=off
|
||||
WORKDIR /src
|
||||
COPY go.mod go.sum ./
|
||||
RUN --mount=type=cache,target=/go/pkg/mod go mod download
|
||||
COPY . .
|
||||
# Overlay the freshly built frontend into the embed directory before compiling
|
||||
|
gitea-actions
commented
🟡 Embed path hardcoded while Makefile parameterizes it maintainability · flagged by 1 model 🪰 Gadfly · advisory 🟡 **Embed path hardcoded while Makefile parameterizes it**
_maintainability · flagged by 1 model_
<sub>🪰 Gadfly · advisory</sub>
|
||||
# (//go:embed all:dist in internal/webdist).
|
||||
COPY --from=web /web/dist ./internal/webdist/dist
|
||||
RUN --mount=type=cache,target=/go/pkg/mod \
|
||||
--mount=type=cache,target=/root/.cache/go-build \
|
||||
go build -trimpath -ldflags "-s -w" -o /out/pansy ./cmd/pansy
|
||||
|
||||
# ---- stage 3: minimal runtime -----------------------------------------------
|
||||
FROM alpine:3.20
|
||||
ARG BUILD_COMMIT=unknown
|
||||
ARG BUILD_BRANCH=unknown
|
||||
ARG BUILD_TIME=unknown
|
||||
LABEL org.opencontainers.image.title="pansy" \
|
||||
|
gitea-actions
commented
🟡 Registry/repo path hardcoded in Dockerfile LABEL, workflow env, and README with no single source of truth correctness, maintainability · flagged by 3 models 🪰 Gadfly · advisory 🟡 **Registry/repo path hardcoded in Dockerfile LABEL, workflow env, and README with no single source of truth**
_correctness, maintainability · flagged by 3 models_
<sub>🪰 Gadfly · advisory</sub>
|
||||
org.opencontainers.image.description="Self-hostable garden planner" \
|
||||
org.opencontainers.image.source="https://gitea.stevedudenhoeffer.com/steve/pansy" \
|
||||
org.opencontainers.image.revision="${BUILD_COMMIT}" \
|
||||
org.opencontainers.image.version="${BUILD_BRANCH}" \
|
||||
org.opencontainers.image.created="${BUILD_TIME}"
|
||||
|
||||
# ca-certificates: outbound TLS (e.g. OIDC discovery). tzdata: correct local time.
|
||||
RUN apk add --no-cache ca-certificates tzdata \
|
||||
&& adduser -D -u 10001 pansy \
|
||||
&& mkdir -p /data \
|
||||
&& chown pansy:pansy /data
|
||||
|
||||
COPY --from=build /out/pansy /usr/local/bin/pansy
|
||||
|
||||
USER pansy
|
||||
# The SQLite database lives on the /data volume so it survives container updates.
|
||||
ENV PANSY_PORT=8080 \
|
||||
PANSY_DB=/data/pansy.db
|
||||
WORKDIR /data
|
||||
VOLUME /data
|
||||
EXPOSE 8080
|
||||
|
gitea-actions
commented
🟠 HEALTHCHECK uses wget which may not exist in alpine:3.20 runtime error-handling · flagged by 1 model 🪰 Gadfly · advisory 🟠 **HEALTHCHECK uses wget which may not exist in alpine:3.20 runtime**
_error-handling · flagged by 1 model_
<sub>🪰 Gadfly · advisory</sub>
|
||||
|
||||
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
|
||||
CMD wget -q -O - "http://127.0.0.1:${PANSY_PORT}/api/v1/healthz" || exit 1
|
||||
|
||||
ENTRYPOINT ["/usr/local/bin/pansy"]
|
||||
@@ -58,3 +58,42 @@ All configuration is via environment variables; every value has a default, so `.
|
||||
| `PANSY_TRUSTED_PROXIES` | *(none)* | Comma-separated proxy CIDRs/IPs to trust for client-IP resolution. |
|
||||
|
||||
Auth variables are read at startup now and consumed as the auth features land (issues #4/#5).
|
||||
|
||||
## Docker & deployment
|
||||
|
||||
CI (`.gitea/workflows/build-image.yml`) builds the single-binary image and pushes it to the Gitea registry on every branch push:
|
||||
|
||||
| Ref | Tag |
|
||||
|
gitea-actions
commented
🟡 Tagging table duplicated between workflow comment and README; will drift maintainability · flagged by 1 model
🪰 Gadfly · advisory 🟡 **Tagging table duplicated between workflow comment and README; will drift**
_maintainability · flagged by 1 model_
- **`README.md:66-70` vs `.gitea/workflows/build-image.yml:3-7` — duplicated tagging table.** The same `Ref → Tag` mapping appears in the workflow header comment and in the README's Docker section. Two places to keep in sync when tagging rules change; the workflow comment is the canonical source and the README copy will drift. Suggest linking to the workflow instead of restating it, or trimming the README table to prose.
<sub>🪰 Gadfly · advisory</sub>
|
||||
| --- | --- |
|
||||
| `main` | `gitea.stevedudenhoeffer.com/steve/pansy:latest` |
|
||||
| any other branch | `gitea.stevedudenhoeffer.com/steve/pansy:<branch-name>` |
|
||||
| every build | `gitea.stevedudenhoeffer.com/steve/pansy:sha-<short>` (immutable; use to pin) |
|
||||
|
||||
The image runs as a non-root user, serves on `:8080`, and stores the SQLite database on the `/data` volume. Run it directly:
|
||||
|
||||
```sh
|
||||
docker run -d --name pansy \
|
||||
|
gitea-actions
commented
🟡 docker run example hardcodes :latest while Compose uses ${PANSY_TAG:-latest}; inconsistent pinning guidance maintainability · flagged by 1 model
🪰 Gadfly · advisory 🟡 **docker run example hardcodes :latest while Compose uses ${PANSY_TAG:-latest}; inconsistent pinning guidance**
_maintainability · flagged by 1 model_
- **`README.md:75-78` vs `README.md:86,99` — inconsistent tag-pinning guidance.** The `docker run` example hardcodes `:latest` (line 78), while the Compose example uses `${PANSY_TAG:-latest}` (line 86), and the closing sentence tells the user to "pin `PANSY_TAG` to a `sha-<short>` tag" (line 99). The `docker run` example gives no equivalent pinning knob, so a reader of that section's first example gets a different (less reproducible) pattern than the second. Suggest showing `-e PANSY_TAG=sha-<sh…
<sub>🪰 Gadfly · advisory</sub>
|
||||
-p 8080:8080 \
|
||||
-v pansy-data:/data \
|
||||
gitea.stevedudenhoeffer.com/steve/pansy:latest
|
||||
```
|
||||
|
||||
Or as a Komodo/Compose stack:
|
||||
|
||||
```yaml
|
||||
services:
|
||||
pansy:
|
||||
image: gitea.stevedudenhoeffer.com/steve/pansy:${PANSY_TAG:-latest}
|
||||
ports:
|
||||
- "8080:8080"
|
||||
volumes:
|
||||
- pansy-data:/data
|
||||
environment:
|
||||
PANSY_BASE_URL: https://pansy.example.com
|
||||
# PANSY_OIDC_ISSUER: ... # once auth (#5) lands
|
||||
restart: unless-stopped
|
||||
volumes:
|
||||
pansy-data:
|
||||
```
|
||||
|
||||
Pin `PANSY_TAG` to a `sha-<short>` tag for reproducible deploys, or leave it at `latest` to track `main`.
|
||||
|
||||
🟠 .dockerignore omits .env, allowing local secrets to be baked into build-stage image layer
maintainability, security · flagged by 4 models
🪰 Gadfly · advisory