Reclaim mobile chrome: drop the editor's top banner, un-cramp the assistant #121

Merged
steve merged 2 commits from feat/mobile-space-polish into main 2026-07-23 01:32:59 +00:00
4 changed files with 57 additions and 13 deletions
+15 -3
View File
@@ -43,12 +43,22 @@ export function AppShell() {
// max-w-5xl reading measure the other pages use (#107).
const canvasRoute = inEditor || inPublicGarden
const showBottomNav = !!user && !canvasRoute
// On a phone the editor is a full-screen canvas, so the global top bar is pure
// chrome above the garden — hide it and let the editor's own strip carry the
// back link AND the account menu (so sign-out isn't lost). Editor only, not the
// public view, which has no strip of its own to fall back on.
const hideHeaderOnMobile = inEditor
Outdated
Review

🟠 Hiding the global header on mobile in the editor removes the only sign-out affordance (AccountMenu), weakening session control on shared devices

correctness, error-handling, maintainability, security · flagged by 2 models

  • Loss of the only sign-out affordance on mobile in the editor (web/src/components/layout/AppShell.tsx:51,57-61). The global header — which contains AccountMenu, the app's only "Sign out" control (AppShell.tsx:92/130-197) — is now hidden md:block whenever inEditor is true. The editor's replacement mobile strip (GardenEditorPage.tsx:608-630) adds only a 🌱 Link to="/gardens" and garden/season/share controls — no account or sign-out control. showBottomNav is also false on th…

🪰 Gadfly · advisory

🟠 **Hiding the global header on mobile in the editor removes the only sign-out affordance (AccountMenu), weakening session control on shared devices** _correctness, error-handling, maintainability, security · flagged by 2 models_ - **Loss of the only sign-out affordance on mobile in the editor** (`web/src/components/layout/AppShell.tsx:51,57-61`). The global header — which contains `AccountMenu`, the app's only "Sign out" control (`AppShell.tsx:92`/`130-197`) — is now `hidden md:block` whenever `inEditor` is true. The editor's replacement mobile strip (`GardenEditorPage.tsx:608-630`) adds only a 🌱 `Link to="/gardens"` and garden/season/share controls — no account or sign-out control. `showBottomNav` is also `false` on th… <sub>🪰 Gadfly · advisory</sub>
const visibleSections = sections.filter((s) => !s.adminOnly || user?.isAdmin)
return (
<div className="flex min-h-full flex-col">
<header className="sticky top-0 z-20 border-b border-border bg-surface/90 backdrop-blur">
<header
className={cn(
'sticky top-0 z-20 border-b border-border bg-surface/90 backdrop-blur',
hideHeaderOnMobile && 'hidden md:block',
)}
>
{/* The bar matches the content width below: constrained on reading pages,
edge-to-edge on the canvas routes so the brand aligns with the editor. */}
<nav className={cn('flex items-center gap-4 px-4 py-3', canvasRoute ? '' : 'mx-auto max-w-5xl')}>
@@ -115,8 +125,10 @@ export function AppShell() {
}
/** Account control: a compact button that toggles a small sign-out popover. On
* desktop the display name shows inline; on mobile it lives inside the popover. */
function AccountMenu({ displayName }: { displayName: string }) {
* desktop the display name shows inline; on mobile it lives inside the popover.
* Exported so the editor's mobile strip can carry it — the global header that
* normally hosts it is hidden there (see hideHeaderOnMobile). */
export function AccountMenu({ displayName }: { displayName: string }) {
const logout = useLogout()
const navigate = useNavigate()
const [open, setOpen] = useState(false)
+1 -1
View File
@@ -143,7 +143,7 @@ export function ChatPanel({ gardenId, canEdit }: { gardenId: number; canEdit: bo
</p>
)}
<div className="flex min-h-0 flex-1 flex-col gap-2 overflow-y-auto">
<div className="flex min-h-0 flex-1 flex-col gap-3 overflow-y-auto">
{history.isPending && <p className="text-sm text-muted">Loading the conversation…</p>}
{/* A failed load rendering as an empty thread would look like the
conversation had been lost, which is a much worse thing to believe. */}
+16 -6
View File
@@ -18,10 +18,13 @@ import { cn } from '@/lib/cn'
* closes completely when nothing needs it.
*
* Layout differs by breakpoint. Desktop: a fixed 20rem column beside the canvas.
* Phone: an in-flow PEEK (#101) — a ≤50vh panel the editor's flex column places
* BETWEEN the canvas and the always-visible mode bar, so the canvas shrinks to
* keep the garden visible above it and the mode bar reachable below, rather than
* a bottom sheet that covered the whole garden.
* Phone: an in-flow PEEK (#101) — a capped-height panel the editor's flex column
* places BETWEEN the canvas and the always-visible mode bar, so the canvas
* shrinks to keep the garden visible above it and the mode bar reachable below,
* rather than a bottom sheet that covered the whole garden. `tall` raises that
* cap for panel modes (journal/history/assistant), where reading and typing are
* the task and a half-height peek felt cramped; the inspector keeps the shorter
* peek so the canvas it describes stays in view.
*/
export interface RailTab {
@@ -38,11 +41,14 @@ export function EditorRail({
activeId,
onActivate,
onClose,
tall = false,
}: {
tabs: RailTab[]
activeId: string
onActivate: (id: string) => void
onClose: () => void
/** Raise the mobile peek's height cap (panel modes want the room). */
tall?: boolean
}) {
const active = tabs.find((t) => t.id === activeId) ?? tabs[0]
if (!active) return null
@@ -54,8 +60,12 @@ export function EditorRail({
// canvas and the always-visible mode bar (the editor's flex column places
// it there), so the garden stays visible above it and the mode bar stays
// reachable below. The canvas flexes to fill whatever's left. Desktop: a
// fixed-width column beside the canvas.
'flex max-h-[50vh] min-h-0 shrink-0 flex-col rounded-t-xl border-t border-border bg-surface shadow-lg',
// fixed-width column beside the canvas (the cap doesn't apply there).
'flex min-h-0 shrink-0 flex-col rounded-t-xl border-t border-border bg-surface shadow-lg',
// dvh, not vh: the enclosing editor column is dvh-bounded, and on mobile
Outdated
Review

🟠 Mobile peek height cap uses static vh instead of dvh, risking overflow past the visible viewport (hiding the always-visible mode bar) when panel content is tall — worsened by raising the cap from 50vh to 78vh

correctness, maintainability · flagged by 2 models

  • web/src/editor/EditorRail.tsx:65 — The mobile peek's height cap uses vh (max-h-[50vh] / new max-h-[78vh]) rather than dvh, while the container it's nested inside (GardenEditorPage.tsx:553, h-[calc(100dvh-4rem)] ... md:h-[calc(100dvh-8rem)]) was deliberately switched to dvh for the exact reason documented in the adjacent comment at GardenEditorPage.tsx:544-546 (#85): mobile Safari/Chrome's 100vh is the largest viewport (address bar hidden), so with the bar showing, any…

🪰 Gadfly · advisory

🟠 **Mobile peek height cap uses static vh instead of dvh, risking overflow past the visible viewport (hiding the always-visible mode bar) when panel content is tall — worsened by raising the cap from 50vh to 78vh** _correctness, maintainability · flagged by 2 models_ - **`web/src/editor/EditorRail.tsx:65`** — The mobile peek's height cap uses `vh` (`max-h-[50vh]` / new `max-h-[78vh]`) rather than `dvh`, while the container it's nested inside (`GardenEditorPage.tsx:553`, `h-[calc(100dvh-4rem)] ... md:h-[calc(100dvh-8rem)]`) was deliberately switched to `dvh` for the exact reason documented in the adjacent comment at `GardenEditorPage.tsx:544-546` (#85): mobile Safari/Chrome's `100vh` is the *largest* viewport (address bar hidden), so with the bar showing, any… <sub>🪰 Gadfly · advisory</sub>
// Safari/Chrome vh is the *largest* viewport, so a vh cap could overrun the
// visible area and shove the mode bar off-screen (same #85 reasoning).
tall ? 'max-h-[78dvh]' : 'max-h-[50dvh]',
'md:static md:max-h-none md:w-80 md:rounded-xl md:border md:shadow-sm',
)}
>
+25 -3
View File
@@ -1,5 +1,5 @@
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { getRouteApi } from '@tanstack/react-router'
import { Link, getRouteApi } from '@tanstack/react-router'
import { Alert } from '@/components/ui/Alert'
import { Button } from '@/components/ui/Button'
import { GardenCanvas } from '@/editor/GardenCanvas'
@@ -23,6 +23,7 @@ import { isCoarsePointer } from '@/editor/shared'
import { cn } from '@/lib/cn'
import type { EditorGarden } from '@/editor/types'
import { ShareGardenModal } from '@/components/gardens/ShareGardenModal'
import { AccountMenu } from '@/components/layout/AppShell'
import { useMe } from '@/lib/auth'
import {
toEditorObject,
@@ -544,8 +545,13 @@ export function GardenEditorPage() {
// 100dvh, not 100vh: on mobile Safari/Chrome 100vh is the *largest* viewport
// (URL bar hidden), so with the bar showing the editor overflowed and pushed
// the canvas bottom + Fit button under the browser chrome (#85).
//
// The subtracted band differs by breakpoint because the chrome does. On mobile
// the global top bar is hidden here (AppShell), so the only thing outside the
// editor is <main>'s py-6 — 3rem, top + bottom. On desktop the header is
// present, so keep the original 8rem.
return (
Outdated
Review

🟡 Mobile height subtracts 4rem but only 3rem of chrome (main py-6) exists with header hidden; leaves ~16px dead space and comment math is wrong

correctness · flagged by 2 models

  • web/src/pages/GardenEditorPage.tsx:553 — Mobile height is h-[calc(100dvh-4rem)], but with the global header hidden on mobile (AppShell.tsx header is hidden md:block), the only chrome outside the editor's flex column is <main>'s px-4 py-6 — i.e. 3rem of vertical padding (1.5rem top + 1.5rem bottom), not 4rem. Subtracting 4rem leaves ~16px of dead space the viewport would otherwise allow. This contradicts the comment at GardenEditorPage.tsx:548-551 ("only <main>'s padding is…

🪰 Gadfly · advisory

🟡 **Mobile height subtracts 4rem but only 3rem of chrome (main py-6) exists with header hidden; leaves ~16px dead space and comment math is wrong** _correctness · flagged by 2 models_ - `web/src/pages/GardenEditorPage.tsx:553` — Mobile height is `h-[calc(100dvh-4rem)]`, but with the global header hidden on mobile (`AppShell.tsx` header is `hidden md:block`), the only chrome outside the editor's flex column is `<main>`'s `px-4 py-6` — i.e. **3rem** of vertical padding (1.5rem top + 1.5rem bottom), not 4rem. Subtracting 4rem leaves ~16px of dead space the viewport would otherwise allow. This contradicts the comment at `GardenEditorPage.tsx:548-551` ("only `<main>`'s padding is… <sub>🪰 Gadfly · advisory</sub>
<div className="flex h-[calc(100dvh-8rem)] flex-col gap-3 md:flex-row">
<div className="flex h-[calc(100dvh-3rem)] flex-col gap-3 md:h-[calc(100dvh-8rem)] md:flex-row">
{/* Desktop-only control column. On mobile these move to the bottom mode bar
+ a slim top strip so the canvas — the point of the screen — isn't shoved
into a corner by a stack of controls (#99). */}
@@ -597,8 +603,17 @@ export function GardenEditorPage() {
<div className="relative flex min-h-0 flex-1 flex-col gap-2">
{/* Mobile top strip: the garden identity / season / share that live in the
desktop left column. md:hidden. */}
desktop left column, plus the way out. The global header is hidden on
mobile here (AppShell), so this leaf is the only route back to the
gardens list — it can't be dropped. md:hidden. */}
<div className="flex items-center gap-2 md:hidden">
Outdated
Review

🟡 Back affordance is a bare emoji with only aria-label; sr-only text would be more robust

maintainability · flagged by 1 model

  • web/src/components/layout/AppShell.tsx:51hideHeaderOnMobile is a single-use alias for inEditor, with a five-line comment (lines 46–50) whose rationale substantially overlaps the file-top docblock (lines 24–30: "the editor is a full-screen context… the brand link is the way back to the gardens list"). Not a defect — the alias does aid readability of the cn(...) call — but the comment is heavier than the one-line decision needs. Trivial. - web/src/pages/GardenEditorPage.tsx:609 — Co…

🪰 Gadfly · advisory

🟡 **Back affordance is a bare emoji with only aria-label; sr-only text would be more robust** _maintainability · flagged by 1 model_ - `web/src/components/layout/AppShell.tsx:51` — `hideHeaderOnMobile` is a single-use alias for `inEditor`, with a five-line comment (lines 46–50) whose rationale substantially overlaps the file-top docblock (lines 24–30: "the editor is a full-screen context… the brand link is the way back to the gardens list"). Not a defect — the alias does aid readability of the `cn(...)` call — but the comment is heavier than the one-line decision needs. Trivial. - `web/src/pages/GardenEditorPage.tsx:609` — Co… <sub>🪰 Gadfly · advisory</sub>
<Link
to="/gardens"
aria-label="All gardens"
className="-ml-1 shrink-0 rounded-md px-1.5 py-1 text-lg leading-none text-accent-strong outline-none focus-visible:ring-2 focus-visible:ring-accent/40"
>
🌱
</Link>
<h1 className="min-w-0 flex-1 truncate text-base font-semibold tracking-tight" title={garden.name}>
{garden.name}
</h1>
@@ -613,6 +628,10 @@ export function GardenEditorPage() {
Share
</Button>
)}
{/* The global header (and its account menu) is hidden on mobile in the
editor, so carry sign-out here — otherwise it's unreachable without
leaving the garden. */}
{me.data && <AccountMenu displayName={me.data.displayName} />}
</div>
{seasonYear !== null && <SeasonBanner year={seasonYear} onExit={() => setSeasonYear(null)} />}
{/* Focus toolbar is desktop-only; on mobile its plant tools move to the
1
@@ -673,6 +692,9 @@ export function GardenEditorPage() {
tabs={railTabs}
activeId={railTab}
onActivate={setRailTab}
// Panel modes want the room; the inspector stays a shorter peek (see the
// `tall` prop doc).
tall={railTab !== 'inspector'}
onClose={() => {
// Only the inspector is *about* the selection, so only closing it
// deselects; dismissing a panel leaves the canvas as you had it. Any