• Joined on 2023-01-02
steve pushed to fix/fill-edge-spacing at steve/pansy 2026-07-21 18:03:42 +00:00
958b90ebc6 Address fourth round of Gadfly findings on #76
steve commented on pull request steve/pansy#76 2026-07-21 17:26:31 +00:00
Fill: honour the half-spacing edge rule when packing plops

@gadfly review

Round 3 findings, both taken — and the first one subsumes a finding I'd declined earlier, which is a fair result:

  • **hexCenters pre-allocating rows*cols before the cap…
steve pushed to fix/fill-edge-spacing at steve/pansy 2026-07-21 17:26:00 +00:00
28af101634 Address third round of Gadfly findings on #76
steve commented on pull request steve/pansy#76 2026-07-21 16:45:48 +00:00
Fill: honour the half-spacing edge rule when packing plops

@gadfly review

(My previous comment was meant to trigger this and didn't — it lacked the trigger phrase, so the run skipped and still reported success. Everything above still stands: three…

steve commented on pull request steve/pansy#76 2026-07-21 16:14:08 +00:00
Fill: honour the half-spacing edge rule when packing plops

Re-review please — three commits have landed since the last pass.

Round 1 findings, all taken:

  • clampTo's doc justified itself by stopping hexCenters "looping forever", which this PR…
steve pushed to fix/fill-edge-spacing at steve/pansy 2026-07-21 16:13:51 +00:00
70ff970672 Address second round of Gadfly findings on #76
steve pushed to fix/fill-edge-spacing at steve/pansy 2026-07-21 14:23:24 +00:00
f8929a19a8 Address Gadfly findings on #76
steve pushed to fix/fill-edge-spacing at steve/pansy 2026-07-21 14:13:34 +00:00
3af0d08779 Fill: plant nothing for a region that misses the object entirely
steve created pull request steve/pansy#76 2026-07-21 14:11:37 +00:00
Fill: honour the half-spacing edge rule when packing plops
steve created branch fix/fill-edge-spacing in steve/pansy 2026-07-21 14:11:13 +00:00
steve pushed to fix/fill-edge-spacing at steve/pansy 2026-07-21 14:11:13 +00:00
45da4b15e2 Fill: honour the half-spacing edge rule when packing plops (#75)
steve opened issue steve/pansy#75 2026-07-21 14:10:24 +00:00
Fill packs plops against the bed edge wrong: full-pitch indent on staggered rows, overhang on the far edge
steve pushed to main at steve/pansy 2026-07-21 13:20:03 +00:00
c1c873d3f0 Record the two conventions the live v2 bugs produced
steve deleted branch fix/undo-note-alignment from steve/pansy 2026-07-21 13:02:28 +00:00
steve merged pull request steve/pansy#74 2026-07-21 13:02:27 +00:00
Let the container align the undo outcome note
steve pushed to main at steve/pansy 2026-07-21 13:02:27 +00:00
1d2f0eba56 Let the container align the undo outcome note (#74)
steve created pull request steve/pansy#74 2026-07-21 12:56:56 +00:00
Let the container align the undo outcome note
steve created branch fix/undo-note-alignment in steve/pansy 2026-07-21 12:56:44 +00:00
steve pushed to fix/undo-note-alignment at steve/pansy 2026-07-21 12:56:44 +00:00
90d4b87c32 Let the container align the undo outcome note
steve deleted branch fix/commit-survives-disconnect from steve/pansy 2026-07-21 12:49:19 +00:00