steveandClaude Fable 5
bc14bbed0d
Twenty-one prompts against the live assistant found one fabricated success,
a model that believed it was 2025, and a describe_garden that was ~450 plop
entries per turn. This is the set of fixes, each traceable to a finding:
- The gardener's LOCAL day travels with the turn (`today` on POST /agent/chat,
sent by the UI like plantedAt) into the system prompt and every dated tool
default. Left to guess, the model dated journal entries a year back; left to
the server, a 9 pm fill landed on UTC's tomorrow.
- describe_garden groups plops by plant — count, where, planted date, days to
maturity — and lists ids only for groups of ≤ 8; list_plantings spells a big
group out on demand and remove_plantings acts on one plant in a bed ("take
the beets out, leave the garlic"), which used to mean 116 single removals.
- New tools: move_planting (keeps the planting date; across beds via the new
MovePlanting, which is why the store's UPDATE now writes object_id),
update_plant, read_history, copy_garden (the "<garden> — <year>" plan
convention). fill_region takes an explicit local rectangle and a seedLotId;
place_planting's radius defaults to one plant (spacing/2) instead of a guess.
- The system prompt states the date and the gardener's units, forbids claiming
a change no tool made, says it cannot undo and points at the Undo button,
asks before clearing beds on an ambiguous sentence, and stops narrating its
own plantings into the journal.
- A mutation aimed at ANOTHER garden inside a turn is recorded under that
garden as its own change set, not filed into the open scope.
- UI: the thread scrolls inside the Assistant panel so the composer stays
put; every tool has a step label; wide tables stay inside the bubble.
Co-Authored-By: Claude Fable 5 <[email protected]>
74 lines
3.1 KiB
Go
74 lines
3.1 KiB
Go
package api
|
|
|
|
import (
|
|
"net/http"
|
|
"strconv"
|
|
"testing"
|
|
)
|
|
|
|
// TestAgentDisabledWithoutAKey — an instance with no API key must start, serve
|
|
// the app, and not offer the assistant.
|
|
//
|
|
// The contract CHANGED with #79: the chat route is now always registered (so a
|
|
// settings change can turn the assistant on without a restart), so "off" is a
|
|
// runtime 503 rather than a missing route. capabilities reports agent:false, and
|
|
// the frontend keys the chat tab off that — so a user never reaches the 503.
|
|
func TestAgentDisabledWithoutAKey(t *testing.T) {
|
|
r := authEngine(t, localCfg()) // localCfg has no agent configuration
|
|
cookie := registerAndCookie(t, r, "[email protected]")
|
|
gid := createGardenAPI(t, r, cookie, "G")
|
|
|
|
// Chat is refused, plainly, because there is no Runner to run.
|
|
w := doJSON(t, r, http.MethodPost, "/api/v1/agent/chat",
|
|
map[string]any{"gardenId": gid, "message": "plant garlic"}, cookie)
|
|
if w.Code != http.StatusServiceUnavailable {
|
|
t.Errorf("chat without a key: status %d, want 503", w.Code)
|
|
}
|
|
|
|
// Capabilities advertises the assistant as unavailable, which is what the UI
|
|
// actually consults.
|
|
w = doJSON(t, r, http.MethodGet, "/api/v1/capabilities", nil, cookie)
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("capabilities: status %d", w.Code)
|
|
}
|
|
if agent, _ := decodeMap(t, w.Body.Bytes())["agent"].(bool); agent {
|
|
t.Error("capabilities reported agent:true with no key")
|
|
}
|
|
|
|
// History is just stored data behind the ordinary garden-role check, so it
|
|
// reads fine (empty) whether or not a Runner exists — it isn't gated on one.
|
|
path := "/api/v1/gardens/" + strconv.FormatInt(gid, 10) + "/agent/history"
|
|
if w := doJSON(t, r, http.MethodGet, path, nil, cookie); w.Code != http.StatusOK {
|
|
t.Errorf("history without a key: status %d, want 200 (it's data, not the model)", w.Code)
|
|
}
|
|
|
|
// And the rest of the app is entirely unaffected.
|
|
if w := doJSON(t, r, http.MethodGet, fullPath(gid), nil, cookie); w.Code != http.StatusOK {
|
|
t.Errorf("editor load: status %d, want 200 — an unconfigured agent must not break the app", w.Code)
|
|
}
|
|
}
|
|
|
|
// TestChatRejectsAMalformedToday — the sender's local date is validated before
|
|
// anything else about the request, assistant or no assistant: a bad body is a
|
|
// 400 either way, so a client can't mistake its own bad date for the assistant
|
|
// being off.
|
|
func TestChatRejectsAMalformedToday(t *testing.T) {
|
|
r := authEngine(t, localCfg())
|
|
cookie := registerAndCookie(t, r, "[email protected]")
|
|
gid := createGardenAPI(t, r, cookie, "G")
|
|
|
|
w := doJSON(t, r, http.MethodPost, "/api/v1/agent/chat",
|
|
map[string]any{"gardenId": gid, "message": "plant garlic", "today": "Aug 22"}, cookie)
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Errorf("chat with today=%q: status %d, want 400", "Aug 22", w.Code)
|
|
}
|
|
// A well-formed date (or none) gets past validation to the runner check.
|
|
for _, today := range []string{"2026-08-22", ""} {
|
|
w := doJSON(t, r, http.MethodPost, "/api/v1/agent/chat",
|
|
map[string]any{"gardenId": gid, "message": "plant garlic", "today": today}, cookie)
|
|
if w.Code != http.StatusServiceUnavailable {
|
|
t.Errorf("chat with today=%q: status %d, want 503 (no runner configured)", today, w.Code)
|
|
}
|
|
}
|
|
}
|