steveandClaude Fable 5
b6981fbcb1
Build image / build-and-push (push) Successful in 15s
The pinned gadfly commit (c9dab69) hard-coded the reviewer image gadfly:sha-b37cd09, which has since been pruned from the registry, so every review on a new PR failed in one second at "manifest unknown" (#124's did). gadfly's current main (8adeeea) runs the reviewer as a job container whose tag resolves at run time — reviewer_tag input → GADFLY_REVIEWER_TAG var → a baked fallback (sha-b850e35, verified present) — so a retired tag can't strand the consumer stubs again. Inputs and secrets are a superset of what this stub forwards. Co-Authored-By: Claude Fable 5 <[email protected]>
65 lines
3.0 KiB
YAML
65 lines
3.0 KiB
YAML
# Gadfly adversarial review — subscribes to steve/gadfly's reusable workflow and
|
|
# INHERITS its default swarm. This stub holds only the triggers, the actor gate,
|
|
# secret forwarding, and the allow-list; the swarm config (models, lenses,
|
|
# concurrency, timeouts) lives centrally in gadfly's review-reusable.yml so it is
|
|
# tuned in ONE place. Advisory only — never blocks a merge.
|
|
|
|
name: Adversarial Review (Gadfly)
|
|
|
|
on:
|
|
pull_request:
|
|
types: [opened, reopened, ready_for_review]
|
|
issue_comment:
|
|
types: [created]
|
|
workflow_dispatch:
|
|
inputs:
|
|
pr_number:
|
|
description: "PR number to review"
|
|
required: true
|
|
|
|
permissions:
|
|
contents: read
|
|
issues: write
|
|
pull-requests: write
|
|
|
|
concurrency:
|
|
group: gadfly-${{ github.event.issue.number || github.event.pull_request.number || github.event.inputs.pr_number }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
review:
|
|
# Security: only trusted users may trigger a secret-bearing run via a PR
|
|
# comment (pull_request + workflow_dispatch are already trusted). Mirrors the
|
|
# allowed_users input below (the in-container belt-and-suspenders check) — both
|
|
# lists must stay in sync; a workflow if: can't read a workflow_call input.
|
|
if: >-
|
|
github.event_name != 'issue_comment'
|
|
|| (github.event.issue.pull_request
|
|
&& (github.actor == 'steve'
|
|
|| github.actor == 'fizi'
|
|
|| github.actor == 'dazed'))
|
|
# Pinned to an immutable gadfly commit (not @v1): our act_runners are long-lived
|
|
# and cache the reusable-workflow ref, so a moved v1 tag keeps resolving to the
|
|
# stale cached copy. A unique sha forces a cache miss → fresh fetch. Bump this
|
|
# sha to adopt central swarm changes.
|
|
#
|
|
# 8adeeea resolves the reviewer image tag at RUN time (reviewer_tag input →
|
|
# the owner's GADFLY_REVIEWER_TAG var → a baked fallback that exists in the
|
|
# registry), so a retired image tag can't strand this stub again: the previous
|
|
# pin (c9dab69) hard-coded gadfly:sha-b37cd09, which had been pruned from the
|
|
# registry by 2026-08-22 and every review died at "manifest unknown".
|
|
uses: steve/gadfly/.gitea/workflows/review-reusable.yml@8adeeeabe0738a797a1bdfc42c5176ea8ee627e4
|
|
# Least privilege: forward only the review secrets (not `secrets: inherit`,
|
|
# which would expose every repo secret). GITEA_TOKEN is the automatic token.
|
|
secrets:
|
|
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
|
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
|
GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }}
|
|
GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }}
|
|
with:
|
|
# Consumer-specific allow-list; everything else is inherited.
|
|
allowed_users: "steve,fizi,dazed"
|
|
# Gitea >= 1.27 does not propagate dispatch inputs into a called workflow's
|
|
# github.event — thread the PR number explicitly (empty on non-dispatch events).
|
|
pr_number: ${{ github.event.inputs.pr_number }}
|