Fill: refuse an empty rectangle; list plops whose plant is gone unnamed

A blank region name with a zero-area Region reached hexCenters, whose tiny-region rule plants one plop in the middle — a caller that said nothing about where got a plop at the centre. ListObjectPlantings also failed the whole listing if one plop's plant no longer existed; it now lists that plop unnamed. Co-Authored-By: Claude Fable 5 <[email protected]>
2026-08-23 00:16:54 -04:00
parent bc14bbed0d
commit a1baf4b871
2 changed files with 16 additions and 3 deletions
@@ -790,4 +790,11 @@ func TestFillByRectangleAttributesSeed(t *testing.T) {
 	if _, err := s.Fill(ctx, owner, bed.ID, FillSpec{RegionName: "all", PlantID: garlic.ID, SeedLotID: &lot.ID}); err == nil {
 		t.Error("a fill charged to a lot of a different plant succeeded")
 	}
+	// No name and no rectangle is "nowhere", not "one plop in the middle" (which
+	// is what hexCenters makes of a zero-area region).
+	for _, r := range []Region{{}, {MinX: 10, MinY: -10, MaxX: 10, MaxY: 10}, {MinX: 20, MinY: 0, MaxX: -20, MaxY: 10}} {
+		if _, err := s.Fill(ctx, owner, bed.ID, FillSpec{Region: r, PlantID: garlic.ID}); !errors.Is(err, domain.ErrInvalidInput) {
+			t.Errorf("empty rectangle %+v: err = %v, want ErrInvalidInput", r, err)
+		}
+	}
 }