From 916b2989f5558f704f2f6e79de9f2b04876b8377 Mon Sep 17 00:00:00 2001 From: Steve Dudenhoeffer Date: Sun, 23 Aug 2026 03:12:13 -0400 Subject: [PATCH] Canvas: make double-click-to-plant work on desktop MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "Double-click a bed to plant it" has done nothing since the Organic rebuild: track() captures the pointer on the SVG root, and pointer capture retargets the compatibility click/dblclick events to the root, so the onDoubleClick handler on each object's never fired. A double-click only selected. The double press is now detected in objDown itself — two presses on the same object within 400 ms and 12 px — which capture cannot retarget. The second press focuses the bed and starts no drag, so its pointerup has nothing to select into Plot; a plop in an unfocused bed already delegates to objDown, so double-clicking a plant focuses its bed too. Co-Authored-By: Claude Fable 5 --- web/src/editor/Canvas.tsx | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/web/src/editor/Canvas.tsx b/web/src/editor/Canvas.tsx index 1525af0..e420272 100644 --- a/web/src/editor/Canvas.tsx +++ b/web/src/editor/Canvas.tsx @@ -329,6 +329,16 @@ export const Canvas = forwardRef< if (!drag.current) drag.current = { t: 'pan', sx: e.clientX, sy: e.clientY, tx: st.vp.tx, ty: st.vp.ty, moved: false, th: thresh(e) } } + // The last press on an object, for double-click detection. Detected here + // rather than with onDoubleClick on the object's : track() captures the + // pointer on the SVG root, and capture retargets the compatibility click + // and dblclick events to the root, so a dblclick handler on the object + // never fires — which is why "double-click a bed to plant it" did nothing + // from the Organic rebuild until this was noticed (2026-08-23). + const lastPress = useRef<{ id: number; at: number; x: number; y: number } | null>(null) + const DOUBLE_PRESS_MS = 400 + const DOUBLE_PRESS_PX = 12 + const objDown = (o: EditorObject) => (e: ReactPointerEvent) => { e.stopPropagation() track(e) @@ -342,6 +352,17 @@ export const Canvas = forwardRef< } // Dimmed siblings stay inert inside a focused bed. if (st.focusId != null && o.id !== st.focusId) return + const prev = lastPress.current + const now = performance.now() + lastPress.current = { id: o.id, at: now, x: e.clientX, y: e.clientY } + if (prev && prev.id === o.id && now - prev.at < DOUBLE_PRESS_MS && Math.hypot(e.clientX - prev.x, e.clientY - prev.y) < DOUBLE_PRESS_PX) { + // Second press of a double-click: focus the bed to plant it. No drag + // starts, so the matching pointerup has nothing to select into Plot. + lastPress.current = null + drag.current = null + if (o.plantable) focusObject(o) + return + } if (!latest.current.canEdit) { st.setSel({ type: 'object', id: o.id }) st.setTab('plot') @@ -562,7 +583,6 @@ export const Canvas = forwardRef< opacity={dim ? DIM_OBJECT : 1} style={{ cursor: dim ? 'default' : canEdit ? 'grab' : 'pointer' }} onPointerDown={objDown(o)} - onDoubleClick={o.plantable && !dim ? () => focusObject(o) : undefined} > {o.shape === 'circle' ? (