Compare commits
5
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
17064a6d75 | ||
|
|
ecf39087a9 | ||
|
|
aa25b2c334 | ||
|
|
2b35f1741c | ||
|
|
98a2164aba |
@@ -1,12 +1,8 @@
|
|||||||
# Gadfly — agentic adversarial PR reviewer (https://gitea.stevedudenhoeffer.com/steve/gadfly).
|
# Gadfly adversarial review — subscribes to steve/gadfly's reusable workflow and
|
||||||
#
|
# INHERITS its default swarm. This stub holds only the triggers, the actor gate,
|
||||||
# Runs the published Gadfly image (pinned to an immutable :sha- tag — act_runner
|
# secret forwarding, and the allow-list; the swarm config (models, lenses,
|
||||||
# caches :latest, and this build is what carries foreman provider-type support)
|
# concurrency, timeouts) lives centrally in gadfly's review-reusable.yml so it is
|
||||||
# as a specialist swarm and posts
|
# tuned in ONE place. Advisory only — never blocks a merge.
|
||||||
# ONE consolidated review comment as gitea-actions. Advisory only — never blocks a
|
|
||||||
# merge. This reviews majordomo PRs with 9 ollama-cloud models + the M5 Mac
|
|
||||||
# (3-lens suite). Gadfly is a simple system — findings are advisory; always
|
|
||||||
# double-check before acting.
|
|
||||||
|
|
||||||
name: Adversarial Review (Gadfly)
|
name: Adversarial Review (Gadfly)
|
||||||
|
|
||||||
@@ -33,60 +29,25 @@ concurrency:
|
|||||||
jobs:
|
jobs:
|
||||||
review:
|
review:
|
||||||
# Security: only trusted users may trigger a secret-bearing run via a PR
|
# Security: only trusted users may trigger a secret-bearing run via a PR
|
||||||
# comment (pull_request + workflow_dispatch are already trusted). Mirrors
|
# comment (pull_request + workflow_dispatch are already trusted). Mirrors the
|
||||||
# GADFLY_ALLOWED_USERS, the in-container belt-and-suspenders check.
|
# allowed_users input below (the in-container belt-and-suspenders check) — both
|
||||||
|
# lists must stay in sync; a workflow if: can't read a workflow_call input.
|
||||||
if: >-
|
if: >-
|
||||||
github.event_name != 'issue_comment'
|
github.event_name != 'issue_comment'
|
||||||
|| (github.event.issue.pull_request
|
|| (github.event.issue.pull_request
|
||||||
&& (github.actor == 'steve'
|
&& (github.actor == 'steve'
|
||||||
|| github.actor == 'fizi'
|
|| github.actor == 'fizi'
|
||||||
|| github.actor == 'dazed'))
|
|| github.actor == 'dazed'))
|
||||||
runs-on: ubuntu-latest
|
# Pinned to an immutable gadfly commit (not @main): a push to gadfly can't
|
||||||
# Fleet: 9 cloud (lens fan-out) + the M5 Mac via foreman. The slow local
|
# silently change the code that runs with our forwarded secrets.
|
||||||
# lane dominates wall time, so allow plenty of headroom. (M1 was dropped —
|
uses: steve/gadfly/.gitea/workflows/review-reusable.yml@b02b11d69139843665da4cdbf776bc0b3583490d
|
||||||
# consistently slow for zero real findings.)
|
# Least privilege: forward only the review secrets (not `secrets: inherit`,
|
||||||
timeout-minutes: 90
|
# which would expose every repo secret). GITEA_TOKEN is the automatic token.
|
||||||
steps:
|
secrets:
|
||||||
- uses: docker://gitea.stevedudenhoeffer.com/steve/gadfly:sha-d7f364d
|
|
||||||
env:
|
|
||||||
GITEA_API: ${{ github.server_url }}/api/v1/repos/${{ github.repository }}
|
|
||||||
GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
|
|
||||||
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
||||||
# Local Mac, reached through its foreman queue (native Ollama on the
|
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
||||||
# wire). GADFLY_ENDPOINT_M5 registers provider "m5", a foreman-preset
|
|
||||||
# Ollama client at the secret's URL, of the form:
|
|
||||||
# foreman|https://<foreman-host>|<token>
|
|
||||||
# Needs an image with foreman provider-type support (this one). If the Mac
|
|
||||||
# is offline that model's comment shows an error and the others still post.
|
|
||||||
# (Gitea secrets aren't auto-exposed — map each explicitly.)
|
|
||||||
GADFLY_ENDPOINT_M5: ${{ secrets.GADFLY_ENDPOINT_M5 }}
|
|
||||||
# Fleet: 9 cloud + M5 Max. Cloud concurrency lives in the LENSES: cloud
|
|
||||||
# models run a few at a time (ollama-cloud=3) with their 3 lenses
|
|
||||||
# concurrent (LENS ollama-cloud=3) so comments land sooner; the Mac runs
|
|
||||||
# one model, lenses serial (its foreman queue serializes anyway). Both
|
|
||||||
# provider lanes run parallel.
|
|
||||||
GADFLY_MODELS: "minimax-m3:cloud,glm-5.2:cloud,glm-5.1:cloud,kimi-k2.7-code:cloud,deepseek-v4-pro:cloud,nemotron-3-super:cloud,gpt-oss:120b-cloud,qwen3-coder:480b-cloud,gemma4:cloud,m5/qwen3.6:35b-mlx"
|
|
||||||
GADFLY_PROVIDER_CONCURRENCY: "ollama-cloud=3,m5=1"
|
|
||||||
GADFLY_PROVIDER_LENS_CONCURRENCY: "ollama-cloud=3"
|
|
||||||
# Default => the 3-lens suite (security, correctness, error-handling).
|
|
||||||
# Set the repo var GADFLY_SPECIALISTS to override (csv / "all" / "auto").
|
|
||||||
GADFLY_SPECIALISTS: ${{ vars.GADFLY_SPECIALISTS || 'security,correctness,error-handling' }}
|
|
||||||
# Per-lens deadline + bounded steps so the slow local models stay sane.
|
|
||||||
GADFLY_TIMEOUT_SECS: "600"
|
|
||||||
GADFLY_MAX_STEPS: "14"
|
|
||||||
# Allow-list for the comment trigger (mirrors the job-level if: guard).
|
|
||||||
GADFLY_ALLOWED_USERS: "steve,fizi,dazed"
|
|
||||||
# --- findings telemetry: POST runs + findings to the gadfly-reports store ---
|
|
||||||
# Advisory & off unless GADFLY_FINDINGS_URL is set; failures only log to
|
|
||||||
# stderr and never affect the review. GADFLY_REPO / GADFLY_PR are derived
|
|
||||||
# in-container; the URL + token are user-scope secrets.
|
|
||||||
GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }}
|
GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }}
|
||||||
GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }}
|
GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }}
|
||||||
# --- event context (leave as-is) ---
|
with:
|
||||||
EVENT_NAME: ${{ github.event_name }}
|
# Consumer-specific allow-list; everything else is inherited.
|
||||||
PR: ${{ github.event.pull_request.number || github.event.issue.number || github.event.inputs.pr_number }}
|
allowed_users: "steve,fizi,dazed"
|
||||||
PR_BRANCH: ${{ github.head_ref }}
|
|
||||||
IS_DRAFT: ${{ github.event.pull_request.draft }}
|
|
||||||
COMMENT_BODY: ${{ github.event.comment.body }}
|
|
||||||
COMMENT_ID: ${{ github.event.comment.id }}
|
|
||||||
ACTOR: ${{ github.actor }}
|
|
||||||
|
|||||||
@@ -142,9 +142,11 @@ Ship work through PRs and let Gadfly review it before merge:
|
|||||||
|
|
||||||
- **Push to a PR, never straight to `main`.** Branch, push, open a PR.
|
- **Push to a PR, never straight to `main`.** Branch, push, open a PR.
|
||||||
`.gitea/workflows/adversarial-review.yml` runs Gadfly (the standalone
|
`.gitea/workflows/adversarial-review.yml` runs Gadfly (the standalone
|
||||||
agentic adversarial reviewer) — a fleet of 9 ollama-cloud models +
|
agentic adversarial reviewer) by subscribing to gadfly's reusable workflow
|
||||||
the M5 Mac via foreman, each running the 3-lens suite (security,
|
and inheriting its default swarm — 3 cloud models + the Claude Code engine
|
||||||
correctness, error-handling). Advisory only; it never blocks the merge.
|
(sonnet/opus/opus:max), each running the 5-lens suite (security, correctness,
|
||||||
|
maintainability, performance, error-handling). The swarm is tuned centrally
|
||||||
|
in gadfly, not here. Advisory only; it never blocks the merge.
|
||||||
- **Wait for Gadfly to finish, then read its output.** Don't merge while the
|
- **Wait for Gadfly to finish, then read its output.** Don't merge while the
|
||||||
review is still running. Each model posts one consolidated comment; weigh
|
review is still running. Each model posts one consolidated comment; weigh
|
||||||
every finding on its merits and fix the real ones (Gadfly is a simple
|
every finding on its merits and fix the real ones (Gadfly is a simple
|
||||||
|
|||||||
Reference in New Issue
Block a user