Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
ec9b9a9a94 |
@@ -1,8 +1,8 @@
|
|||||||
# Gadfly adversarial review — subscribes to steve/gadfly's reusable workflow and
|
# Gadfly adversarial review — subscribes to steve/gadfly's reusable workflow and
|
||||||
# INHERITS its default swarm. This stub holds only the triggers, the actor gate,
|
# INHERITS its default swarm (3 cloud models + Claude Code sonnet/opus/opus:max,
|
||||||
# secret forwarding, and the allow-list; the swarm config (models, lenses,
|
# 5-lens suite). This stub holds only the triggers, the actor gate, secret
|
||||||
# concurrency, timeouts) lives centrally in gadfly's review-reusable.yml so it is
|
# forwarding, and the allow-list; the swarm config lives centrally in gadfly's
|
||||||
# tuned in ONE place. Advisory only — never blocks a merge.
|
# review-reusable.yml. Advisory only — never blocks a merge.
|
||||||
|
|
||||||
name: Adversarial Review (Gadfly)
|
name: Adversarial Review (Gadfly)
|
||||||
|
|
||||||
@@ -29,9 +29,8 @@ concurrency:
|
|||||||
jobs:
|
jobs:
|
||||||
review:
|
review:
|
||||||
# Security: only trusted users may trigger a secret-bearing run via a PR
|
# Security: only trusted users may trigger a secret-bearing run via a PR
|
||||||
# comment (pull_request + workflow_dispatch are already trusted). Mirrors the
|
# comment (pull_request + workflow_dispatch are already trusted). Mirrors
|
||||||
# allowed_users input below (the in-container belt-and-suspenders check) — both
|
# the allowed_users input below (the in-container belt-and-suspenders check).
|
||||||
# lists must stay in sync; a workflow if: can't read a workflow_call input.
|
|
||||||
if: >-
|
if: >-
|
||||||
github.event_name != 'issue_comment'
|
github.event_name != 'issue_comment'
|
||||||
|| (github.event.issue.pull_request
|
|| (github.event.issue.pull_request
|
||||||
@@ -41,13 +40,13 @@ jobs:
|
|||||||
# Pinned to an immutable gadfly commit (not @main): a push to gadfly can't
|
# Pinned to an immutable gadfly commit (not @main): a push to gadfly can't
|
||||||
# silently change the code that runs with our forwarded secrets.
|
# silently change the code that runs with our forwarded secrets.
|
||||||
uses: steve/gadfly/.gitea/workflows/review-reusable.yml@b02b11d69139843665da4cdbf776bc0b3583490d
|
uses: steve/gadfly/.gitea/workflows/review-reusable.yml@b02b11d69139843665da4cdbf776bc0b3583490d
|
||||||
# Least privilege: forward only the review secrets (not `secrets: inherit`,
|
# Least privilege: forward ONLY the secrets the swarm uses (GITEA_TOKEN is auto).
|
||||||
# which would expose every repo secret). GITEA_TOKEN is the automatic token.
|
|
||||||
secrets:
|
secrets:
|
||||||
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
||||||
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
||||||
GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }}
|
GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }}
|
||||||
GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }}
|
GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }}
|
||||||
with:
|
with:
|
||||||
# Consumer-specific allow-list; everything else is inherited.
|
# Inherit the default swarm from gadfly's review-reusable.yml; only the
|
||||||
|
# consumer-specific allow-list is set here.
|
||||||
allowed_users: "steve,fizi,dazed"
|
allowed_users: "steve,fizi,dazed"
|
||||||
|
|||||||
@@ -142,11 +142,9 @@ Ship work through PRs and let Gadfly review it before merge:
|
|||||||
|
|
||||||
- **Push to a PR, never straight to `main`.** Branch, push, open a PR.
|
- **Push to a PR, never straight to `main`.** Branch, push, open a PR.
|
||||||
`.gitea/workflows/adversarial-review.yml` runs Gadfly (the standalone
|
`.gitea/workflows/adversarial-review.yml` runs Gadfly (the standalone
|
||||||
agentic adversarial reviewer) by subscribing to gadfly's reusable workflow
|
agentic adversarial reviewer) — a fleet of 6 ollama-cloud models, each
|
||||||
and inheriting its default swarm — 3 cloud models + the Claude Code engine
|
running the 3-lens suite (security, correctness, error-handling). Advisory
|
||||||
(sonnet/opus/opus:max), each running the 5-lens suite (security, correctness,
|
only; it never blocks the merge.
|
||||||
maintainability, performance, error-handling). The swarm is tuned centrally
|
|
||||||
in gadfly, not here. Advisory only; it never blocks the merge.
|
|
||||||
- **Wait for Gadfly to finish, then read its output.** Don't merge while the
|
- **Wait for Gadfly to finish, then read its output.** Don't merge while the
|
||||||
review is still running. Each model posts one consolidated comment; weigh
|
review is still running. Each model posts one consolidated comment; weigh
|
||||||
every finding on its merits and fix the real ones (Gadfly is a simple
|
every finding on its merits and fix the real ones (Gadfly is a simple
|
||||||
|
|||||||
Reference in New Issue
Block a user