From ecf39087a9df985028592f233560151b9e897856 Mon Sep 17 00:00:00 2001 From: Steve Dudenhoeffer Date: Sat, 27 Jun 2026 21:55:45 -0400 Subject: [PATCH] ci: switch gadfly review to the reusable workflow (curated swarm, 5 lenses) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace majordomo's full self-contained Gadfly stub with a thin caller of steve/gadfly's reusable workflow, matching mort/executus's hardened pattern: - explicit secret forwarding (least privilege); GITEA_TOKEN is the auto token. - pinned to an immutable gadfly commit (@20a5c43), not @main. Curated swarm tuned for majordomo: - 3 strong cloud models (minimax-m3, glm-5.2, deepseek-v4-pro) — dropped qwen3-coder:480b, nemotron-3-super, glm-5.1. - Claude Code engine (sonnet, opus, opus:max), claude-code=3 so all three claudes run at once. - 5-lens default suite (security, correctness, maintainability, performance, error-handling) for every model (lenses are global). Co-Authored-By: Claude Opus 4.8 (1M context) --- .gitea/workflows/adversarial-review.yml | 75 +++++++++---------------- 1 file changed, 26 insertions(+), 49 deletions(-) diff --git a/.gitea/workflows/adversarial-review.yml b/.gitea/workflows/adversarial-review.yml index 2b5d968..40b9f4e 100644 --- a/.gitea/workflows/adversarial-review.yml +++ b/.gitea/workflows/adversarial-review.yml @@ -1,12 +1,10 @@ -# Gadfly — agentic adversarial PR reviewer (https://gitea.stevedudenhoeffer.com/steve/gadfly). -# -# Runs the published Gadfly image (pinned to an immutable :sha- tag — act_runner -# caches :latest, and this build is what carries foreman provider-type support) -# as a specialist swarm and posts -# ONE consolidated review comment as gitea-actions. Advisory only — never blocks a -# merge. This reviews majordomo PRs with 6 ollama-cloud models (3-lens suite). -# Gadfly is a simple system — findings are advisory; always double-check before -# acting. +# Gadfly adversarial review — subscribes to steve/gadfly's reusable workflow. +# A curated swarm: 3 strong cloud models (minimax-m3, glm-5.2, deepseek-v4-pro) +# + the Claude Code engine (sonnet, opus, opus:max) — all three claudes run +# concurrently (claude-code=3). Every model runs the 5-lens default suite +# (security, correctness, maintainability, performance, error-handling); lenses +# are global, so this applies to the cloud AND claude models. No local Macs. +# Advisory only — never blocks a merge. name: Adversarial Review (Gadfly) @@ -34,49 +32,28 @@ jobs: review: # Security: only trusted users may trigger a secret-bearing run via a PR # comment (pull_request + workflow_dispatch are already trusted). Mirrors - # GADFLY_ALLOWED_USERS, the in-container belt-and-suspenders check. + # the allowed_users input below (the in-container belt-and-suspenders check). if: >- github.event_name != 'issue_comment' || (github.event.issue.pull_request && (github.actor == 'steve' || github.actor == 'fizi' || github.actor == 'dazed')) - runs-on: ubuntu-latest - # Fleet: 6 ollama-cloud models (lens fan-out), no local Macs. (Trimmed the - # weakest reviewers by grade — m5/qwen3.6, gemma4, gpt-oss, kimi-k2.7 — plus - # the earlier M1 drop.) Plenty of headroom for the cloud lanes. - timeout-minutes: 45 - steps: - - uses: docker://gitea.stevedudenhoeffer.com/steve/gadfly:sha-d7f364d - env: - GITEA_API: ${{ github.server_url }}/api/v1/repos/${{ github.repository }} - GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }} - OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }} - # Cloud-only fleet (no local Macs). Cloud concurrency lives in the - # LENSES: models run a few at a time (ollama-cloud=3) with their 3 lenses - # concurrent (LENS ollama-cloud=3) so comments land sooner. - GADFLY_MODELS: "minimax-m3:cloud,glm-5.2:cloud,glm-5.1:cloud,deepseek-v4-pro:cloud,nemotron-3-super:cloud,qwen3-coder:480b-cloud" - GADFLY_PROVIDER_CONCURRENCY: "ollama-cloud=3" - GADFLY_PROVIDER_LENS_CONCURRENCY: "ollama-cloud=3" - # Default => the 3-lens suite (security, correctness, error-handling). - # Set the repo var GADFLY_SPECIALISTS to override (csv / "all" / "auto"). - GADFLY_SPECIALISTS: ${{ vars.GADFLY_SPECIALISTS || 'security,correctness,error-handling' }} - # Per-lens deadline + bounded steps to keep each reviewer's run sane. - GADFLY_TIMEOUT_SECS: "600" - GADFLY_MAX_STEPS: "14" - # Allow-list for the comment trigger (mirrors the job-level if: guard). - GADFLY_ALLOWED_USERS: "steve,fizi,dazed" - # --- findings telemetry: POST runs + findings to the gadfly-reports store --- - # Advisory & off unless GADFLY_FINDINGS_URL is set; failures only log to - # stderr and never affect the review. GADFLY_REPO / GADFLY_PR are derived - # in-container; the URL + token are user-scope secrets. - GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }} - GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }} - # --- event context (leave as-is) --- - EVENT_NAME: ${{ github.event_name }} - PR: ${{ github.event.pull_request.number || github.event.issue.number || github.event.inputs.pr_number }} - PR_BRANCH: ${{ github.head_ref }} - IS_DRAFT: ${{ github.event.pull_request.draft }} - COMMENT_BODY: ${{ github.event.comment.body }} - COMMENT_ID: ${{ github.event.comment.id }} - ACTOR: ${{ github.actor }} + # Pinned to an immutable gadfly commit (not @main): a push to gadfly can't + # silently change the code that runs with our forwarded secrets. + uses: steve/gadfly/.gitea/workflows/review-reusable.yml@20a5c431f22d43bab0f711c14ce74de3a735c110 + # Least privilege: forward ONLY the secrets this swarm uses (GITEA_TOKEN is auto). + secrets: + OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }} + CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} + GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }} + GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }} + with: + models: "minimax-m3:cloud,glm-5.2:cloud,deepseek-v4-pro:cloud,claude-code/sonnet,claude-code/opus,claude-code/opus:max" + specialists: "security,correctness,maintainability,performance,error-handling" + provider_concurrency: "ollama-cloud=3,claude-code=3" + provider_lens_concurrency: "ollama-cloud=3" + timeout_secs: "600" + max_steps: "14" + allowed_users: "steve,fizi,dazed" + timeout_minutes: 90