internal/router: priority queues so batch jobs yield to interactive requests
The GPU is a size-1 resource, so a single long job monopolises the box for its
whole duration and every interactive request queues behind it. Callers can now
declare intent with an X-LlamaSwap-Priority header and the serial scheduler
dispatches by score instead of by arrival.
- X-LlamaSwap-Priority: signed integer, 0 default, absent/unparseable means 0.
interactive/normal/batch aliases resolve to +100/0/-100. Values are not
clamped: the caller composes band and any per-user offset itself.
- serial dispatch score = priority + swap affinity + aging. Bands sit 100 apart
so a small caller offset orders work inside a band without crossing one;
aging is unbounded so low-priority work cannot starve.
- routing.scheduler.settings.serial.{agingDivisor,swapAffinityBonus}, defaulting
to 60s/point and +10. swapAffinityBonus is capped at 99 so it can never
promote a request into the next band.
- fifo adds the header to its per-model priority, so the header is not silently
ignored under that scheduler.
- /metrics exports per-band queue depth, oldest wait and dispatch counts, plus
counters for how often aging or swap affinity changed the pick. Each request
records its priority, band, score and queue wait in the activity log.
Note swapAffinityBonus defaults to 10, so equal-priority requests for the
already-loaded model now run before older requests that need a swap. Set it to
0 for the previous strict arrival order.
fixes #9
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01WUyhZBgv8BBCC5MduX88gE
This commit is contained in:
@@ -8,10 +8,12 @@ import (
|
||||
"regexp"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/mostlygeek/llama-swap/internal/config"
|
||||
"github.com/mostlygeek/llama-swap/internal/logmon"
|
||||
"github.com/mostlygeek/llama-swap/internal/process"
|
||||
"github.com/mostlygeek/llama-swap/internal/router/scheduler"
|
||||
"github.com/mostlygeek/llama-swap/internal/shared"
|
||||
)
|
||||
|
||||
@@ -301,6 +303,8 @@ func TestServer_HandleUpstream_MetricsSkipsGET(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestServer_HandleMetrics_Unavailable(t *testing.T) {
|
||||
// No perf monitor and a scheduler that reports no queue stats: nothing to
|
||||
// serve.
|
||||
s := newTestServer(newStubRouter(nil, ""), newStubRouter(nil, ""))
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
@@ -310,6 +314,44 @@ func TestServer_HandleMetrics_Unavailable(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestServer_HandleMetrics_SchedulerQueue verifies the scheduler queue is
|
||||
// exported even when performance monitoring is off, and that every band gets a
|
||||
// series so the label set stays stable while the queue drains.
|
||||
func TestServer_HandleMetrics_SchedulerQueue(t *testing.T) {
|
||||
local := newStubRouter(nil, "")
|
||||
local.queueStats = &scheduler.QueueStats{
|
||||
Bands: map[string]scheduler.BandStats{
|
||||
shared.BandInteractive: {Depth: 2, OldestWait: 3 * time.Second, Dispatched: 41},
|
||||
shared.BandBatch: {Depth: 1, Dispatched: 7},
|
||||
},
|
||||
AgingReorders: 5,
|
||||
AffinityReorders: 9,
|
||||
}
|
||||
s := newTestServer(local, newStubRouter(nil, ""))
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
s.ServeHTTP(w, httptest.NewRequest(http.MethodGet, "/metrics", nil))
|
||||
if w.Code != http.StatusOK {
|
||||
t.Fatalf("status = %d, want 200", w.Code)
|
||||
}
|
||||
|
||||
body := w.Body.String()
|
||||
for _, want := range []string{
|
||||
`llamaswap_scheduler_queue_depth{band="interactive"} 2`,
|
||||
`llamaswap_scheduler_queue_depth{band="normal"} 0`,
|
||||
`llamaswap_scheduler_queue_depth{band="batch"} 1`,
|
||||
`llamaswap_scheduler_queue_oldest_wait_seconds{band="interactive"} 3`,
|
||||
`llamaswap_scheduler_dispatched_total{band="interactive"} 41`,
|
||||
`llamaswap_scheduler_dispatched_total{band="batch"} 7`,
|
||||
`llamaswap_scheduler_reorders_total{cause="aging"} 5`,
|
||||
`llamaswap_scheduler_reorders_total{cause="swap_affinity"} 9`,
|
||||
} {
|
||||
if !strings.Contains(body, want) {
|
||||
t.Errorf("missing %q in:\n%s", want, body)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func TestServer_Redirects(t *testing.T) {
|
||||
s := newTestServer(newStubRouter(nil, ""), newStubRouter(nil, ""))
|
||||
|
||||
|
||||
Reference in New Issue
Block a user