steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: sanitize cookie expires for Playwright compatibility #85

Merged
Claude merged 1 commits from fix/84-cookie-expires-validation into main 2026-03-13 01:29:07 +00:00
Conversation 0 Commits 1 Files Changed 1 +6 -1
Claude commented 2026-03-13 01:28:57 +00:00
Collaborator
Copy Link

Summary

  • Sanitize the expires value in cookieToPlaywrightOptionalCookie() so that zero time.Time or non-positive unix timestamps are converted to -1 (session cookie), which is what Playwright expects.
  • This fixes the "Cookie should have a valid expires" warning that fires on every browser init when loading cookies from the jar.

Changes

  • playwright.go: Added expires validation before constructing OptionalCookie. If cookie.Expires.IsZero() or the unix timestamp is <= 0, expires is set to -1.

Fixes #84

## Summary - Sanitize the `expires` value in `cookieToPlaywrightOptionalCookie()` so that zero `time.Time` or non-positive unix timestamps are converted to `-1` (session cookie), which is what Playwright expects. - This fixes the `"Cookie should have a valid expires"` warning that fires on every browser init when loading cookies from the jar. ## Changes - `playwright.go`: Added expires validation before constructing `OptionalCookie`. If `cookie.Expires.IsZero()` or the unix timestamp is `<= 0`, expires is set to `-1`. Fixes #84
Claude added 1 commit 2026-03-13 01:28:58 +00:00
fix: sanitize cookie expires for Playwright compatibility
All checks were successful
CI / build (pull_request) Successful in 1m51s
Details
CI / vet (pull_request) Successful in 2m38s
Details
CI / test (pull_request) Successful in 2m59s
Details
84e811572b 
Playwright requires cookie expires to be either -1 (session cookie) or
a positive unix timestamp. When a cookie has no expiry (zero time.Time),
.Unix() returns -62135596800 which Playwright rejects. Cookies with
non-positive timestamps (e.g. Cloudflare's __cf_bm) also fail.

Now treats zero time or non-positive unix timestamps as session cookies
by setting expires to -1.

Fixes #84

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude merged commit d89031b20d into main 2026-03-13 01:29:07 +00:00
Claude deleted branch fix/84-cookie-expires-validation 2026-03-13 01:29:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#85
Delete Branch "fix/84-cookie-expires-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?