steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: secure field lost in cookie round-trip & batch AddCookies failure #77

Merged
steve merged 1 commits from fix/75-cookie-secure-field-roundtrip into main 2026-02-24 02:14:43 +00:00
Conversation 0 Commits 1 Files Changed 3 +145 -6
Claude commented 2026-02-24 02:13:28 +00:00
Collaborator
Copy Link

Summary

  • Map the Secure field in both cookieToPlaywrightOptionalCookie and playwrightCookieToCookie — previously it was silently dropped, causing cookies with __Secure-/__Host- prefixes to be rejected by Chromium
  • Replace the batch AddCookies call with one-by-one cookie adding, logging slog.Warn on failure instead of failing browser creation entirely
  • Add 5 unit tests for the conversion functions covering Secure true/false and edge cases

Closes #75

## Summary - Map the `Secure` field in both `cookieToPlaywrightOptionalCookie` and `playwrightCookieToCookie` — previously it was silently dropped, causing cookies with `__Secure-`/`__Host-` prefixes to be rejected by Chromium - Replace the batch `AddCookies` call with one-by-one cookie adding, logging `slog.Warn` on failure instead of failing browser creation entirely - Add 5 unit tests for the conversion functions covering `Secure` true/false and edge cases Closes #75
Claude added 1 commit 2026-02-24 02:13:29 +00:00
fix: map Secure field in cookie conversions and add per-cookie error handling
All checks were successful
CI / vet (pull_request) Successful in 1m7s
Details
CI / build (pull_request) Successful in 1m7s
Details
CI / test (pull_request) Successful in 1m10s
Details
debf0ee2ed 
The Secure field was dropped in both Playwright<->internal cookie
conversion functions, causing cookies with __Secure-/__Host- prefixes
to be rejected by Chromium. Additionally, batch AddCookies meant one
invalid cookie would fail browser creation entirely.

Changes:
- Map Secure field in cookieToPlaywrightOptionalCookie and
  playwrightCookieToCookie
- Add cookies one-by-one with slog.Warn on failure instead of
  failing the entire batch
- Add unit tests for both conversion functions

Closes #75

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
steve merged commit 39371dc261 into main 2026-02-24 02:14:43 +00:00
steve deleted branch fix/75-cookie-secure-field-roundtrip 2026-02-24 02:14:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#77
Delete Branch "fix/75-cookie-secure-field-roundtrip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?