steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: default viewport and engine-aligned User-Agent #73

Merged
steve merged 1 commits from fix/70-default-viewport-ua-alignment into main 2026-02-24 01:29:37 +00:00
Conversation 0 Commits 1 Files Changed 4 +94 -11
Claude commented 2026-02-24 01:28:23 +00:00
Collaborator
Copy Link

Summary

  • Add per-engine UA constants (DefaultFirefoxUserAgent, DefaultChromiumUserAgent) with DefaultUserAgent kept as backward-compatible alias
  • initBrowser now auto-selects the matching UA based on opt.Browser when the caller hasn't explicitly set one — fixes Firefox UA being applied to Chromium instances
  • Add 1920x1080 default viewport to NewBrowser (previously had none — a strong headless signal)
  • NewInteractiveBrowser also gains engine-aware UA selection (keeps its existing 1280x720 viewport)
  • Tests cover UA constant content, backward-compat alias, and mergeOptions viewport/UA behavior

Closes #70
Relates to #68

Test plan

  • go build ./... succeeds
  • go test ./... all pass (including 8 new tests)
  • go vet ./... clean
  • Verify cmd/browser/pkg/browser/flags.go still compiles with DefaultUserAgent alias

🤖 Generated with Claude Code

## Summary - Add per-engine UA constants (`DefaultFirefoxUserAgent`, `DefaultChromiumUserAgent`) with `DefaultUserAgent` kept as backward-compatible alias - `initBrowser` now auto-selects the matching UA based on `opt.Browser` when the caller hasn't explicitly set one — fixes Firefox UA being applied to Chromium instances - Add 1920x1080 default viewport to `NewBrowser` (previously had none — a strong headless signal) - `NewInteractiveBrowser` also gains engine-aware UA selection (keeps its existing 1280x720 viewport) - Tests cover UA constant content, backward-compat alias, and mergeOptions viewport/UA behavior Closes #70 Relates to #68 ## Test plan - [x] `go build ./...` succeeds - [x] `go test ./...` all pass (including 8 new tests) - [x] `go vet ./...` clean - [ ] Verify `cmd/browser/pkg/browser/flags.go` still compiles with `DefaultUserAgent` alias 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Claude added 1 commit 2026-02-24 01:28:24 +00:00
fix: set default viewport for NewBrowser and align User-Agent with engine
All checks were successful
CI / vet (pull_request) Successful in 1m6s
Details
CI / build (pull_request) Successful in 1m11s
Details
CI / test (pull_request) Successful in 1m11s
Details
6647e4f63d 
NewBrowser previously had no viewport (strong headless signal) and used a
Firefox User-Agent unconditionally, even for Chromium instances (detectable
mismatch).

Add per-engine UA constants (DefaultFirefoxUserAgent, DefaultChromiumUserAgent)
and auto-select the matching UA in initBrowser when the caller hasn't set one
explicitly. Keep DefaultUserAgent as a backward-compatible alias.

Add 1920x1080 default viewport to NewBrowser (most common desktop resolution).
NewInteractiveBrowser keeps its existing 1280x720 default but also gains
engine-aware UA selection.

Closes #70

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
steve merged commit 8eb69c1dee into main 2026-02-24 01:29:37 +00:00
steve deleted branch fix/70-default-viewport-ua-alignment 2026-02-24 01:29:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#73
Delete Branch "fix/70-default-viewport-ua-alignment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?