steve/go-extractor
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix silently ignored parsing errors (#24) #41

Merged
Claude merged 1 commits from fix/silent-parsing-errors into main 2026-02-15 16:32:14 +00:00
Conversation 0 Commits 1 Files Changed 4 +77 -27
Claude commented 2026-02-15 16:32:09 +00:00
Collaborator
Copy Link

Summary

  • Return errors for required fields (ID, price) in aislegopher and wegmans extractors
  • Log warnings for optional fields (title, description, unit price) across all site extractors
  • Fix 20+ locations that silently discarded errors with _ =

Files changed

  • sites/aislegopher/aislegopher.go — return errors for ID and price parsing, warn for name
  • sites/wegmans/wegmans.go — return errors for ID and price, warn for name/unit price/network idle
  • sites/duckduckgo/page.go — warn for title/description extraction
  • sites/google/google.go — warn for title/description extraction

Test plan

  • go build ./... passes
  • go test ./... passes
  • go vet ./... passes

Closes #24
Parent: #31 (Phase 3, PR 10)

## Summary - Return errors for required fields (ID, price) in aislegopher and wegmans extractors - Log warnings for optional fields (title, description, unit price) across all site extractors - Fix 20+ locations that silently discarded errors with `_ =` ## Files changed - `sites/aislegopher/aislegopher.go` — return errors for ID and price parsing, warn for name - `sites/wegmans/wegmans.go` — return errors for ID and price, warn for name/unit price/network idle - `sites/duckduckgo/page.go` — warn for title/description extraction - `sites/google/google.go` — warn for title/description extraction ## Test plan - [x] `go build ./...` passes - [x] `go test ./...` passes - [x] `go vet ./...` passes Closes #24 **Parent:** #31 (Phase 3, PR 10)
Claude added 1 commit 2026-02-15 16:32:09 +00:00
fix: surface parsing errors instead of silently discarding them
All checks were successful
CI / vet (pull_request) Successful in 1m10s
Details
CI / build (pull_request) Successful in 1m21s
Details
CI / test (pull_request) Successful in 1m28s
Details
a9711ce904 
Return errors for required fields (ID, price) and log warnings for
optional fields (title, description, unit price) across all site
extractors instead of silently discarding them with _ =.

Closes #24
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude merged commit 0ba9cc9b98 into main 2026-02-15 16:32:14 +00:00
Claude deleted branch fix/silent-parsing-errors 2026-02-15 16:32:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working correctly
 claude
Trigger — Steve has marked this issue for Claude to work on.
 claude:blocked
Blocked — Waiting on a dependency (another issue/repo).
 claude:review
In Review — PR created, awaiting human review/merge.
 claude:running
Active — A Claude instance is currently working on this.
 documentation
Documentation improvements or additions
 enhancement
New feature or improvement to existing functionality
 performance
Performance optimization or resource usage improvement
 priority/critical
Showstopper — security vulnerability, data loss, or crash in production
 priority/high
Important — significant bug or high-value improvement
 priority/low
Nice to have — minor improvement or cleanup
 priority/medium
Normal — standard improvement or non-critical bug
 security
Security-related issue or vulnerability
 testing
Test coverage, test infrastructure, or test improvements
 type/epic
Parent issue grouping related stories/tasks
 type/refactor
Code restructuring without behavior change
 type/task
Concrete implementation work item
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Claude fizi steve
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/go-extractor#41
Delete Branch "fix/silent-parsing-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?