enhancement: Cookie type missing SameSite attribute #22

New Issue

Claude · 2026-02-14T16:07:24Z

Claude commented

2026-02-14 16:07:24 +00:00

Parent: #3

Description

The Cookie struct in cookiejar.go:9-17 is missing the SameSite attribute:

type Cookie struct {
    Host     string
    Path     string
    Expires  time.Time
    Secure   bool
    HttpOnly bool
    Name     string
    Value    string
    // Missing: SameSite
}

Playwright's Cookie type includes SameSite (Strict, Lax, None), but this field is lost during conversion in playwrightCookieToCookie() (playwright.go:80-89).

Impact

Low — the current use cases may not need SameSite. But for completeness, especially for the cookie jar's cookies.txt import/export, supporting this field would improve fidelity.

Fix

Add SameSite string to Cookie and update the conversion functions.

**Parent:** #3 ## Description The `Cookie` struct in `cookiejar.go:9-17` is missing the `SameSite` attribute: ```go type Cookie struct { Host string Path string Expires time.Time Secure bool HttpOnly bool Name string Value string // Missing: SameSite } ``` Playwright's `Cookie` type includes `SameSite` (`Strict`, `Lax`, `None`), but this field is lost during conversion in `playwrightCookieToCookie()` (`playwright.go:80-89`). ## Impact Low — the current use cases may not need SameSite. But for completeness, especially for the cookie jar's `cookies.txt` import/export, supporting this field would improve fidelity. ## Fix Add `SameSite string` to `Cookie` and update the conversion functions.

Claude added the enhancement priority/low labels 2026-02-14 16:07:39 +00:00

Claude referenced this issue

2026-02-14 16:09:05 +00:00

Epic: Code Quality & Duplication #3

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude referenced this issue

2026-02-15 16:29:14 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude commented

2026-02-15 16:32:34 +00:00

Starting work on this. Will add SameSite field to Cookie struct and update Playwright conversion functions.

Starting work on this. Will add `SameSite` field to `Cookie` struct and update Playwright conversion functions.

Claude referenced this issue from a commit

2026-02-15 16:34:59 +00:00

enhance: thread-safe CookieJar, SameSite cookie attr, dynamic Google countries

Claude referenced this issue

2026-02-15 16:35:06 +00:00

Thread-safe CookieJar, SameSite, Google countries #42

Claude commented

2026-02-15 16:35:18 +00:00

Work finished — added SameSite field to Cookie struct with SameSiteStrict, SameSiteLax, SameSiteNone constants. Playwright conversion functions updated. Merged in PR #42.

Work finished — added `SameSite` field to `Cookie` struct with `SameSiteStrict`, `SameSiteLax`, `SameSiteNone` constants. Playwright conversion functions updated. Merged in PR #42.

Claude referenced this issue

2026-02-15 16:35:27 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude commented

2026-02-15 20:57:34 +00:00

Resolved by PR #42 — added SameSite field to Cookie struct and updated conversion functions.

Resolved by PR #42 — added `SameSite` field to `Cookie` struct and updated conversion functions.

Claude referenced this issue

2026-02-15 20:57:39 +00:00

Epic: Security Hardening #2

Claude referenced this issue

2026-02-15 20:57:40 +00:00