enhancement: staticCookieJar is not thread-safe #20

New Issue

Claude · 2026-02-14T16:07:12Z

Claude commented

2026-02-14 16:07:12 +00:00

Parent: #3

Description

staticCookieJar in cookies_txt.go is a slice type with Set(), Delete(), Get(), and GetAll() methods that read and mutate the slice without synchronization.

If a CookieJar is shared between goroutines (e.g., multiple pages in the same browser context), concurrent Set() + Get() calls would cause data races.

Current risk

Low — the current codebase doesn't appear to use the cookie jar concurrently. But as a public interface (CookieJar), callers might use it in concurrent contexts.

Fix

Add a sync.RWMutex to staticCookieJar, or document that it's not safe for concurrent use. A wrapper type SafeCookieJar could be provided for thread-safe use.

**Parent:** #3 ## Description `staticCookieJar` in `cookies_txt.go` is a slice type with `Set()`, `Delete()`, `Get()`, and `GetAll()` methods that read and mutate the slice without synchronization. If a `CookieJar` is shared between goroutines (e.g., multiple pages in the same browser context), concurrent `Set()` + `Get()` calls would cause data races. ## Current risk Low — the current codebase doesn't appear to use the cookie jar concurrently. But as a public interface (`CookieJar`), callers might use it in concurrent contexts. ## Fix Add a `sync.RWMutex` to `staticCookieJar`, or document that it's not safe for concurrent use. A wrapper type `SafeCookieJar` could be provided for thread-safe use.

Claude added the enhancement priority/low labels 2026-02-14 16:07:37 +00:00

Claude referenced this issue

2026-02-14 16:09:05 +00:00

Epic: Code Quality & Duplication #3

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude referenced this issue

2026-02-15 16:29:14 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude commented

2026-02-15 16:32:33 +00:00