bug: archive.Archive() can nil-pointer panic on SelectFirst #10

New Issue

Claude · 2026-02-14T16:06:05Z

Claude commented

2026-02-14 16:06:05 +00:00

Parent: #1

Description

In sites/archive/archive.go:107-114:

err = doc.SelectFirst("input[name='url']").Type(u.String())

SelectFirst returns nil if the selector doesn't match any element (see nodes.go:15-19 — First() returns nil for empty Nodes). If the archive.ph page layout changes or loads differently, calling .Type() on a nil Node will cause a nil pointer panic.

Same issue on line 114:

err = doc.SelectFirst("form#submiturl input[type=\"submit\"]").Click()

Fix

Check for nil before calling methods:

input := doc.SelectFirst("input[name='url']")
if input == nil {
    _ = doc.Close()
    return nil, fmt.Errorf("failed to find URL input field")
}
err = input.Type(u.String())

**Parent:** #1 ## Description In `sites/archive/archive.go:107-114`: ```go err = doc.SelectFirst("input[name='url']").Type(u.String()) ``` `SelectFirst` returns `nil` if the selector doesn't match any element (see `nodes.go:15-19` — `First()` returns `nil` for empty `Nodes`). If the archive.ph page layout changes or loads differently, calling `.Type()` on a nil `Node` will cause a nil pointer panic. Same issue on line 114: ```go err = doc.SelectFirst("form#submiturl input[type=\"submit\"]").Click() ``` ## Fix Check for nil before calling methods: ```go input := doc.SelectFirst("input[name='url']") if input == nil { _ = doc.Close() return nil, fmt.Errorf("failed to find URL input field") } err = input.Type(u.String()) ```

Claude added the bug priority/high type/task labels 2026-02-14 16:06:17 +00:00

Claude referenced this issue

2026-02-14 16:09:00 +00:00

Epic: Error Handling & Correctness #1

Claude referenced this issue

2026-02-15 15:59:00 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude referenced this issue

2026-02-15 16:11:12 +00:00

Master plan: address all open issues (17 PRs across 5 phases) #31

Claude commented

2026-02-15 16:13:12 +00:00

Starting work on this as part of PR 2 (also includes #11). Will add nil guards for SelectFirst() results in archive.go and nil check for resp in document.go:Refresh().

Starting work on this as part of PR 2 (also includes #11). Will add nil guards for `SelectFirst()` results in `archive.go` and nil check for `resp` in `document.go:Refresh()`.

Claude referenced this issue

2026-02-15 16:13:14 +00:00

bug: document.Refresh() panics if page.Reload() returns nil response #11

Claude referenced this issue from a commit

2026-02-15 16:13:48 +00:00

fix: add nil guards to prevent nil-pointer panics

Claude referenced a pull request that will close this issue

2026-02-15 16:13:55 +00:00

Fix nil-pointer panics (#10, #11) #33

Claude commented

2026-02-15 16:14:00 +00:00

Work finished. PR: #33