Steve Dudenhoeffer
7809d1b93d
Build & push image / build-and-push (push) Successful in 8s
Replace the single generic review with a suite of focused specialists, each its own review+recheck pass, merged into ONE comment (a collapsible section per lens, led by the worst verdict; the optional `improvements` lens never escalates it). - cmd/gadfly/specialists.go: built-in lenses + default suite (security, correctness, maintainability, performance, error-handling) + opt-in (tests, docs, conventions, improvements). Selection via GADFLY_SPECIALISTS (csv/"all"); custom defs via GADFLY_SPECIALIST_<NAME> env and a repo .gadfly.yml (specialists + define). Precedence: built-ins < file < env. Unknown names error but don't sink the run. - cmd/gadfly/consolidate.go: verdict parse + one-comment render. - main.go: loop specialists; per-lens failure is an inline notice, never fatal. Default timeout bumped to 600s (suite runs sequentially). - base system prompt trimmed to persona+tools+discipline+output; lens-specific focus is appended per specialist (semantic re-derivation discipline kept in base). - entrypoint default models -> single model (suite already gives breadth; cost ~= specialists × models × 2). Adds gopkg.in/yaml.v3. - docs/examples: README "Specialists" section, examples/.gadfly.yml, stub var, CLAUDE.md architecture/config. Dynamic `auto` selection is the planned next step. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
84 lines
3.8 KiB
YAML
84 lines
3.8 KiB
YAML
# Drop this in ANY Gitea repo at .gitea/workflows/adversarial-review.yml to turn
|
|
# Gadfly on. The image holds all the logic; this stub just forwards the event
|
|
# context. Advisory only — it never blocks a merge.
|
|
#
|
|
# Per-repo setup (no code changes needed):
|
|
# secret OLLAMA_CLOUD_API_KEY your Ollama Cloud key
|
|
# var OLLAMA_REVIEW_MODELS (optional) comma-separated model ids
|
|
# var GADFLY_ALLOWED_USERS (optional) who may "@gadfly review"; empty =
|
|
# any repo collaborator
|
|
# GITEA_TOKEN is provided automatically; comments post as the gitea-actions user.
|
|
|
|
name: Adversarial Review (Gadfly)
|
|
|
|
on:
|
|
pull_request:
|
|
types: [opened, reopened, ready_for_review]
|
|
issue_comment:
|
|
types: [created]
|
|
workflow_dispatch:
|
|
inputs:
|
|
pr_number:
|
|
description: "PR number to review"
|
|
required: true
|
|
|
|
permissions:
|
|
contents: read
|
|
issues: write
|
|
pull-requests: write
|
|
|
|
concurrency:
|
|
group: gadfly-${{ github.event.issue.number || github.event.pull_request.number || github.event.inputs.pr_number }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
review:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
steps:
|
|
- uses: docker://gitea.stevedudenhoeffer.com/steve/gadfly:v1
|
|
env:
|
|
GITEA_API: ${{ github.server_url }}/api/v1/repos/${{ github.repository }}
|
|
GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
|
|
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
|
OLLAMA_REVIEW_MODELS: ${{ vars.OLLAMA_REVIEW_MODELS }}
|
|
GADFLY_ALLOWED_USERS: ${{ vars.GADFLY_ALLOWED_USERS }}
|
|
# Specialist suite (optional). Empty = default suite
|
|
# (security,correctness,maintainability,performance,error-handling).
|
|
# csv to choose; "all" for everything; or define custom ones via a repo
|
|
# .gadfly.yml / GADFLY_SPECIALIST_<NAME>. See README "Specialists".
|
|
GADFLY_SPECIALISTS: ${{ vars.GADFLY_SPECIALISTS }}
|
|
# --- Models & providers (optional; default = Ollama Cloud) ----------
|
|
# Gadfly is majordomo-powered, so it can target other backends. Set a
|
|
# provider for bare model ids; point at a different endpoint with a
|
|
# base URL; supply a key (or the provider's standard env var). Examples:
|
|
#
|
|
# Local Ollama daemon (no key):
|
|
# GADFLY_PROVIDER: ollama
|
|
# GADFLY_MODELS: qwen2.5-coder:7b
|
|
# # GADFLY_BASE_URL: http://my-ollama-host:11434 # if not localhost
|
|
#
|
|
# OpenAI-compatible endpoint (incl. local Ollama's /v1):
|
|
# GADFLY_PROVIDER: openai
|
|
# GADFLY_BASE_URL: http://localhost:11434/v1
|
|
# GADFLY_MODELS: qwen2.5-coder:7b
|
|
#
|
|
# OpenAI / Anthropic / Google (supported via majordomo, UNTESTED — see README):
|
|
# GADFLY_PROVIDER: openai # then set OPENAI_API_KEY below
|
|
# OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
|
|
#
|
|
# Named endpoint aliases (reference as name/model in GADFLY_MODELS).
|
|
# vars/secrets aren't auto-exposed, so map each one explicitly:
|
|
# GADFLY_ENDPOINT_BIGBOX: ${{ vars.GADFLY_ENDPOINT_BIGBOX }} # "ollama|http://192.168.1.50:11434"
|
|
# GADFLY_MODELS: bigbox/qwen2.5-coder:7b
|
|
GADFLY_PROVIDER: ${{ vars.GADFLY_PROVIDER }}
|
|
GADFLY_BASE_URL: ${{ vars.GADFLY_BASE_URL }}
|
|
GADFLY_MODELS: ${{ vars.GADFLY_MODELS }}
|
|
EVENT_NAME: ${{ github.event_name }}
|
|
PR: ${{ github.event.pull_request.number || github.event.issue.number || github.event.inputs.pr_number }}
|
|
PR_BRANCH: ${{ github.head_ref }}
|
|
IS_DRAFT: ${{ github.event.pull_request.draft }}
|
|
COMMENT_BODY: ${{ github.event.comment.body }}
|
|
COMMENT_ID: ${{ github.event.comment.id }}
|
|
ACTOR: ${{ github.actor }}
|