fix: handle Gitea 1.27's workflow_call event name in the trigger gate #21

Merged
steve merged 1 commits from fix/gitea-127-workflow-call into main 2026-07-16 03:00:41 +00:00
Owner

Gitea 1.27 (breaking change go-gitea#37478) runs a called (reusable) workflow with github.event_name = 'workflow_call' instead of propagating the caller's event. Every consumer stub forwards EVENT_NAME from github.event_name, so since the server auto-updated (between 2026-07-13 04:31 and 2026-07-14 22:06) every review arrived as an unhandled event and hit the catch-all skip — one-second "success" runs, zero reviews. mort PRs #1445–#1447 all went unreviewed; last working run was mort job 10414 (July 13, EVENT_NAME=pull_request, 14.5 min).

Fix: reclassify workflow_call from the forwarded payload before the gate — a non-empty COMMENT_BODY can only come from issue_comment (its trigger-phrase + actor checks still apply); otherwise a PR number means a pull_request-shaped trigger (also covers dispatch-through-reusable, whose pr_number input populates PR); neither → the existing unhandled-event skip. Pre-1.27 servers still send the caller's event name and never enter the branch.

Rollout note: consumers pin the pre-replatform reusable @5007597 → image sha-3095ebf, while main now carries the executus re-platform (#20). To fix consumers without silently rolling the re-platform out, the same patch is being cut as a hotfix branch off 5007597 (binary-identical to the July-13-working image apart from the entrypoint), with consumer pins bumped to that. This PR makes main carry the fix for when the re-platform rollout happens.

🤖 Generated with Claude Code

Gitea 1.27 (breaking change go-gitea#37478) runs a called (reusable) workflow with `github.event_name = 'workflow_call'` instead of propagating the caller's event. Every consumer stub forwards `EVENT_NAME` from `github.event_name`, so since the server auto-updated (between 2026-07-13 04:31 and 2026-07-14 22:06) every review arrived as an unhandled event and hit the catch-all skip — one-second "success" runs, zero reviews. mort PRs #1445–#1447 all went unreviewed; last working run was mort job 10414 (July 13, `EVENT_NAME=pull_request`, 14.5 min). Fix: reclassify `workflow_call` from the forwarded payload before the gate — a non-empty `COMMENT_BODY` can only come from `issue_comment` (its trigger-phrase + actor checks still apply); otherwise a `PR` number means a pull_request-shaped trigger (also covers dispatch-through-reusable, whose `pr_number` input populates `PR`); neither → the existing unhandled-event skip. Pre-1.27 servers still send the caller's event name and never enter the branch. Rollout note: consumers pin the pre-replatform reusable `@5007597` → image `sha-3095ebf`, while main now carries the executus re-platform (#20). To fix consumers **without** silently rolling the re-platform out, the same patch is being cut as a hotfix branch off `5007597` (binary-identical to the July-13-working image apart from the entrypoint), with consumer pins bumped to that. This PR makes main carry the fix for when the re-platform rollout happens. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
steve added 1 commit 2026-07-16 03:00:25 +00:00
fix: handle Gitea 1.27's workflow_call event name in the trigger gate
Gadfly review (reusable) / review (pull_request) Successful in 28s
Adversarial Review (Gadfly) / review (pull_request) Successful in 28s
Build & push image / build-and-push (pull_request) Successful in 2m39s
9d74cb9c81
Gitea 1.27 (breaking change go-gitea#37478) runs a called (reusable)
workflow with github.event_name = 'workflow_call' instead of propagating
the caller's event. Every consumer stub forwards EVENT_NAME from
github.event_name, so since the server upgrade every review arrived as an
unhandled event and self-skipped in one second while reporting success —
mort PRs #1445-#1447 all went unreviewed.

Reclassify workflow_call from the forwarded payload: a non-empty
COMMENT_BODY can only come from issue_comment (trigger-phrase + actor
gates still apply); otherwise a PR number means a pull_request-shaped
trigger. Neither → the existing unhandled-event skip. Pre-1.27 servers
are unaffected.

Co-Authored-By: Claude Fable 5 <[email protected]>
steve merged commit 256344d3e1 into main 2026-07-16 03:00:41 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: steve/gadfly#21