steve
ee6e9ef9f8
executus CI / test (pull_request) Successful in 59s
All 3 cloud models converged on a real access-control bug; fixed it + the other genuine findings (the false-positives were dropped): Security (HIGH — all 3 models): - create_file_url skipped ValidateScope: a same-skill caller could mint a PUBLIC url for a file scoped to another user/run. Now runs ValidateScope (admin-aware), skipped only for the descendant-grant case — mirroring the read tools. Other real fixes: - ValidateScope hard-coded `false` at every call site (admin branch dead) -> pass inv.CallerIsAdmin (the executor sets it via the host AdminPolicy; still false/fail-closed when no admin). Stale "no admin flag" comment corrected. - create_file_url: ExpiresInSeconds clamped BEFORE the *time.Second multiply (huge values overflowed to a negative duration that slipped under the cap, minting already-expired tokens); swallowed json.Marshal error now returned. - RegisterMeta: build the default budget WITH the configured MaxPerRun (was NewInMemorySearchBudget(nil) -> hardcoded 10, ignoring MetaDeps.MaxPerRun). - classify: all-zero scores no longer return a false-positive top-1 winner; coerceClassifyScore uses strconv.ParseFloat (rejects trailing garbage like "50extra" that fmt.Sscanf silently accepted). - file_delete: honor the descendant grant (parent can clean up a worker's artifacts) — was the lone cross-skill-reject-outright file tool. - meta tools: input caps truncate at a UTF-8 rune boundary (truncateUTF8), not mid-rune. - think: removed the dead `var _ = fmt.Errorf` import-keeper; file_save default aligned to 16 MiB (matched RegisterStore). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
53 lines
1.7 KiB
Go
53 lines
1.7 KiB
Go
// kv_delete removes a single entry by (scope, key). Missing rows
|
|
// surface as the literal string "not_found" rather than an error so the
|
|
// LLM can reason "did this row exist?" without wrapping the call in
|
|
// error handling.
|
|
package tools
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"gitea.stevedudenhoeffer.com/steve/executus/tool"
|
|
)
|
|
|
|
type kvDeleteArgs struct {
|
|
Scope string `json:"scope" description:"Storage scope: 'skill', 'user:<your_id>', 'run:<run_id>', or 'root_run:<root_run_id>'."`
|
|
Key string `json:"key" description:"Key within the scope."`
|
|
}
|
|
|
|
// NewKVDelete constructs the kv_delete tool. storage nil → "not
|
|
// configured" at execute time.
|
|
func NewKVDelete(storage KVStorage) tool.Tool {
|
|
return tool.NewGatedTool[kvDeleteArgs](
|
|
"kv_delete",
|
|
"Remove an entry by (scope, key). Returns 'ok' on success or 'not_found' if no row matched.",
|
|
tool.Permission{
|
|
AuthoringRequirement: tool.RequirementAnyone,
|
|
OperatesOn: tool.ScopeCaller,
|
|
SafeForShare: true,
|
|
Categories: []string{"storage", "write"},
|
|
},
|
|
func(ctx context.Context, inv tool.Invocation, args kvDeleteArgs) (string, error) {
|
|
if storage == nil {
|
|
return "", fmt.Errorf("kv_delete: not configured")
|
|
}
|
|
if err := ValidateScope(inv, args.Scope, inv.CallerIsAdmin); err != nil {
|
|
return "", fmt.Errorf("kv_delete: %w", err)
|
|
}
|
|
if args.Key == "" {
|
|
return "", fmt.Errorf("kv_delete: key required")
|
|
}
|
|
|
|
if err := storage.KVDelete(ctx, kvPartition(inv, args.Scope), args.Scope, args.Key); err != nil {
|
|
if errors.Is(err, ErrKVNotFound) {
|
|
return "not_found", nil
|
|
}
|
|
return "", fmt.Errorf("kv_delete: %w", err)
|
|
}
|
|
return "ok", nil
|
|
},
|
|
)
|
|
}
|