.gitea/workflows/adversarial-review.yml

@@ -1,10 +1,11 @@
 # Gadfly — agentic adversarial PR reviewer (https://gitea.stevedudenhoeffer.com/steve/gadfly).
 #
-# Runs the published Gadfly image (pinned to :v1) as a specialist swarm and posts
+# Runs the published Gadfly image (pinned to an immutable :sha- tag — act_runner
+# caches :latest, and this build is what carries foreman provider-type support)
+# as a specialist swarm and posts
 # ONE consolidated review comment as gitea-actions. Advisory only — never blocks a
-# merge. This reviews executus PRs (same setup as mort: m1/m5 locals + 2 cloud,
-# 3-lens suite). Gadfly is a simple system — treat its findings as advisory and
-# double-check before acting.
+# merge. This reviews executus PRs (same setup as mort: m1/m5 foreman locals + 2
+# cloud, 3-lens suite). Gadfly is a simple system — findings are advisory; double-check.
 
 name: Adversarial Review (Gadfly)
 
@@ -44,20 +45,31 @@ jobs:
     # every PR with the 3-lens suite — the slow local lanes dominate wall time.
     timeout-minutes: 90
     steps:
-      - uses: docker://gitea.stevedudenhoeffer.com/steve/gadfly:v1
+      - uses: docker://gitea.stevedudenhoeffer.com/steve/gadfly:sha-6e3a83c
         env:
           GITEA_API: ${{ github.server_url }}/api/v1/repos/${{ github.repository }}
           GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
           OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
-          # Local Ollama boxes (each its own lane, cap 1). NOTE: both Macs must be
-          # awake/reachable for their reviews to run; if a box is offline, that
-          # model's comment shows an error and the others still post.
-          GADFLY_ENDPOINT_M1PRO: "ollama|http://192.168.0.175:11434"
-          GADFLY_ENDPOINT_M5MAX: "ollama|http://192.168.0.173:11434"
+          # Local Macs, reached through their foreman queues (native Ollama on the
+          # wire). Gadfly's GADFLY_ENDPOINT_* form with the "foreman" provider
+          # type: GADFLY_ENDPOINT_M1 registers provider "m1", _M5 registers "m5",
+          # each building a foreman-preset Ollama client at the given URL. Values
+          # (host + token) live in gitea secrets, each of the form:
+          #   foreman|https://<foreman-host>|<token>
+          # (converted from the komodo LLM_* DSNs foreman://<token>@<host>).
+          # REQUIRES a Gadfly image built with foreman provider-type support
+          # (the GADFLY_ENDPOINT "foreman|..." type); on an older image the m1/m5
+          # lanes error with "unknown provider foreman". The HTTPS-only LLM_*
+          # foreman:// DSN is the alternative that needs no image rebuild.
+          # NOTE: the Mac behind each foreman must still be awake/reachable; if a
+          # box is offline, that model's comment shows an error and the others
+          # still post. (Gitea secrets aren't auto-exposed — map each explicitly.)
+          GADFLY_ENDPOINT_M1: ${{ secrets.GADFLY_ENDPOINT_M1 }}
+          GADFLY_ENDPOINT_M5: ${{ secrets.GADFLY_ENDPOINT_M5 }}
           # 2 cloud (parallel) + M1 Pro + M5 Max — one consolidated comment each.
-          GADFLY_MODELS: "minimax-m3:cloud,deepseek-v4-flash:cloud,m1pro/qwen3:14b,m5max/qwen3.6:35b-mlx"
+          GADFLY_MODELS: "minimax-m3:cloud,deepseek-v4-flash:cloud,m1/qwen3:14b,m5/qwen3.6:35b-mlx"
           # cloud runs 2 at once; each Mac one at a time; all three lanes parallel.
-          GADFLY_PROVIDER_CONCURRENCY: "ollama-cloud=2,m1pro=1,m5max=1"
+          GADFLY_PROVIDER_CONCURRENCY: "ollama-cloud=2,m1=1,m5=1"
           # Default => the 3-lens suite (security, correctness, error-handling).
           # Set the repo var GADFLY_SPECIALISTS to override (csv / "all" / "auto").
           GADFLY_SPECIALISTS: ${{ vars.GADFLY_SPECIALISTS || 'security,correctness,error-handling' }}