From 7a5eebc4682cbf2d75c0a484557e5f2de01b1ed1 Mon Sep 17 00:00:00 2001 From: Steve Dudenhoeffer Date: Sun, 28 Jun 2026 02:05:28 -0400 Subject: [PATCH] fix(ci): restore valid adversarial-review.yml + pin gadfly reusable @7bc3c98 [skip ci] The reusable now reads swarm config from user-scope vars (GADFLY_DEFAULT_* + GADFLY_ENDPOINT_*); this immutable @sha bumps past the long-lived-runner ref cache so the vars-config reusable is adopted. Direct to main + [skip ci] to avoid triggering the review swarm. Co-Authored-By: Claude Opus 4.8 (1M context) --- .gitea/workflows/adversarial-review.yml | 56 ++++++++++++++++++++++++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/.gitea/workflows/adversarial-review.yml b/.gitea/workflows/adversarial-review.yml index ecf28d9..1f9d60f 100644 --- a/.gitea/workflows/adversarial-review.yml +++ b/.gitea/workflows/adversarial-review.yml @@ -1 +1,55 @@ -IyBHYWRmbHkgYWR2ZXJzYXJpYWwgcmV2aWV3IOKAlCBzdWJzY3JpYmVzIHRvIHN0ZXZlL2dhZGZseSdzIHJldXNhYmxlIHdvcmtmbG93IGFuZAojIElOSEVSSVRTIGl0cyBkZWZhdWx0IHN3YXJtLiBUaGlzIHN0dWIgaG9sZHMgb25seSB0aGUgdHJpZ2dlcnMsIHRoZSBhY3RvciBnYXRlLAojIHNlY3JldCBmb3J3YXJkaW5nLCBhbmQgdGhlIGFsbG93LWxpc3Q7IHRoZSBzd2FybSBjb25maWcgKG1vZGVscywgbGVuc2VzLAojIGNvbmN1cnJlbmN5LCB0aW1lb3V0cykgbGl2ZXMgY2VudHJhbGx5IGluIGdhZGZseSdzIHJldmlldy1yZXVzYWJsZS55bWwgc28gaXQgaXMKIyB0dW5lZCBpbiBPTkUgcGxhY2UuIEFkdmlzb3J5IG9ubHkg4oCUIG5ldmVyIGJsb2NrcyBhIG1lcmdlLgoKbmFtZTogQWR2ZXJzYXJpYWwgUmV2aWV3IChHYWRmbHkpCgpvbjoKICBwdWxsX3JlcXVlc3Q6CiAgICB0eXBlczogW29wZW5lZCwgcmVvcGVuZWQsIHJlYWR5X2Zvcl9yZXZpZXddCiAgaXNzdWVfY29tbWVudDoKICAgIHR5cGVzOiBbY3JlYXRlZF0KICB3b3JrZmxvd19kaXNwYXRjaDoKICAgIGlucHV0czoKICAgICAgcHJfbnVtYmVyOgogICAgICAgIGRlc2NyaXB0aW9uOiAiUFIgbnVtYmVyIHRvIHJldmlldyIKICAgICAgICByZXF1aXJlZDogdHJ1ZQoKcGVybWlzc2lvbnM6CiAgY29udGVudHM6IHJlYWQKICBpc3N1ZXM6IHdyaXRlCiAgcHVsbC1yZXF1ZXN0czogd3JpdGUKCmNvbmN1cnJlbmN5OgogIGdyb3VwOiBnYWRmbHktJHt7IGdpdGh1Yi5ldmVudC5pc3N1ZS5udW1iZXIgfHwgZ2l0aHViLmV2ZW50LnB1bGxfcmVxdWVzdC5udW1iZXIgfHwgZ2l0aHViLmV2ZW50LmlucHV0cy5wcl9udW1iZXIgfX0KICBjYW5jZWwtaW4tcHJvZ3Jlc3M6IHRydWUKCmpvYnM6CiAgcmV2aWV3OgogICAgIyBTZWN1cml0eTogb25seSB0cnVzdGVkIHVzZXJzIG1heSB0cmlnZ2VyIGEgc2VjcmV0LWJlYXJpbmcgcnVuIHZpYSBhIFBSCiAgICAjIGNvbW1lbnQgKHB1bGxfcmVxdWVzdCArIHdvcmtmbG93X2Rpc3BhdGNoIGFyZSBhbHJlYWR5IHRydXN0ZWQpLiBNaXJyb3JzIHRoZQogICAgIyBhbGxvd2VkX3VzZXJzIGlucHV0IGJlbG93ICh0aGUgaW4tY29udGFpbmVyIGJlbHQtYW5kLXN1c3BlbmRlcnMgY2hlY2spIOKAlCBib3RoCiAgICAjIGxpc3RzIG11c3Qgc3RheSBpbiBzeW5jOyBhIHdvcmtmbG93IGlmOiBjYW4ndCByZWFkIGEgd29ya2Zsb3dfY2FsbCBpbnB1dC4KICAgIGlmOiA+LQogICAgICBnaXRodWIuZXZlbnRfbmFtZSAhPSAnaXNzdWVfY29tbWVudCcKICAgICAgfHwgKGdpdGh1Yi5ldmVudC5pc3N1ZS5wdWxsX3JlcXVlc3QKICAgICAgICAgICYmIChnaXRodWIuYWN0b3IgPT0gJ3N0ZXZlJwogICAgICAgICAgICAgIHx8IGdpdGh1Yi5hY3RvciA9PSAnZml6aScKICAgICAgICAgICAgICB8fCBnaXRodWIuYWN0b3IgPT0gJ2RhemVkJykpCiAgICAjIFBpbm5lZCB0byBhbiBpbW11dGFibGUgZ2FkZmx5IGNvbW1pdCAobm90IEB2MSk6IG91ciBhY3RfcnVubmVycyBhcmUgbG9uZy1saXZlZAogICAgIyBhbmQgY2FjaGUgdGhlIHJldXNhYmxlLXdvcmtmbG93IHJlZiwgc28gYSBtb3ZlZCB2MSB0YWcga2VlcHMgcmVzb2x2aW5nIHRvIHRoZQogICAgIyBzdGFsZSBjYWNoZWQgY29weS4gQSB1bmlxdWUgc2hhIGZvcmNlcyBhIGNhY2hlIG1pc3Mg4oaSIGZyZXNoIGZldGNoLiBCdW1wIHRoaXMKICAgICMgc2hhIHRvIGFkb3B0IGNlbnRyYWwgc3dhcm0gY2hhbmdlcy4KICAgIHVzZXM6IHN0ZXZlL2dhZGZseS8uZ2l0ZWEvd29ya2Zsb3dzL3Jldmlldy1yZXVzYWJsZS55bWxAOTVhOWVjNTQ2YWZlMzBjNzBkM2ZlMTg4MWY3ZjllM2Q3ODMwZjIwYgogICAgIyBMZWFzdCBwcml2aWxlZ2U6IGZvcndhcmQgb25seSB0aGUgcmV2aWV3IHNlY3JldHMgKG5vdCBgc2VjcmV0czogaW5oZXJpdGAsCiAgICAjIHdoaWNoIHdvdWxkIGV4cG9zZSBldmVyeSByZXBvIHNlY3JldCkuIEdJVEVBX1RPS0VOIGlzIHRoZSBhdXRvbWF0aWMgdG9rZW4uCiAgICBzZWNyZXRzOgogICAgICBPTExBTUFfQ0xPVURfQVBJX0tFWTogICAgJHt7IHNlY3JldHMuT0xMQU1BX0NMT1VEX0FQSV9LRVkgfX0KICAgICAgQ0xBVURFX0NPREVfT0FVVEhfVE9LRU46ICR7eyBzZWNyZXRzLkNMQVVERV9DT0RFX09BVVRIX1RPS0VOIH19CiAgICAgIEdBREZMWV9GSU5ESU5HU19VUkw6ICAgICAke3sgc2VjcmV0cy5HQURGTFlfRklORElOR1NfVVJMIH19CiAgICAgIEdBREZMWV9GSU5ESU5HU19UT0tFTjogICAke3sgc2VjcmV0cy5HQURGTFlfRklORElOR1NfVE9LRU4gfX0KICAgIHdpdGg6CiAgICAgICMgQ29uc3VtZXItc3BlY2lmaWMgYWxsb3ctbGlzdDsgZXZlcnl0aGluZyBlbHNlIGlzIGluaGVyaXRlZC4KICAgICAgYWxsb3dlZF91c2VyczogInN0ZXZlLGZpemksZGF6ZWQiCg== \ No newline at end of file +# Gadfly adversarial review — subscribes to steve/gadfly's reusable workflow and +# INHERITS its default swarm. This stub holds only the triggers, the actor gate, +# secret forwarding, and the allow-list; the swarm config (models, lenses, +# concurrency, timeouts) lives centrally in gadfly's review-reusable.yml so it is +# tuned in ONE place. Advisory only — never blocks a merge. + +name: Adversarial Review (Gadfly) + +on: + pull_request: + types: [opened, reopened, ready_for_review] + issue_comment: + types: [created] + workflow_dispatch: + inputs: + pr_number: + description: "PR number to review" + required: true + +permissions: + contents: read + issues: write + pull-requests: write + +concurrency: + group: gadfly-${{ github.event.issue.number || github.event.pull_request.number || github.event.inputs.pr_number }} + cancel-in-progress: true + +jobs: + review: + # Security: only trusted users may trigger a secret-bearing run via a PR + # comment (pull_request + workflow_dispatch are already trusted). Mirrors the + # allowed_users input below (the in-container belt-and-suspenders check) — both + # lists must stay in sync; a workflow if: can't read a workflow_call input. + if: >- + github.event_name != 'issue_comment' + || (github.event.issue.pull_request + && (github.actor == 'steve' + || github.actor == 'fizi' + || github.actor == 'dazed')) + # Pinned to an immutable gadfly commit (not @v1): our act_runners are long-lived + # and cache the reusable-workflow ref, so a moved v1 tag keeps resolving to the + # stale cached copy. A unique sha forces a cache miss → fresh fetch. Bump this + # sha to adopt central swarm changes. + uses: steve/gadfly/.gitea/workflows/review-reusable.yml@7bc3c982fa7b72367034c673f7812bf05e9c503e + # Least privilege: forward only the review secrets (not `secrets: inherit`, + # which would expose every repo secret). GITEA_TOKEN is the automatic token. + secrets: + OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }} + CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} + GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }} + GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }} + with: + # Consumer-specific allow-list; everything else is inherited. + allowed_users: "steve,fizi,dazed"