security: scope forwarded secrets + pin gadfly reusable to an immutable sha
Address the swarm's findings on this rollout: - Replace `secrets: inherit` (which forwarded ALL repo secrets — registry/ Komodo/Discord/DB creds the reviewer never uses) with explicit forwarding of only OLLAMA_CLOUD_API_KEY / CLAUDE_CODE_OAUTH_TOKEN / findings tokens. GITEA_TOKEN is the automatic job token (github.token in the reusable). - Pin uses: ...@main -> @20a5c43 (immutable) so a push to gadfly can't change the code that runs with our forwarded secrets. Requires gadfly's review-reusable.yml secrets contract (steve/gadfly#9, merged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -36,8 +36,15 @@ jobs:
|
||||
&& (github.actor == 'steve'
|
||||
|| github.actor == 'fizi'
|
||||
|| github.actor == 'dazed'))
|
||||
uses: steve/gadfly/.gitea/workflows/review-reusable.yml@main
|
||||
secrets: inherit
|
||||
# Pinned to an immutable gadfly commit (not @main): a push to gadfly can't
|
||||
# silently change the code that runs with our forwarded secrets.
|
||||
uses: steve/gadfly/.gitea/workflows/review-reusable.yml@20a5c431f22d43bab0f711c14ce74de3a735c110
|
||||
# Least privilege: forward ONLY the secrets this swarm uses (GITEA_TOKEN is auto).
|
||||
secrets:
|
||||
OLLAMA_CLOUD_API_KEY: ${{ secrets.OLLAMA_CLOUD_API_KEY }}
|
||||
CLAUDE_CODE_OAUTH_TOKEN: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
|
||||
GADFLY_FINDINGS_URL: ${{ secrets.GADFLY_FINDINGS_URL }}
|
||||
GADFLY_FINDINGS_TOKEN: ${{ secrets.GADFLY_FINDINGS_TOKEN }}
|
||||
with:
|
||||
models: "minimax-m3:cloud,glm-5.2:cloud,glm-5.1:cloud,deepseek-v4-pro:cloud,nemotron-3-super:cloud,qwen3-coder:480b-cloud,claude-code/sonnet,claude-code/opus,claude-code/opus:max"
|
||||
specialists: "security,correctness,error-handling"
|
||||
|
||||
Reference in New Issue
Block a user