steveandClaude Opus 4.8
d59303238f
Build image / build-and-push (push) Successful in 5s
Gadfly caught me making the same mistake one level up. This PR claimed the history write is "detached from cancellation, always" — and record()'s auto-scope path still called store.WriteChangeSet directly with the caller's context, so every plain REST mutation kept the orphan-history window the PR was written to close. That is the path virtually every change takes; the agent is the exception. It goes through commitScope now, which is where the rule lives, so no caller can be the one that forgets. Tested the same way as the agent path: cancel right after the mutation returns, assert the change set exists and reverts. Also: stopBeat is deferred so a panic in the run can't leak the ticker goroutine (and is idempotent, since the handler stops it explicitly on the normal path); the keep-alive interval is a named constant rather than a literal duplicated between comment and call site; and commitScope's doc states the rule and why it lives there, instead of narrating the incident that produced it — that belongs in a commit message, which is where it now is. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01H3zbym8Doka2d7D48maSgZ