3 Commits

Include renames

Author	SHA1	Message	Date
steveandClaude Opus 4.8	a615de633f	Add sharing backend: shares CRUD + ACL enforcement everywhere (#16) ... - domain: Garden gains a computed MyRole ("owner"/"editor"/"viewer"); new ShareWithUser (share + recipient identity); sentinels ErrShareUserNotFound, ErrCannotShareWithSelf, ErrShareExists. - store/shares.go: GetShareRole, ListSharesForGarden (joined with users), CreateShare (UNIQUE → ErrShareExists), UpdateShareRole, DeleteShare. - store/gardens.go: ListGardensForActor returns owned + shared-with-me gardens, each carrying my_role (replaces the owner-only list). - service: requireGardenRole now consults garden_shares (owner implicit, else the share's role, else masked ErrNotFound) and stamps MyRole on every read-through. UpdateGarden tightened to OWNER-only (editors edit contents, not the garden). UpdatePlanting only re-checks plant visibility when the plant is CHANGED, so a shared editor can edit a plop that uses the owner's private plant. - service/shares.go: ListShares/AddShare/UpdateShareRole (owner only), RemoveShare (owner or a recipient leaving). AddShare targets an existing account by exact email; unknown → 404, self → 400, duplicate → 409. - api: GET,POST /gardens/:id/shares and PATCH,DELETE /gardens/:id/shares/:userId. Tests: the full {owner, editor, viewer, stranger} × {read, mutate object, mutate planting, edit garden, delete garden, manage shares} ACL matrix; shared gardens carry my_role; AddShare error cases; role upgrade + self-leave; plus a two-user HTTP flow. The matrix caught the editor-cannot-edit-owner's-plant bug above. GOWORK=off go build/vet/test ./internal/... green. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01JdQpdYYsTgtkJBxbcpAszi	2026-07-18 23:32:35 -04:00
steve	293532f021	Plant catalog backend: CRUD + seeded built-ins (#12) ... Co-authored-by: Steve Dudenhoeffer <[email protected]>	2026-07-19 01:48:22 +00:00
steveandClaude Opus 4.8	3fbefa4e05	Address Gadfly review on #7: garden cap, dim validation, shared errors ... Fixes from the PR #26 adversarial review (graded 18 real / 0 false positive). Correctness / security - maxGardenCM fixed to 10_000 (100 m), matching its comment — it was 100_000 cm (1 km), 10x too lax (5 models flagged this). - Dimension validation now rejects NaN/Inf (which slip past naive comparisons) and subnormal-tiny positives, via a finite [1cm, 100m] check. Name (200) and notes (10_000) are length-capped so untrusted input can't balloon storage. - Update version binding is `required,min=1`, so a negative/zero version is a 400, not a 409. Maintainability / performance - One unified writeServiceError (new errors.go) maps every auth + resource sentinel; writeResourceError removed. writeVersionConflict and parseIDParam moved to errors.go (shared, not in the gardens feature file). - Request structs share an embedded gardenFields (one toInput). - CreateGarden uses INSERT ... RETURNING (one round-trip). - ListGardensForOwner has a defensive LIMIT (pagination is post-v1). Tests: name/notes length, NaN/Inf/subnormal dims, dimension-at-cap valid, negative/zero version -> 400. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01JdQpdYYsTgtkJBxbcpAszi	2026-07-18 18:39:27 -04:00