3 Commits

Include renames

Author	SHA1	Message	Date
steveandClaude Opus 4.8	4c4abe23c6	Use objectPlantingsPath helper instead of inline URL (#88) ... Gadfly: I was wrong that no plantings-path helper existed — objectPlantingsPath is defined in plantings_test.go in the same package. Use it for the two planting POSTs in the remaining test. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01H3zbym8Doka2d7D48maSgZ	2026-07-21 22:06:57 -04:00
steveandClaude Opus 4.8	5bdaf21828	Address Gadfly findings on #88 ... - Cover the plantId filter's out-of-range branch (0, -1), not just the non-numeric one — the handler rejects id < 1. - Add the documented negative-remaining case: over-planting a lot (57 against 50 bought) drives remaining to -7 through the HTTP surface. The number is a derived truth about what's committed, not a floor at zero, and that's the signal a gardener wants. - Rename objID → oid in the remaining test to match the package convention (shares_test etc.). Not taken: relocating createPlantAPI to plants_test.go — it's shared with #89's branch and the move is cleanest once both land (consolidating with that branch's makeFillPlant), noted on both PRs. The 409 "current" assertion style is deliberate and reads clearly; matching journal_test.go's exact phrasing isn't worth a divergence churn. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01H3zbym8Doka2d7D48maSgZ	2026-07-21 20:39:43 -04:00
steveandClaude Opus 4.8	8552f1d152	API-level tests for the /seed-lots route group (#83) ... Every other handler file had a sibling API test; this group had none, which is the state PATCH/DELETE /journal/:id shipped in — implemented, unit-tested through the service, and completely unreachable. Service tests cannot see a route that was never registered or one registered with the wrong :param. Four tests, covering what a broken route would silently take with it: - Full CRUD over HTTP, including GET/PATCH/DELETE by id, the ?plantId= filter, a rejected non-numeric plantId, and a stale-version 409 carrying the current row so the client can rebase. - `remaining` is derived through the HTTP surface, not just in the service. DESIGN.md makes derivation load-bearing, and the number is the whole reason anyone opens the seed shelf. - Lots are private to the buyer: another user gets 404 (not 403 — existence is masked per the project convention) on get/patch/delete, sees none in their listing, and the owner still has access afterwards. - The group is behind requireAuth: unauthenticated calls 401 rather than returning an empty list. Verified the tests actually catch the failure they exist for by unregistering GET /seed-lots/:id — all four fail with "404 page not found", the journal signature. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01H3zbym8Doka2d7D48maSgZ	2026-07-21 18:16:40 -04:00