Address Gadfly review on #6: logout errors, register gating, guard errors
Build image / build-and-push (push) Successful in 7s

Fixes from the PR #25 adversarial review (graded 23 real / 5 false positive):

Error handling
- onLogout wraps mutateAsync in try/catch: a failed logout no longer
  becomes an unhandled rejection; the user stays put (session still valid)
  and the button offers "Retry sign out" (5 models flagged this).
- Root errorComponent (RouteError): a non-401 /auth/me failure in a
  beforeLoad guard now shows a recoverable "Try again" screen instead of
  blanking.
- Forms drop noValidate, restoring native required/type=email/minLength
  checks before hitting the server.

Correctness
- RegisterPage gates on providers.isPending/isError before rendering, so
  the form no longer briefly appears (submittable) on an SSO-only server.
- TextField id falls back to name then a useId() value, so the label/hint
  associations hold even if a caller omits both.

Maintainability
- Single safeRedirectPath (lib/redirect.ts) replaces the duplicated
  safeRedirect/safeInternalPath (4 models).
- Generic ApiError helpers (apiErrorCode, errorMessage) moved to lib/api.ts;
  LoginPage builds the OIDC URL from the exported API_BASE.
- Divider moved to components/ui/. errorMessage doc clarified.

Verified again in a real browser: register -> /gardens; Sign out -> /login.
tsc --noEmit and vite build clean.

Not changed (graded, with rationale): OIDC deep-link redirect isn't
preserved (needs backend state threading — follow-up); 60s me staleTime in
guards (server is authoritative); the login/register onSubmit catches are
the intended react-query pattern (errors render via mutation state).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01JdQpdYYsTgtkJBxbcpAszi
This commit is contained in:
2026-07-18 18:10:00 -04:00
co-authored by Claude Opus 4.8
parent 622010cd71
commit ae1906e169
10 changed files with 120 additions and 55 deletions
+20 -3
View File
@@ -4,7 +4,8 @@ import { AuthCard } from '@/components/auth/AuthCard'
import { Alert } from '@/components/ui/Alert'
import { Button } from '@/components/ui/Button'
import { TextField } from '@/components/ui/TextField'
import { apiErrorCode, errorMessage, useProviders, useRegister } from '@/lib/auth'
import { apiErrorCode, errorMessage } from '@/lib/api'
import { useProviders, useRegister } from '@/lib/auth'
const MIN_PASSWORD = 8
@@ -26,8 +27,24 @@ export function RegisterPage() {
}
}
// Don't render the form until we know local registration is offered — otherwise
// it briefly appears (and is submittable) on an SSO-only server.
if (providers.isPending) {
return (
<AuthCard title="Create account">
<p className="text-sm text-muted">Loading</p>
</AuthCard>
)
}
if (providers.isError) {
return (
<AuthCard title="Create account">
<Alert>Could not load sign-in options. Please refresh.</Alert>
</AuthCard>
)
}
// Local registration is only meaningful when local auth is enabled.
if (providers.isSuccess && !providers.data.local) {
if (!providers.data.local) {
return (
<AuthCard title="Create account">
<div className="flex flex-col gap-4">
@@ -52,7 +69,7 @@ export function RegisterPage() {
</Link>
</div>
) : (
<form onSubmit={onSubmit} className="flex flex-col gap-3" noValidate>
<form onSubmit={onSubmit} className="flex flex-col gap-3">
<TextField
label="Email"
name="email"