Add OIDC login via Authentik: PKCE, JIT provisioning, email linking (#5)
Build image / build-and-push (push) Successful in 5s
Gadfly review (reusable) / review (pull_request) Successful in 9m32s
Adversarial Review (Gadfly) / review (pull_request) Successful in 9m32s

OIDC is pansy's primary login path (Authentik the target IdP); local
auth (#4) remains the fallback and both issue the same session cookie.

- deps: github.com/coreos/go-oidc/v3 + golang.org/x/oauth2 (both pure Go;
  CGO stays off).
- api/oidc.go: lazy issuer discovery (retried per-request, never crashes
  a server that also serves local auth), GET /auth/oidc/login builds an
  authorization-code URL with PKCE S256 + random state + nonce stashed in
  a short-lived HttpOnly cookie, GET /auth/oidc/callback verifies state
  (constant-time), exchanges the code with the PKCE verifier, verifies the
  ID token + nonce, and starts a pansy session. Failures redirect to
  /login?error=... ; success to /gardens.
- service.LoginOIDC: (issuer,subject) match -> login; else *verified*
  email match -> link onto the existing account; else JIT-create (the IdP
  gates access, so PANSY_REGISTRATION doesn't apply). Unverified email
  colliding with an existing account is refused (takeover guard); no email
  is refused (email is the account key). Reuses the atomic CreateUser.
- store: GetUserByOIDC + LinkOIDC (unique-pair backstop).
- config: OIDCReady() (needs issuer+client+BaseURL for the redirect URI);
  /auth/providers now reports oidc from it and defaults the button label
  to "Sign in with Authentik". OIDC routes are only registered when ready,
  so an unconfigured instance 404s them.
- PANSY_LOCAL_AUTH=false rejects/hides local auth but not OIDC.

Tests: service provisioning (JIT, repeat login, link, unverified-collision
refusal, no-email, name fallback, works with local auth off); api
(routes-absent-when-unconfigured, providers reporting, login redirect with
PKCE params + tx cookie via a fake discovery server, callback state/error
paths). Smoke-tested: unreachable issuer degrades to error=oidc_unavailable
with the server still up and local auth working.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01JdQpdYYsTgtkJBxbcpAszi
This commit is contained in:
2026-07-18 17:13:47 -04:00
co-authored by Claude Opus 4.8
parent eb03d09d19
commit 84edf3e42a
12 changed files with 664 additions and 20 deletions
+9 -1
View File
@@ -56,6 +56,14 @@ func (o OIDCConfig) Enabled() bool {
return o.Issuer != "" && o.ClientID != ""
}
// OIDCReady reports whether OIDC login can actually be offered: it needs an
// issuer + client ID and a BaseURL to build the absolute redirect URI that
// providers require. Both the login page (via /auth/providers) and route
// registration gate on this, so the advertised methods match the live routes.
func (c *Config) OIDCReady() bool {
return c.OIDC.Enabled() && c.BaseURL != ""
}
// RegistrationOpen reports whether local self-service signup is allowed.
func (c *Config) RegistrationOpen() bool {
return c.Registration == RegistrationOpen
@@ -74,7 +82,7 @@ func Load() *Config {
Issuer: envStr("PANSY_OIDC_ISSUER", ""),
ClientID: envStr("PANSY_OIDC_CLIENT_ID", ""),
ClientSecret: envStr("PANSY_OIDC_CLIENT_SECRET", ""),
ButtonLabel: envStr("PANSY_OIDC_BUTTON_LABEL", "Sign in with SSO"),
ButtonLabel: envStr("PANSY_OIDC_BUTTON_LABEL", "Sign in with Authentik"),
},
TrustedProxies: envList("PANSY_TRUSTED_PROXIES"),
}